Commit-ID:  7ff8517e1034f26dde03d6df4026f085480408f0
Gitweb:     https://git.kernel.org/tip/7ff8517e1034f26dde03d6df4026f085480408f0
Author:     Bart Van Assche <bvanass...@acm.org>
AuthorDate: Thu, 14 Feb 2019 15:00:37 -0800
Committer:  Ingo Molnar <mi...@kernel.org>
CommitDate: Thu, 28 Feb 2019 07:55:39 +0100

locking/lockdep: Fix reported required memory size (1/2)

Change the sizeof(array element time) * (array size) expressions into
sizeof(array). This fixes the size computations of the classhash_table[]
and chainhash_table[] arrays.

The reason is that commit:

  a63f38cc4ccf ("locking/lockdep: Convert hash tables to hlists")

changed the type of the elements of that array from 'struct list_head' into
'struct hlist_head'.

Signed-off-by: Bart Van Assche <bvanass...@acm.org>
Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org>
Cc: Andrew Morton <a...@linux-foundation.org>
Cc: Johannes Berg <johan...@sipsolutions.net>
Cc: Linus Torvalds <torva...@linux-foundation.org>
Cc: Paul E. McKenney <paul...@linux.vnet.ibm.com>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: Waiman Long <long...@redhat.com>
Cc: Will Deacon <will.dea...@arm.com>
Cc: johannes.b...@intel.com
Cc: t...@kernel.org
Link: https://lkml.kernel.org/r/20190214230058.196511-3-bvanass...@acm.org
Signed-off-by: Ingo Molnar <mi...@kernel.org>
---
 kernel/locking/lockdep.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 5c5283bf499c..57a523f0273c 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -4267,19 +4267,19 @@ void __init lockdep_init(void)
        printk("... CHAINHASH_SIZE:          %lu\n", CHAINHASH_SIZE);
 
        printk(" memory used by lock dependency info: %zu kB\n",
-               (sizeof(struct lock_class) * MAX_LOCKDEP_KEYS +
-               sizeof(struct list_head) * CLASSHASH_SIZE +
-               sizeof(struct lock_list) * MAX_LOCKDEP_ENTRIES +
-               sizeof(struct lock_chain) * MAX_LOCKDEP_CHAINS +
-               sizeof(struct list_head) * CHAINHASH_SIZE
+              (sizeof(lock_classes) +
+               sizeof(classhash_table) +
+               sizeof(list_entries) +
+               sizeof(lock_chains) +
+               sizeof(chainhash_table)
 #ifdef CONFIG_PROVE_LOCKING
-               + sizeof(struct circular_queue)
+               + sizeof(lock_cq)
 #endif
                ) / 1024
                );
 
        printk(" per task-struct memory footprint: %zu bytes\n",
-               sizeof(struct held_lock) * MAX_LOCK_DEPTH);
+              sizeof(((struct task_struct *)NULL)->held_locks));
 }
 
 static void

Reply via email to