Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-10 Thread Yazen Ghannam
> > > > Argh, the macro should be adding the additional parentheses: > > > > #define HWID_MCATYPE(hwid, mcatype) (((hwid) << 16) | (mcatype)) > > > > That should fix the issue too. > Yep, sure does. > Patch please. Will do. Thanks, Yazen

Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-10 Thread Yazen Ghannam
> > > > Argh, the macro should be adding the additional parentheses: > > > > #define HWID_MCATYPE(hwid, mcatype) (((hwid) << 16) | (mcatype)) > > > > That should fix the issue too. > Yep, sure does. > Patch please. Will do. Thanks, Yazen

Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-10 Thread Thomas Gleixner
On Thu, 10 Nov 2016, Borislav Petkov wrote: > On Thu, Nov 10, 2016 at 12:50:04PM -0500, Yazen Ghannam wrote: > > Adding extra parentheses in HWID_MCATYPE() gives the same assembly as the > > original code and fixes the behavior. > > > > > + hwid_mcatype = HWID_MCATYPE((high & MCI_IPID_HWID)), > >

Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-10 Thread Thomas Gleixner
On Thu, 10 Nov 2016, Borislav Petkov wrote: > On Thu, Nov 10, 2016 at 12:50:04PM -0500, Yazen Ghannam wrote: > > Adding extra parentheses in HWID_MCATYPE() gives the same assembly as the > > original code and fixes the behavior. > > > > > + hwid_mcatype = HWID_MCATYPE((high & MCI_IPID_HWID)), > >

Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-10 Thread Yazen Ghannam
> static void get_smca_bank_info(unsigned int bank) > { > unsigned int i, hwid_mcatype, cpu = smp_processor_id(); > - struct smca_hwid_mcatype *type; > + struct smca_hwid *s_hwid; > u32 high, instance_id; > - u16 hwid, mcatype; > > /* Collect bank_info using CPU 0

Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-10 Thread Yazen Ghannam
> static void get_smca_bank_info(unsigned int bank) > { > unsigned int i, hwid_mcatype, cpu = smp_processor_id(); > - struct smca_hwid_mcatype *type; > + struct smca_hwid *s_hwid; > u32 high, instance_id; > - u16 hwid, mcatype; > > /* Collect bank_info using CPU 0

Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-10 Thread Borislav Petkov
On Thu, Nov 10, 2016 at 12:50:04PM -0500, Yazen Ghannam wrote: > Adding extra parentheses in HWID_MCATYPE() gives the same assembly as the > original code and fixes the behavior. > > > + hwid_mcatype = HWID_MCATYPE((high & MCI_IPID_HWID)), > > + ((high &

Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-10 Thread Borislav Petkov
On Thu, Nov 10, 2016 at 12:50:04PM -0500, Yazen Ghannam wrote: > Adding extra parentheses in HWID_MCATYPE() gives the same assembly as the > original code and fixes the behavior. > > > + hwid_mcatype = HWID_MCATYPE((high & MCI_IPID_HWID)), > > + ((high &

[tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-08 Thread tip-bot for Borislav Petkov
Commit-ID: 1ce9cd7f9f0b71af7c496b816734bc2dc699363a Gitweb: http://git.kernel.org/tip/1ce9cd7f9f0b71af7c496b816734bc2dc699363a Author: Borislav Petkov AuthorDate: Wed, 2 Nov 2016 12:48:01 +0100 Committer: Thomas Gleixner CommitDate: Tue, 8 Nov 2016

[tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct

2016-11-08 Thread tip-bot for Borislav Petkov
Commit-ID: 1ce9cd7f9f0b71af7c496b816734bc2dc699363a Gitweb: http://git.kernel.org/tip/1ce9cd7f9f0b71af7c496b816734bc2dc699363a Author: Borislav Petkov AuthorDate: Wed, 2 Nov 2016 12:48:01 +0100 Committer: Thomas Gleixner CommitDate: Tue, 8 Nov 2016 17:10:14 +0100 x86/RAS: Simplify