Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-11 Thread Yinghai Lu
On Thu, Dec 11, 2014 at 8:36 AM, Thomas Gleixner wrote: > On Wed, 10 Dec 2014, Yinghai Lu wrote: >> On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner wrote: >> >> - struct resource r = { >> >> - .flags = 0 >> >> - }; >> >> + struct resource r; >> >> >> >> +

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-11 Thread Bjorn Helgaas
On Wed, Dec 10, 2014 at 5:31 PM, Yinghai Lu wrote: > On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner wrote: >> On Tue, 9 Dec 2014, Yinghai Lu wrote: >> >> Can you please >> ... >> 2) Send patches inline. It's a pain to review and reply and I can't >>use my normal tooling. I agree, it is

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-11 Thread Thomas Gleixner
On Wed, 10 Dec 2014, Yinghai Lu wrote: > On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner wrote: > >> - struct resource r = { > >> - .flags = 0 > >> - }; > >> + struct resource r; > >> > >> + memset(, 0, sizeof(r)); > > > > What's the point of this change?

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-11 Thread Thomas Gleixner
On Wed, 10 Dec 2014, Yinghai Lu wrote: On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner t...@linutronix.de wrote: - struct resource r = { - .flags = 0 - }; + struct resource r; + memset(r, 0, sizeof(r)); What's the point of this change? Both

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-11 Thread Bjorn Helgaas
On Wed, Dec 10, 2014 at 5:31 PM, Yinghai Lu ying...@kernel.org wrote: On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner t...@linutronix.de wrote: On Tue, 9 Dec 2014, Yinghai Lu wrote: Can you please ... 2) Send patches inline. It's a pain to review and reply and I can't use my normal

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-11 Thread Yinghai Lu
On Thu, Dec 11, 2014 at 8:36 AM, Thomas Gleixner t...@linutronix.de wrote: On Wed, 10 Dec 2014, Yinghai Lu wrote: On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner t...@linutronix.de wrote: - struct resource r = { - .flags = 0 - }; + struct resource r;

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Richard Cochran
On Wed, Dec 10, 2014 at 05:57:12PM -0800, Yinghai Lu wrote: > Tried with mutt or thunderbird etc, all kept on downloading Mutt with gmail via imap works just fine for me. set folder="imaps://imap.gmail.com:993" set imap_user="lu...@gmail.com" set imap_pass="SuperSecret" You don't

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Mike Galbraith
On Wed, 2014-12-10 at 17:57 -0800, Yinghai Lu wrote: > On Wed, Dec 10, 2014 at 4:35 PM, Borislav Petkov wrote: > > On Wed, Dec 10, 2014 at 04:31:22PM -0800, Yinghai Lu wrote: > >> > 2) Send patches inline. It's a pain to review and reply and I can't > >> >use my normal tooling. > >> > >> I

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Yinghai Lu
On Wed, Dec 10, 2014 at 4:35 PM, Borislav Petkov wrote: > On Wed, Dec 10, 2014 at 04:31:22PM -0800, Yinghai Lu wrote: >> > 2) Send patches inline. It's a pain to review and reply and I can't >> >use my normal tooling. >> >> I can not, as gmail does not allow that. > > Lemme guess, this is

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Borislav Petkov
On Wed, Dec 10, 2014 at 04:31:22PM -0800, Yinghai Lu wrote: > > 2) Send patches inline. It's a pain to review and reply and I can't > >use my normal tooling. > > I can not, as gmail does not allow that. Lemme guess, this is some kind of a joke you're making, right? -- Regards/Gruss,

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Yinghai Lu
On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner wrote: > On Tue, 9 Dec 2014, Yinghai Lu wrote: > > Can you please > > 1) Cut out the completely irrelevant information from your replies? >It's just annoying to scroll through hundreds of quoted lines to >find the guts of the mail. ok. >

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Thomas Gleixner
On Tue, 9 Dec 2014, Yinghai Lu wrote: Can you please 1) Cut out the completely irrelevant information from your replies? It's just annoying to scroll through hundreds of quoted lines to find the guts of the mail. 2) Send patches inline. It's a pain to review and reply and I can't use

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Jiang Liu
Hi Yinghai, I have one comment about the attached patch related to following piece of code. I'm not sure whether we should check "addr.maximum - addr.minimum + 1 != addr.address_length" instead of "!addr.address_length". Otherwise: Reviewed-by: Jiang Liu Regards! Gerry Index:

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Mike Galbraith
On Wed, 2014-12-10 at 17:57 -0800, Yinghai Lu wrote: On Wed, Dec 10, 2014 at 4:35 PM, Borislav Petkov b...@alien8.de wrote: On Wed, Dec 10, 2014 at 04:31:22PM -0800, Yinghai Lu wrote: 2) Send patches inline. It's a pain to review and reply and I can't use my normal tooling. I can

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Richard Cochran
On Wed, Dec 10, 2014 at 05:57:12PM -0800, Yinghai Lu wrote: Tried with mutt or thunderbird etc, all kept on downloading Mutt with gmail via imap works just fine for me. set folder=imaps://imap.gmail.com:993 set imap_user=lu...@gmail.com set imap_pass=SuperSecret You don't have to

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Jiang Liu
Hi Yinghai, I have one comment about the attached patch related to following piece of code. I'm not sure whether we should check addr.maximum - addr.minimum + 1 != addr.address_length instead of !addr.address_length. Otherwise: Reviewed-by: Jiang Liu jiang@linux.intel.com Regards!

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Thomas Gleixner
On Tue, 9 Dec 2014, Yinghai Lu wrote: Can you please 1) Cut out the completely irrelevant information from your replies? It's just annoying to scroll through hundreds of quoted lines to find the guts of the mail. 2) Send patches inline. It's a pain to review and reply and I can't use

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Yinghai Lu
On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner t...@linutronix.de wrote: On Tue, 9 Dec 2014, Yinghai Lu wrote: Can you please 1) Cut out the completely irrelevant information from your replies? It's just annoying to scroll through hundreds of quoted lines to find the guts of the

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Borislav Petkov
On Wed, Dec 10, 2014 at 04:31:22PM -0800, Yinghai Lu wrote: 2) Send patches inline. It's a pain to review and reply and I can't use my normal tooling. I can not, as gmail does not allow that. Lemme guess, this is some kind of a joke you're making, right? -- Regards/Gruss, Boris.

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-10 Thread Yinghai Lu
On Wed, Dec 10, 2014 at 4:35 PM, Borislav Petkov b...@alien8.de wrote: On Wed, Dec 10, 2014 at 04:31:22PM -0800, Yinghai Lu wrote: 2) Send patches inline. It's a pain to review and reply and I can't use my normal tooling. I can not, as gmail does not allow that. Lemme guess, this is

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-09 Thread Yinghai Lu
On Mon, Nov 3, 2014 at 2:57 AM, tip-bot for Jiang Liu wrote: > Commit-ID: e22ce93870deae0e9a54e1539f0088538f187780 > Gitweb: http://git.kernel.org/tip/e22ce93870deae0e9a54e1539f0088538f187780 > Author: Jiang Liu > AuthorDate: Mon, 27 Oct 2014 13:21:34 +0800 > Committer: Thomas Gleixner

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-12-09 Thread Yinghai Lu
On Mon, Nov 3, 2014 at 2:57 AM, tip-bot for Jiang Liu tip...@zytor.com wrote: Commit-ID: e22ce93870deae0e9a54e1539f0088538f187780 Gitweb: http://git.kernel.org/tip/e22ce93870deae0e9a54e1539f0088538f187780 Author: Jiang Liu jiang@linux.intel.com AuthorDate: Mon, 27 Oct 2014

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-11-03 Thread Borislav Petkov
On Mon, Nov 03, 2014 at 02:57:31AM -0800, tip-bot for Jiang Liu wrote: > Commit-ID: e22ce93870deae0e9a54e1539f0088538f187780 > Gitweb: http://git.kernel.org/tip/e22ce93870deae0e9a54e1539f0088538f187780 > Author: Jiang Liu > AuthorDate: Mon, 27 Oct 2014 13:21:34 +0800 > Committer: Thomas

[tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-11-03 Thread tip-bot for Jiang Liu
Commit-ID: e22ce93870deae0e9a54e1539f0088538f187780 Gitweb: http://git.kernel.org/tip/e22ce93870deae0e9a54e1539f0088538f187780 Author: Jiang Liu AuthorDate: Mon, 27 Oct 2014 13:21:34 +0800 Committer: Thomas Gleixner CommitDate: Mon, 3 Nov 2014 11:56:07 +0100 x86, PCI, ACPI: Kill

[tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-11-03 Thread tip-bot for Jiang Liu
Commit-ID: e22ce93870deae0e9a54e1539f0088538f187780 Gitweb: http://git.kernel.org/tip/e22ce93870deae0e9a54e1539f0088538f187780 Author: Jiang Liu jiang@linux.intel.com AuthorDate: Mon, 27 Oct 2014 13:21:34 +0800 Committer: Thomas Gleixner t...@linutronix.de CommitDate: Mon, 3 Nov 2014

Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

2014-11-03 Thread Borislav Petkov
On Mon, Nov 03, 2014 at 02:57:31AM -0800, tip-bot for Jiang Liu wrote: Commit-ID: e22ce93870deae0e9a54e1539f0088538f187780 Gitweb: http://git.kernel.org/tip/e22ce93870deae0e9a54e1539f0088538f187780 Author: Jiang Liu jiang@linux.intel.com AuthorDate: Mon, 27 Oct 2014 13:21:34 +0800