Re: [tpmdd-devel] [PATCH 06/13] tpm: Remove redundant dev_set_drvdata

2013-10-04 Thread Ashley Lai
On Mon, 2013-09-23 at 12:14 -0600, Jason Gunthorpe wrote: > TPM drivers should not call dev_set_drvdata (or aliases), only the core > code is allowed to call dev_set_drvdata, and it does it during > tpm_register_hardware. > > These extra sets are harmless, but are an anti-pattern that many

Re: [tpmdd-devel] [PATCH 06/13] tpm: Remove redundant dev_set_drvdata

2013-10-04 Thread Ashley Lai
On Mon, 2013-09-23 at 12:14 -0600, Jason Gunthorpe wrote: TPM drivers should not call dev_set_drvdata (or aliases), only the core code is allowed to call dev_set_drvdata, and it does it during tpm_register_hardware. These extra sets are harmless, but are an anti-pattern that many drivers