Re: [v1 0/6] *** nps_enet fixups ***

2015-08-17 Thread David Miller
From: Noam Camus Date: Tue, 18 Aug 2015 05:04:20 + > I followed "Hardware Architecture" section from: > http://www.linuxfoundation.org/collaborate/workgroups/networking/napi > and came up with "reduce processing latency" idea. That document has lots of incorrect advice, that's for sure.

RE: [v1 0/6] *** nps_enet fixups ***

2015-08-17 Thread Noam Camus
From: David Miller [mailto:da...@davemloft.net] Sent: Monday, August 17, 2015 8:36 PM > You should not move TX completion out of NAPI handling, NAPI poll is exactly > where it belongs. > > If you handle it in hardware interrupt context you have to use > dev_kfree_skb_irq() which defers the

Re: [v1 0/6] *** nps_enet fixups ***

2015-08-17 Thread David Miller
From: Noam Camus Date: Mon, 17 Aug 2015 08:58:33 +0300 > This patch set is a bunch of fixes to make nps_enet work correctly with > all platforms, i.e. real device, emulation system, and simulation system. > The main trigger for this patch set was that in our emulation system > the TX end

[v1 0/6] *** nps_enet fixups ***

2015-08-17 Thread Noam Camus
From: Noam Camus This patch set is a bunch of fixes to make nps_enet work correctly with all platforms, i.e. real device, emulation system, and simulation system. The main trigger for this patch set was that in our emulation system the TX end interrupt is "edge-sensitive" and therefore we cannot

RE: [v1 0/6] *** nps_enet fixups ***

2015-08-17 Thread Noam Camus
From: David Miller [mailto:da...@davemloft.net] Sent: Monday, August 17, 2015 8:36 PM You should not move TX completion out of NAPI handling, NAPI poll is exactly where it belongs. If you handle it in hardware interrupt context you have to use dev_kfree_skb_irq() which defers the

Re: [v1 0/6] *** nps_enet fixups ***

2015-08-17 Thread David Miller
From: Noam Camus no...@ezchip.com Date: Tue, 18 Aug 2015 05:04:20 + I followed Hardware Architecture section from: http://www.linuxfoundation.org/collaborate/workgroups/networking/napi and came up with reduce processing latency idea. That document has lots of incorrect advice, that's for

Re: [v1 0/6] *** nps_enet fixups ***

2015-08-17 Thread David Miller
From: Noam Camus no...@ezchip.com Date: Mon, 17 Aug 2015 08:58:33 +0300 This patch set is a bunch of fixes to make nps_enet work correctly with all platforms, i.e. real device, emulation system, and simulation system. The main trigger for this patch set was that in our emulation system the TX

[v1 0/6] *** nps_enet fixups ***

2015-08-17 Thread Noam Camus
From: Noam Camus no...@ezchip.com This patch set is a bunch of fixes to make nps_enet work correctly with all platforms, i.e. real device, emulation system, and simulation system. The main trigger for this patch set was that in our emulation system the TX end interrupt is edge-sensitive and