Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

2013-08-09 Thread Scott Wood
On Thu, 2013-08-08 at 07:50 +0200, leroy christophe wrote: > Le 26/06/2013 01:04, Scott Wood a écrit : > > What happens if there's a race? If another CPU updates wdt_last_ping in > > parallel, then you could see wdt_last_ping greater than the value you > > read for jiffies. Since this is an

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

2013-08-09 Thread Scott Wood
On Thu, 2013-08-08 at 07:50 +0200, leroy christophe wrote: Le 26/06/2013 01:04, Scott Wood a écrit : What happens if there's a race? If another CPU updates wdt_last_ping in parallel, then you could see wdt_last_ping greater than the value you read for jiffies. Since this is an unsigned

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

2013-08-08 Thread Guenter Roeck
On 08/07/2013 10:50 PM, leroy christophe wrote: Le 26/06/2013 01:04, Scott Wood a écrit : On Thu, Feb 28, 2013 at 09:52:22AM +0100, LEROY Christophe wrote: This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s,

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

2013-08-08 Thread Guenter Roeck
On 08/07/2013 10:50 PM, leroy christophe wrote: Le 26/06/2013 01:04, Scott Wood a écrit : On Thu, Feb 28, 2013 at 09:52:22AM +0100, LEROY Christophe wrote: This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s,

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

2013-08-07 Thread leroy christophe
Le 26/06/2013 01:04, Scott Wood a écrit : On Thu, Feb 28, 2013 at 09:52:22AM +0100, LEROY Christophe wrote: This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s, which means it must be pinged twice a second.

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

2013-08-07 Thread leroy christophe
Le 26/06/2013 01:04, Scott Wood a écrit : On Thu, Feb 28, 2013 at 09:52:22AM +0100, LEROY Christophe wrote: This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s, which means it must be pinged twice a second.

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

2013-06-25 Thread Scott Wood
On Thu, Feb 28, 2013 at 09:52:22AM +0100, LEROY Christophe wrote: > This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, > at 133Mhz, the maximum timeout of the watchdog timer is 1s, which means it > must > be pinged twice a second. This is not in line with the Linux

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

2013-06-25 Thread Scott Wood
On Thu, Feb 28, 2013 at 09:52:22AM +0100, LEROY Christophe wrote: This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s, which means it must be pinged twice a second. This is not in line with the Linux watchdog

[PATCH v2] Enhanced support for MPC8xx/8xxx watchdog

2013-02-28 Thread Christophe Leroy
This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s, which means it must be pinged twice a second. This is not in line with the Linux watchdog concept which is based on a default watchdog timeout around 60s. This

[PATCH v2] Enhanced support for MPC8xx/8xxx watchdog

2013-02-28 Thread Christophe Leroy
This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s, which means it must be pinged twice a second. This is not in line with the Linux watchdog concept which is based on a default watchdog timeout around 60s. This