Re: [v2] mmc: sdhci-cadence: add HS400 enhanced strobe support

2017-03-03 Thread Masahiro Yamada
Hi Piotr, 2017-03-03 17:31 GMT+09:00 Piotr Sroka : > Add support for HS400ES mode to Cadence SDHCI driver. > > Signed-off-by: Piotr Sroka Thanks for your patch. It looks almost good to me. My comments are about some coding style issues only. Please see

Re: [v2] mmc: sdhci-cadence: add HS400 enhanced strobe support

2017-03-03 Thread Masahiro Yamada
Hi Piotr, 2017-03-03 17:31 GMT+09:00 Piotr Sroka : > Add support for HS400ES mode to Cadence SDHCI driver. > > Signed-off-by: Piotr Sroka Thanks for your patch. It looks almost good to me. My comments are about some coding style issues only. Please see below. > +static void

[v2] mmc: sdhci-cadence: add HS400 enhanced strobe support

2017-03-03 Thread Piotr Sroka
Add support for HS400ES mode to Cadence SDHCI driver. Signed-off-by: Piotr Sroka --- Changes in v2: - Modify enhanced strobe function to handle disabling enhanced strobe inside the function. Do no relay on that mmc_set_ios() is called immediately after

[v2] mmc: sdhci-cadence: add HS400 enhanced strobe support

2017-03-03 Thread Piotr Sroka
Add support for HS400ES mode to Cadence SDHCI driver. Signed-off-by: Piotr Sroka --- Changes in v2: - Modify enhanced strobe function to handle disabling enhanced strobe inside the function. Do no relay on that mmc_set_ios() is called immediately after