Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-20 Thread Chris Zhong
Hi Tomasz Thanks for your comments. I will modify all the the part of snip. Please find my reply in the following. On 06/18/2016 12:06 AM, Tomasz Figa wrote: Hi Chris, [snip] +struct phy_reg { + int value; + int addr; +}; + +struct phy_reg usb_pll_cfg[] = { + {0xf0,

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-20 Thread Chris Zhong
Hi Tomasz Thanks for your comments. I will modify all the the part of snip. Please find my reply in the following. On 06/18/2016 12:06 AM, Tomasz Figa wrote: Hi Chris, [snip] +struct phy_reg { + int value; + int addr; +}; + +struct phy_reg usb_pll_cfg[] = { + {0xf0,

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-19 Thread Chris Zhong
Hi Guenter On 06/18/2016 11:45 PM, Guenter Roeck wrote: Hi Chris, On Mon, Jun 13, 2016 at 2:39 AM, Chris Zhong wrote: Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-19 Thread Chris Zhong
Hi Guenter On 06/18/2016 11:45 PM, Guenter Roeck wrote: Hi Chris, On Mon, Jun 13, 2016 at 2:39 AM, Chris Zhong wrote: Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has two main components:

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-19 Thread Chris Zhong
Hi Kishon On 06/17/2016 08:54 PM, Kishon Vijay Abraham I wrote: On Monday 13 June 2016 03:09 PM, Chris Zhong wrote: Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has two main components: USB3

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-19 Thread Chris Zhong
Hi Kishon On 06/17/2016 08:54 PM, Kishon Vijay Abraham I wrote: On Monday 13 June 2016 03:09 PM, Chris Zhong wrote: Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has two main components: USB3

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-18 Thread Guenter Roeck
Hi Chris, On Mon, Jun 13, 2016 at 2:39 AM, Chris Zhong wrote: > Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB > Type-C PHY is designed to support the USB3 and DP applications. The > PHY basically has two main components: USB3 and DisplyPort. USB3 >

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-18 Thread Guenter Roeck
Hi Chris, On Mon, Jun 13, 2016 at 2:39 AM, Chris Zhong wrote: > Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB > Type-C PHY is designed to support the USB3 and DP applications. The > PHY basically has two main components: USB3 and DisplyPort. USB3 > operates in SuperSpeed mode

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-17 Thread Tomasz Figa
Hi Chris, On Mon, Jun 13, 2016 at 6:39 PM, Chris Zhong wrote: > Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB > Type-C PHY is designed to support the USB3 and DP applications. The > PHY basically has two main components: USB3 and DisplyPort. USB3 >

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-17 Thread Tomasz Figa
Hi Chris, On Mon, Jun 13, 2016 at 6:39 PM, Chris Zhong wrote: > Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB > Type-C PHY is designed to support the USB3 and DP applications. The > PHY basically has two main components: USB3 and DisplyPort. USB3 > operates in SuperSpeed mode

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-17 Thread Kishon Vijay Abraham I
On Monday 13 June 2016 03:09 PM, Chris Zhong wrote: > Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB > Type-C PHY is designed to support the USB3 and DP applications. The > PHY basically has two main components: USB3 and DisplyPort. USB3 > operates in SuperSpeed mode and the DP

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-17 Thread Kishon Vijay Abraham I
On Monday 13 June 2016 03:09 PM, Chris Zhong wrote: > Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB > Type-C PHY is designed to support the USB3 and DP applications. The > PHY basically has two main components: USB3 and DisplyPort. USB3 > operates in SuperSpeed mode and the DP

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-16 Thread Kever Yang
Hi Chris, On 06/13/2016 05:39 PM, Chris Zhong wrote: Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has two main components: USB3 and DisplyPort. USB3 operates in SuperSpeed mode and the DP can

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-16 Thread Kever Yang
Hi Chris, On 06/13/2016 05:39 PM, Chris Zhong wrote: Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has two main components: USB3 and DisplyPort. USB3 operates in SuperSpeed mode and the DP can

[v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-13 Thread Chris Zhong
Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has two main components: USB3 and DisplyPort. USB3 operates in SuperSpeed mode and the DP can operate at RBR, HBR and HBR2 data rates. Signed-off-by:

[v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-13 Thread Chris Zhong
Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has two main components: USB3 and DisplyPort. USB3 operates in SuperSpeed mode and the DP can operate at RBR, HBR and HBR2 data rates. Signed-off-by: