Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

On 12/19/2016 08:04 AM, David Miller wrote: From: Arvind Yadav Date: Thu, 15 Dec 2016 00:33:30 +0530 Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference.

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

On 12/19/2016 08:04 AM, David Miller wrote: From: Arvind Yadav Date: Thu, 15 Dec 2016 00:33:30 +0530 Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. Signed-off-by: Arvind Yadav

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

From: Arvind Yadav Date: Thu, 15 Dec 2016 00:33:30 +0530 > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > This error check will avoid NULL pointer dereference. > > Signed-off-by: Arvind Yadav

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

From: Arvind Yadav Date: Thu, 15 Dec 2016 00:33:30 +0530 > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > This error check will avoid NULL pointer dereference. > > Signed-off-by: Arvind Yadav Since ioremap() is in fact designed to

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

Hi David, I did not tested this feature. I have build it and flashed on hardware. You can check below commit id. Which has similar check for ioremap. 1- Commit id - de9e397e40f56b9f34af4bf6a5bd7a75ea02456c In 'drivers/net/phy/mdio-octeon.c' 2- Commit id -

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

Hi David, I did not tested this feature. I have build it and flashed on hardware. You can check below commit id. Which has similar check for ioremap. 1- Commit id - de9e397e40f56b9f34af4bf6a5bd7a75ea02456c In 'drivers/net/phy/mdio-octeon.c' 2- Commit id -

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

On 12/14/2016 11:03 AM, Arvind Yadav wrote: Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. I have asked you twice already this question, but could not determine from your response what

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

On 12/14/2016 11:03 AM, Arvind Yadav wrote: Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. I have asked you twice already this question, but could not determine from your response what

[v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 6 ++ 1 file changed, 6

[v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git