RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

Hi Masahiro, > Hi Piotr, > > 2017-03-20 17:47 GMT+09:00 Piotr Sroka : > > > >> > >> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device > >> > *pdev) > >> > struct sdhci_cdns_priv *priv; > >> > struct clk *clk; > >> > int ret; >

RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

Hi Masahiro, > Hi Piotr, > > 2017-03-20 17:47 GMT+09:00 Piotr Sroka : > > > >> > >> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device > >> > *pdev) > >> > struct sdhci_cdns_priv *priv; > >> > struct clk *clk; > >> > int ret; > >> > + struct

Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

Hi Piotr, 2017-03-20 17:47 GMT+09:00 Piotr Sroka : > >> >> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device >> > *pdev) >> > struct sdhci_cdns_priv *priv; >> > struct clk *clk; >> > int ret; >> > + struct device *dev =

Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

Hi Piotr, 2017-03-20 17:47 GMT+09:00 Piotr Sroka : > >> >> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device >> > *pdev) >> > struct sdhci_cdns_priv *priv; >> > struct clk *clk; >> > int ret; >> > + struct device *dev = >dev; >> > >> >

RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

> -Original Message- > From: Masahiro Yamada [mailto:yamada.masah...@socionext.com] > Sent: 17 March, 2017 6:24 PM > Subject: Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration > > > > > @@ -62,10 +66,33 @@ > > */ > > #d

RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

> -Original Message- > From: Masahiro Yamada [mailto:yamada.masah...@socionext.com] > Sent: 17 March, 2017 6:24 PM > Subject: Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration > > > > > @@ -62,10 +66,33 @@ > > */ > > #d

Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

Hi Piotr, Sorry, one more nit. 2017-03-17 21:41 GMT+09:00 Piotr Sroka : > + > +static const struct sdhci_cdns_phy_cfg sdhci_cdns_phy_cfgs[] = { > + { "cdns,phy-input-delay-sd-highspeed", SDHCI_CDNS_PHY_DLY_SD_HS, }, > + { "cdns,phy-input-delay-sd-legacy",

Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

Hi Piotr, Sorry, one more nit. 2017-03-17 21:41 GMT+09:00 Piotr Sroka : > + > +static const struct sdhci_cdns_phy_cfg sdhci_cdns_phy_cfgs[] = { > + { "cdns,phy-input-delay-sd-highspeed", SDHCI_CDNS_PHY_DLY_SD_HS, }, > + { "cdns,phy-input-delay-sd-legacy",

Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

Hi Piotr, 2017-03-17 21:41 GMT+09:00 Piotr Sroka : > DTS properties are used instead of fixed data > because PHY settings can be different for different chips/boards. > > Signed-off-by: Piotr Sroka > --- > Changes for v2: > - dts part was removed from this

Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

Hi Piotr, 2017-03-17 21:41 GMT+09:00 Piotr Sroka : > DTS properties are used instead of fixed data > because PHY settings can be different for different chips/boards. > > Signed-off-by: Piotr Sroka > --- > Changes for v2: > - dts part was removed from this patch > - most delays were moved from

[v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

DTS properties are used instead of fixed data because PHY settings can be different for different chips/boards. Signed-off-by: Piotr Sroka --- Changes for v2: - dts part was removed from this patch - most delays were moved from dts file to data associated with an SoC

[v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

DTS properties are used instead of fixed data because PHY settings can be different for different chips/boards. Signed-off-by: Piotr Sroka --- Changes for v2: - dts part was removed from this patch - most delays were moved from dts file to data associated with an SoC specific compatible -