Re: [v3 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-30 Thread John Hubbard
On 1/30/19 9:47 AM, Yang Shi wrote: [...] >>> @@ -1673,7 +1688,12 @@ static struct page *stable_tree_search(struct page >>> *page) >>>    * It would be more elegant to return stable_node >>>    * than kpage, but that involves more changes. >>>    */ >>> -   

Re: [v3 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-30 Thread Yang Shi
On 1/29/19 11:14 PM, John Hubbard wrote: On 1/29/19 12:29 PM, Yang Shi wrote: ksmd need search stable tree to look for the suitable KSM page, but the KSM page might be locked for a while due to i.e. KSM page rmap walk. Basically it is not a big deal since commit 2c653d0ee2ae ("ksm: introduce

Re: [v3 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-30 Thread Kirill Tkhai
On 29.01.2019 23:29, Yang Shi wrote: > ksmd need search stable tree to look for the suitable KSM page, but the > KSM page might be locked for a while due to i.e. KSM page rmap walk. > Basically it is not a big deal since commit 2c653d0ee2ae > ("ksm: introduce ksm_max_page_sharing per page

Re: [v3 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-29 Thread John Hubbard
On 1/29/19 12:29 PM, Yang Shi wrote: ksmd need search stable tree to look for the suitable KSM page, but the KSM page might be locked for a while due to i.e. KSM page rmap walk. Basically it is not a big deal since commit 2c653d0ee2ae ("ksm: introduce ksm_max_page_sharing per page deduplication

[v3 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-29 Thread Yang Shi
ksmd need search stable tree to look for the suitable KSM page, but the KSM page might be locked for a while due to i.e. KSM page rmap walk. Basically it is not a big deal since commit 2c653d0ee2ae ("ksm: introduce ksm_max_page_sharing per page deduplication limit"), since max_page_sharing limits