Re: [v4] hwmon: xgene: Support hwmon v2

2017-10-23 Thread Hoan Tran
Hi, On Sat, Oct 21, 2017 at 8:56 AM, Guenter Roeck wrote: > On Tue, Oct 17, 2017 at 11:28:34AM -0700, hotran wrote: >> This patch supports xgene-hwmon v2 which uses the non-cachable memory >> as the PCC shared memory. >> >> Signed-off-by: Hoan Tran >> --- >> v4 >> - Initialize version variable

Re: [v4] hwmon: xgene: Support hwmon v2

2017-10-21 Thread Guenter Roeck
On Tue, Oct 17, 2017 at 11:28:34AM -0700, hotran wrote: > This patch supports xgene-hwmon v2 which uses the non-cachable memory > as the PCC shared memory. > > Signed-off-by: Hoan Tran > --- > v4 > - Initialize version variable I would have preferred for you to drop the #ifdefs, but this shall

[PATCH v4] hwmon: xgene: Support hwmon v2

2017-10-17 Thread Hoan Tran
This patch supports xgene-hwmon v2 which uses the non-cachable memory as the PCC shared memory. Signed-off-by: Hoan Tran --- v4 - Initialize version variable v3 - Use local version variable - Use inline calls instead of the private map function v2 - Map PCC shared mem by ioremap() in case h