Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-22 Thread Vijay Balakrishna
On 9/22/2020 3:07 AM, Michal Hocko wrote: On Tue 22-09-20 10:07:26, Kirill A. Shutemov wrote: On Mon, Sep 21, 2020 at 12:07:23PM -0700, Vijay Balakrishna wrote: I would recommend reposting the patch which adds heuristic for THP (if THP is enabled) into the hotplug path, arguing with the

Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-22 Thread Michal Hocko
On Tue 22-09-20 10:07:26, Kirill A. Shutemov wrote: > On Mon, Sep 21, 2020 at 12:07:23PM -0700, Vijay Balakrishna wrote: > > > > > > I would recommend reposting the patch which adds heuristic for THP (if > > > THP is enabled) into the hotplug path, arguing with the consistency and > > >

Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-22 Thread Kirill A. Shutemov
On Mon, Sep 21, 2020 at 12:07:23PM -0700, Vijay Balakrishna wrote: > > > > I would recommend reposting the patch which adds heuristic for THP (if > > THP is enabled) into the hotplug path, arguing with the consistency and > > surprising results when adding memory decreases the value. > > I hope

Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-21 Thread Vijay Balakrishna
On 9/17/2020 10:56 PM, Michal Hocko wrote: On Thu 17-09-20 11:16:55, Vijay Balakrishna wrote: On 9/17/2020 10:52 AM, Michal Hocko wrote: On Thu 17-09-20 10:27:16, Vijay Balakrishna wrote: On 9/17/2020 2:28 AM, Michal Hocko wrote: On Wed 16-09-20 23:39:39, Vijay Balakrishna wrote:

Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-17 Thread Michal Hocko
On Thu 17-09-20 11:16:55, Vijay Balakrishna wrote: > > > On 9/17/2020 10:52 AM, Michal Hocko wrote: > > On Thu 17-09-20 10:27:16, Vijay Balakrishna wrote: > > > > > > > > > On 9/17/2020 2:28 AM, Michal Hocko wrote: > > > > On Wed 16-09-20 23:39:39, Vijay Balakrishna wrote: > > > > >

Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-17 Thread Vijay Balakrishna
On 9/17/2020 10:52 AM, Michal Hocko wrote: On Thu 17-09-20 10:27:16, Vijay Balakrishna wrote: On 9/17/2020 2:28 AM, Michal Hocko wrote: On Wed 16-09-20 23:39:39, Vijay Balakrishna wrote: set_recommended_min_free_kbytes need to honor min_free_kbytes set by the user. Post start-of-day THP

Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-17 Thread Michal Hocko
On Thu 17-09-20 10:27:16, Vijay Balakrishna wrote: > > > On 9/17/2020 2:28 AM, Michal Hocko wrote: > > On Wed 16-09-20 23:39:39, Vijay Balakrishna wrote: > > > set_recommended_min_free_kbytes need to honor min_free_kbytes set by the > > > user. Post start-of-day THP enable or memory hotplug

Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-17 Thread Vijay Balakrishna
On 9/17/2020 2:28 AM, Michal Hocko wrote: On Wed 16-09-20 23:39:39, Vijay Balakrishna wrote: set_recommended_min_free_kbytes need to honor min_free_kbytes set by the user. Post start-of-day THP enable or memory hotplug operations can lose user specified min_free_kbytes, in particular when

Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-17 Thread Michal Hocko
On Wed 16-09-20 23:39:39, Vijay Balakrishna wrote: > set_recommended_min_free_kbytes need to honor min_free_kbytes set by the > user. Post start-of-day THP enable or memory hotplug operations can > lose user specified min_free_kbytes, in particular when it is higher than > calculated recommended

Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-17 Thread Michal Hocko
On Thu 17-09-20 11:28:06, Michal Hocko wrote: > On Wed 16-09-20 23:39:39, Vijay Balakrishna wrote: > > set_recommended_min_free_kbytes need to honor min_free_kbytes set by the > > user. Post start-of-day THP enable or memory hotplug operations can > > lose user specified min_free_kbytes, in

[v4] mm: khugepaged: avoid overriding min_free_kbytes set by user

2020-09-17 Thread Vijay Balakrishna
set_recommended_min_free_kbytes need to honor min_free_kbytes set by the user. Post start-of-day THP enable or memory hotplug operations can lose user specified min_free_kbytes, in particular when it is higher than calculated recommended value. Signed-off-by: Vijay Balakrishna Cc: