RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Liberman Igal
ay, October 28, 2015 11:31 PM > > > To: Liberman Igal-B31950 > > > Cc: net...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > > > ker...@vger.kernel.org; Bucur Madalin-Cristian-B32716 > > > > > > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support &

Re: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Scott Wood
g; linuxppc-...@lists.ozlabs.org; linux- > > ker...@vger.kernel.org; Bucur Madalin-Cristian-B32716 > > > > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support > > > > On Tue, 2015-10-27 at 11:32 -0500, Liberman Igal-B31950 wrote: > > > > > > > + &

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Liberman Igal
; > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support > > On Tue, 2015-10-27 at 11:32 -0500, Liberman Igal-B31950 wrote: > > > > > + > > > > +struct device *fman_get_device(struct fman *fman) { return > > > > +fman->dev; } > > > > &

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Liberman Igal
; Bucur Madalin-Cristian-B32716 > <madalin.bu...@freescale.com> > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support > > On Thu, 2015-10-29 at 10:22 -0500, Liberman Igal-B31950 wrote: > > Regards, > > Igal Liberman > > > > > -Original Message- >

Re: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Scott Wood
gt; > Cc: net...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > > ker...@vger.kernel.org; Bucur Madalin-Cristian-B32716 > > <madalin.bu...@freescale.com> > > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support > > > > On Tue, 2015-10-27 at 1

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Liberman Igal
; Bucur Madalin-Cristian-B32716 > <madalin.bu...@freescale.com> > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support > > On Tue, 2015-10-27 at 11:32 -0500, Liberman Igal-B31950 wrote: > > > > > + > > > > +struct device *fman_get_device(struct fman *fman)

Re: [V5, 2/6] fsl/fman: Add FMan support

2015-10-28 Thread Scott Wood
On Tue, 2015-10-27 at 11:32 -0500, Liberman Igal-B31950 wrote: > > > + > > > +struct device *fman_get_device(struct fman *fman) { > > > + return fman->dev; > > > +} > > > > Is this really necessary? > > > > Fman port needs fman->dev, fman structure is opaque, so yes, it's needed. Why is

Re: [V5, 2/6] fsl/fman: Add FMan support

2015-10-28 Thread Scott Wood
On Tue, 2015-10-27 at 11:32 -0500, Liberman Igal-B31950 wrote: > > > + > > > +struct device *fman_get_device(struct fman *fman) { > > > + return fman->dev; > > > +} > > > > Is this really necessary? > > > > Fman port needs fman->dev, fman structure is opaque, so yes, it's needed. Why is

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-27 Thread Liberman Igal
6 > > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support > > On Mon, Sep 21, 2015 at 02:52:34PM +0300, Igal.Liberman wrote: > > diff --git a/drivers/net/ethernet/freescale/fman/fman.c > > b/drivers/net/ethernet/freescale/fman/fman.c > > new file mode 100644 > > inde

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-27 Thread Liberman Igal
ernel.org; Bucur Madalin-Cristian-B32716 > <madalin.bu...@freescale.com> > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support > > On Mon, Sep 21, 2015 at 02:52:34PM +0300, Igal.Liberman wrote: > > diff --git a/drivers/net/ethernet/freescale/fman/fman.c > > b/drivers/net/e

Re: [v5, 2/6] fsl/fman: Add FMan support

2015-10-01 Thread Scott Wood
On Thu, Sep 24, 2015 at 12:10:34PM +0300, igal.liber...@freescale.com wrote: > +int fman_get_rx_extra_headroom(void) > +{ > + static bool fm_check_rx_extra_headroom; > + > + if (!fm_check_rx_extra_headroom) { > + if (fsl_fm_rx_extra_headroom > FSL_FM_RX_EXTRA_HEADROOM_MAX || >

Re: [v5, 2/6] fsl/fman: Add FMan support

2015-10-01 Thread Scott Wood
On Thu, Sep 24, 2015 at 12:10:34PM +0300, igal.liber...@freescale.com wrote: > +int fman_get_rx_extra_headroom(void) > +{ > + static bool fm_check_rx_extra_headroom; > + > + if (!fm_check_rx_extra_headroom) { > + if (fsl_fm_rx_extra_headroom > FSL_FM_RX_EXTRA_HEADROOM_MAX || >

[v5, 2/6] fsl/fman: Add FMan support

2015-09-24 Thread igal.liberman
From: Igal Liberman Add the Data Path Acceleration Architecture Frame Manger Driver. The FMan embeds a series of hardware blocks that implement a group of Ethernet interfaces. This patch adds The FMan configuration, initialization and runtime control routines. The FMan driver supports several

[v5, 2/6] fsl/fman: Add FMan support

2015-09-24 Thread igal.liberman
From: Igal Liberman Add the Data Path Acceleration Architecture Frame Manger Driver. The FMan embeds a series of hardware blocks that implement a group of Ethernet interfaces. This patch adds The FMan configuration, initialization and runtime control routines. The