Re: [v5] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-10-02 Thread Mike Kravetz
On 10/2/20 4:25 AM, Michal Hocko wrote: > On Wed 30-09-20 15:03:11, Mike Kravetz wrote: >> On 9/30/20 1:47 PM, Vijay Balakrishna wrote: >>> On 9/30/2020 11:20 AM, Mike Kravetz wrote: On 9/29/20 9:49 AM, Vijay Balakrishna wrote: Sorry for jumping in so late. Should we use this as an

Re: [v5] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-10-02 Thread Michal Hocko
On Wed 30-09-20 15:03:11, Mike Kravetz wrote: > On 9/30/20 1:47 PM, Vijay Balakrishna wrote: > > On 9/30/2020 11:20 AM, Mike Kravetz wrote: > >> On 9/29/20 9:49 AM, Vijay Balakrishna wrote: > >> > >> Sorry for jumping in so late. Should we use this as an opportunity to > >> also fix up the

Re: [v5] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-30 Thread Mike Kravetz
On 9/30/20 1:47 PM, Vijay Balakrishna wrote: > On 9/30/2020 11:20 AM, Mike Kravetz wrote: >> On 9/29/20 9:49 AM, Vijay Balakrishna wrote: >> >> Sorry for jumping in so late. Should we use this as an opportunity to >> also fix up the messages logged when (re)calculating mfk? They are wrong >> and

Re: [v5] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-30 Thread Vijay Balakrishna
On 9/30/2020 11:20 AM, Mike Kravetz wrote: On 9/29/20 9:49 AM, Vijay Balakrishna wrote: When memory is hotplug added or removed the min_free_kbytes should be recalculated based on what is expected by khugepaged. Currently after hotplug, min_free_kbytes will be set to a lower default and

Re: [v5] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-30 Thread Mike Kravetz
On 9/29/20 9:49 AM, Vijay Balakrishna wrote: > When memory is hotplug added or removed the min_free_kbytes should be > recalculated based on what is expected by khugepaged. Currently > after hotplug, min_free_kbytes will be set to a lower default and higher > default set when THP enabled is lost.

[v5] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-29 Thread Vijay Balakrishna
When memory is hotplug added or removed the min_free_kbytes should be recalculated based on what is expected by khugepaged. Currently after hotplug, min_free_kbytes will be set to a lower default and higher default set when THP enabled is lost. This change restores min_free_kbytes as expected