Re: \\ 答复: [PATCH] of: del redundant type conversion

2019-04-10 Thread Frank Rowand
On 4/10/19 9:21 PM, Frank Rowand wrote: > On 4/10/19 9:13 PM, Frank Rowand wrote: >> On 4/10/19 6:51 PM, xiaojiangfeng wrote: >>> My pleasure. >>> >>> I am very new to sparse. >>> >>> I guess the warning is caused by the macro min. >> >> I think the warning is likely because the type of data is

Re: \\ 答复: [PATCH] of: del redundant type conversion

2019-04-10 Thread Frank Rowand
On 4/10/19 9:13 PM, Frank Rowand wrote: > On 4/10/19 6:51 PM, xiaojiangfeng wrote: >> My pleasure. >> >> I am very new to sparse. >> >> I guess the warning is caused by the macro min. > > I think the warning is likely because the type of data is 'void *'. > > Removing the (int) cast is a good

Re: \\ 答复: [PATCH] of: del redundant type conversion

2019-04-10 Thread Frank Rowand
On 4/10/19 6:51 PM, xiaojiangfeng wrote: > My pleasure. > > I am very new to sparse. > > I guess the warning is caused by the macro min. I think the warning is likely because the type of data is 'void *'. Removing the (int) cast is a good fix, but does not resolve the sparse warning. -Frank

Re: \\ 答复: [PATCH] of: del redundant type conversion

2019-04-10 Thread xiaojiangfeng
My pleasure. I am very new to sparse. I guess the warning is caused by the macro min. Then I submitted my changes. Thanks for code review. -邮件原件- 发件人: Frank Rowand [mailto:frowand.l...@gmail.com] 发送时间: 2019年4月11日 2:50 收件人: xiaojiangfeng ; robh...@kernel.org; r...@kernel.org 抄送: