Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-21 Thread Greg KH
On Fri, Jan 21, 2005 at 08:12:16AM +, David Woodhouse wrote: > On Thu, 2005-01-20 at 23:58 -0800, Greg KH wrote: > > Well, we should be byteswapping all of the fields that need to be > > swapped, right? I'm guessing that userspace is expecting the fields > > to be in cpu endian, correct? > >

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-21 Thread David Woodhouse
On Thu, 2005-01-20 at 23:58 -0800, Greg KH wrote: > Well, we should be byteswapping all of the fields that need to be > swapped, right? I'm guessing that userspace is expecting the fields > to be in cpu endian, correct? Userspace varies in that. Nobody expects _all_ the fields to be swapped; the

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-21 Thread Greg KH
On Fri, Jan 21, 2005 at 07:49:08AM +, David Woodhouse wrote: > On Thu, 2005-01-20 at 16:08 -0800, Greg KH wrote: > > Doh, sorry for missing this one. I've applied your patch to my trees, > > and will show up in the next -mm release. > > Actually I think John's problem was that the usb core

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-21 Thread Greg KH
On Fri, Jan 21, 2005 at 07:49:08AM +, David Woodhouse wrote: On Thu, 2005-01-20 at 16:08 -0800, Greg KH wrote: Doh, sorry for missing this one. I've applied your patch to my trees, and will show up in the next -mm release. Actually I think John's problem was that the usb core code has

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-21 Thread David Woodhouse
On Thu, 2005-01-20 at 23:58 -0800, Greg KH wrote: Well, we should be byteswapping all of the fields that need to be swapped, right? I'm guessing that userspace is expecting the fields to be in cpu endian, correct? Userspace varies in that. Nobody expects _all_ the fields to be swapped; the

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-21 Thread Greg KH
On Fri, Jan 21, 2005 at 08:12:16AM +, David Woodhouse wrote: On Thu, 2005-01-20 at 23:58 -0800, Greg KH wrote: Well, we should be byteswapping all of the fields that need to be swapped, right? I'm guessing that userspace is expecting the fields to be in cpu endian, correct?

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-20 Thread David Woodhouse
On Thu, 2005-01-20 at 16:08 -0800, Greg KH wrote: > Doh, sorry for missing this one. I've applied your patch to my trees, > and will show up in the next -mm release. Actually I think John's problem was that the usb core code has now _stopped_ doing this byteswapping, and he has a lsusb which is

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-20 Thread Greg KH
On Thu, Jan 20, 2005 at 08:40:07AM +, David Woodhouse wrote: > On Wed, 2005-01-19 at 15:39 -0800, John Mock wrote: > > New to 2.6.11-rc1 is that 'lsusb' exhibits 'endian' problems on the > > PowerMac. > > Is that really new to 2.6.11-rc1? The kernel byte-swaps the bcdUSB, > idVendor,

re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-20 Thread John Mock
> Is that really new to 2.6.11-rc1? The kernel byte-swaps the bcdUSB, > idVendor, idProduct, and bcdDevice fields in the device descriptor. It > should probably swap them back before copying it up to userspace. Yes, it happens with 2.6.11-rc1 on my PowerPC, but not with 2.6.10 (or before), or on

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-20 Thread David Woodhouse
On Wed, 2005-01-19 at 15:39 -0800, John Mock wrote: > New to 2.6.11-rc1 is that 'lsusb' exhibits 'endian' problems on the > PowerMac. Is that really new to 2.6.11-rc1? The kernel byte-swaps the bcdUSB, idVendor, idProduct, and bcdDevice fields in the device descriptor. It should probably swap

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-20 Thread David Woodhouse
On Wed, 2005-01-19 at 15:39 -0800, John Mock wrote: New to 2.6.11-rc1 is that 'lsusb' exhibits 'endian' problems on the PowerMac. Is that really new to 2.6.11-rc1? The kernel byte-swaps the bcdUSB, idVendor, idProduct, and bcdDevice fields in the device descriptor. It should probably swap them

re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-20 Thread John Mock
Is that really new to 2.6.11-rc1? The kernel byte-swaps the bcdUSB, idVendor, idProduct, and bcdDevice fields in the device descriptor. It should probably swap them back before copying it up to userspace. Yes, it happens with 2.6.11-rc1 on my PowerPC, but not with 2.6.10 (or before), or on my

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-20 Thread Greg KH
On Thu, Jan 20, 2005 at 08:40:07AM +, David Woodhouse wrote: On Wed, 2005-01-19 at 15:39 -0800, John Mock wrote: New to 2.6.11-rc1 is that 'lsusb' exhibits 'endian' problems on the PowerMac. Is that really new to 2.6.11-rc1? The kernel byte-swaps the bcdUSB, idVendor, idProduct, and

Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-20 Thread David Woodhouse
On Thu, 2005-01-20 at 16:08 -0800, Greg KH wrote: Doh, sorry for missing this one. I've applied your patch to my trees, and will show up in the next -mm release. Actually I think John's problem was that the usb core code has now _stopped_ doing this byteswapping, and he has a lsusb which is

2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-19 Thread John Mock
First, thanks to those involved in the 2.6.10 effort, as that's the first kernel in quite some time that seems stable on my PowerMac 8500/G3. It is not quite as good on the Sony VAIO laptop, due to software suspend problems (mostly USB related). 2.6.11-rc1 seemed to help with the VAIO laptop's

2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]

2005-01-19 Thread John Mock
First, thanks to those involved in the 2.6.10 effort, as that's the first kernel in quite some time that seems stable on my PowerMac 8500/G3. It is not quite as good on the Sony VAIO laptop, due to software suspend problems (mostly USB related). 2.6.11-rc1 seemed to help with the VAIO laptop's