Fix formating errors and a memory leak that crept in the
previous round of revisions to v9fs. These will be reincorperated
into the patchset and resent to akpm.
Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]>
---
commit 22d785a22895513c6ab67dfa53c25b8b833fe235
tree
Doh! Good catch, I'll fix and resubmit - same goes for the formating issues.
On 7/14/05, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> > @@ -383,9 +379,10 @@ v9fs_file_write(struct file *filp, const
> > return -ENOMEM;
> >
> > ret = copy_from_user(buffer, data, count);
> > -
On 7/14/05, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> > +static inline void buf_check_size(struct cbuf *buf, int len)
> > +{
> > + if (buf->p+len > buf->ep) {
> > + if (buf->p < buf->ep) {
> > + eprintk(KERN_ERR, "buffer overflow\n");
> > +
> @@ -383,9 +379,10 @@ v9fs_file_write(struct file *filp, const
> return -ENOMEM;
>
> ret = copy_from_user(buffer, data, count);
> - if (ret)
> + if (ret) {
> dprintk(DEBUG_ERROR, "Problem copying from user\n");
> - else
> + return
> +static inline void buf_check_size(struct cbuf *buf, int len)
> +{
> + if (buf->p+len > buf->ep) {
> + if (buf->p < buf->ep) {
> + eprintk(KERN_ERR, "buffer overflow\n");
> + buf->p = buf->ep + 1;
> + }
> + }
> +}
On Sun, Jul 17, 2005 at 08:53:59AM -0500, [EMAIL PROTECTED] wrote:
> This is part [7/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
>
> This part of the patch contains debug and other misc routine changes related
> to hch's comments.
Here a few if( instead if ( format
This is part [6/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains transport routine changes related to
hch's comments.
Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]>
--
fs/9p/trans_sock.c |2 +-
fs/9p/mux.c
This is part [7/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains debug and other misc routine changes related
to hch's comments.
Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]>
--
fs/9p/error.c|3 +--
fs/9p/error.h
This is part [5/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains the 9P protocol function changes related
to hch's comments.
Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]>
--
fs/9p/9p.c |2 +-
fs/9p/conv.c
This is part [3/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains the VFS inode interfaces changes related
to hch's comments.
Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]>
--
fs/9p/vfs_inode.c
This is part [4/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains VFS superblock and mapping code changes
related to hch's comments.
Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]>
--
v9fs.c
This is part [1/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2
This part of the patch contains Documentation, Makefiles,
and configuration file changes related to hch's comments.
Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]>
--
fs/9p/Makefile |1 -
1
This is part [2/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2
This part of the patch contains the VFS file, dentry, & directory interface
changes related to hch's comments.
Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]>
--
fs/9p/vfs_file.
This is part [0/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
The changes in this patch-set are primarily motivated by comments from
Chistoph Hellwig (hch):
"there's a few issues with the code still I'd like to see fixed:
- there's three sparse warnings still. Two of
Chuck Ebbert wrote:
>Looks like Quilt is adding the space during push/pop operations. Only the
> lines it has touched in the series file have the trailing space.
Quilt versions prior to 0.39 would add a trailing space to the series
file entry when doing a quilt refresh with the default -p1
/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm2/patch-series
> > ?
>
>
> Looks like Quilt is adding the space during push/pop operations. Only the
> lines it has touched in the series file have the trailing space.
Nope. For me quilt leaves a trailing space if I
Chuck Ebbert wrote:
Looks like Quilt is adding the space during push/pop operations. Only the
lines it has touched in the series file have the trailing space.
Quilt versions prior to 0.39 would add a trailing space to the series
file entry when doing a quilt refresh with the default -p1
This is part [0/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
The changes in this patch-set are primarily motivated by comments from
Chistoph Hellwig (hch):
there's a few issues with the code still I'd like to see fixed:
- there's three sparse warnings still. Two of them are easily
This is part [2/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2
This part of the patch contains the VFS file, dentry, directory interface
changes related to hch's comments.
Signed-off-by: Eric Van Hensbergen [EMAIL PROTECTED]
--
fs/9p/vfs_file.c | 35
This is part [1/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2
This part of the patch contains Documentation, Makefiles,
and configuration file changes related to hch's comments.
Signed-off-by: Eric Van Hensbergen [EMAIL PROTECTED]
--
fs/9p/Makefile |1 -
1 files
This is part [4/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains VFS superblock and mapping code changes
related to hch's comments.
Signed-off-by: Eric Van Hensbergen [EMAIL PROTECTED]
--
v9fs.c | 103
This is part [3/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains the VFS inode interfaces changes related
to hch's comments.
Signed-off-by: Eric Van Hensbergen [EMAIL PROTECTED]
--
fs/9p/vfs_inode.c | 69
This is part [5/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains the 9P protocol function changes related
to hch's comments.
Signed-off-by: Eric Van Hensbergen [EMAIL PROTECTED]
--
fs/9p/9p.c |2 +-
fs/9p/conv.c| 54
This is part [7/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains debug and other misc routine changes related
to hch's comments.
Signed-off-by: Eric Van Hensbergen [EMAIL PROTECTED]
--
fs/9p/error.c|3 +--
fs/9p/error.h|3
On Sun, Jul 17, 2005 at 08:53:59AM -0500, [EMAIL PROTECTED] wrote:
This is part [7/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2.
This part of the patch contains debug and other misc routine changes related
to hch's comments.
Here a few if( instead if ( formatting sneaked
+static inline void buf_check_size(struct cbuf *buf, int len)
+{
+ if (buf-p+len buf-ep) {
+ if (buf-p buf-ep) {
+ eprintk(KERN_ERR, buffer overflow\n);
+ buf-p = buf-ep + 1;
+ }
+ }
+}
handling a buffer
@@ -383,9 +379,10 @@ v9fs_file_write(struct file *filp, const
return -ENOMEM;
ret = copy_from_user(buffer, data, count);
- if (ret)
+ if (ret) {
dprintk(DEBUG_ERROR, Problem copying from user\n);
- else
+ return -EFAULT;
+ }
On 7/14/05, Christoph Hellwig [EMAIL PROTECTED] wrote:
+static inline void buf_check_size(struct cbuf *buf, int len)
+{
+ if (buf-p+len buf-ep) {
+ if (buf-p buf-ep) {
+ eprintk(KERN_ERR, buffer overflow\n);
+ buf-p = buf-ep +
Doh! Good catch, I'll fix and resubmit - same goes for the formating issues.
On 7/14/05, Christoph Hellwig [EMAIL PROTECTED] wrote:
@@ -383,9 +379,10 @@ v9fs_file_write(struct file *filp, const
return -ENOMEM;
ret = copy_from_user(buffer, data, count);
- if
Fix formating errors and a memory leak that crept in the
previous round of revisions to v9fs. These will be reincorperated
into the patchset and resent to akpm.
Signed-off-by: Eric Van Hensbergen [EMAIL PROTECTED]
---
commit 22d785a22895513c6ab67dfa53c25b8b833fe235
tree
Hi, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm2/
Also available as a GIT archive (once the mirror has mirrored):
http://www.kernel.org/pub/scm/linux/kernel/git/smurf/v2.6.13-rc2-mm2.git/
Suggestions for improvements welc
kmem_cache_free(_cache, cachep);
cachep = NULL;
goto opps;
}
#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.13-rc2-mm2
# Wed Jul 13 23:08:18 2005
#
CONFIG_X86=y
CONFIG_MMU=y
CONFIG_UID16=y
CONFIG_GENERIC
On Wed, 13 Jul 2005 at 00:23:42 -0700, Andrew Morton wrote:
>>...and BTW why does every line in the series file have a trailing space?
>
> Not in my copy of
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm2/patch-series
> ?
On Wed, 2005-07-13 at 12:34 -0700, Andrew Morton wrote:
> I assume MTD_CFI should depend on ARM?
I believe it already does, in the git tree. Thomas asked Linus to pull
from that only about an hour ago.
--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
Miles Lane <[EMAIL PROTECTED]> wrote:
>
> In file included from drivers/mtd/chips/cfi_probe.c:18:
> include/linux/mtd/xip.h:68:25: error: asm/mtd-xip.h: No such file or directory
I assume MTD_CFI should depend on ARM?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
On Wed, 2005-07-13 at 20:46 +0100, David Woodhouse wrote:
> On Wed, 2005-07-13 at 12:34 -0700, Andrew Morton wrote:
> > I assume MTD_CFI should depend on ARM?
>
> I believe it already does, in the git tree. Thomas asked Linus to pull
> from that only about an hour ago.
Linus has pulled already
In file included from drivers/mtd/chips/cfi_probe.c:18:
include/linux/mtd/xip.h:68:25: error: asm/mtd-xip.h: No such file or directory
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
> What's your device-mapper/lvm configuration and what 'lvm' command
> did you run to trigger this?
Nothing special... it happens while booting Fedora Core 4.
> 'dmsetup info -c'
> 'dmsetup table'
> 'lvs --segments -o+devices -a'
# cat /etc/fstab
/dev/VolGroup00/Root/
iling space?
Not in my copy of
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm2/patch-series
?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger
===========
[EMAIL PROTECTED] 2.6.13-rc2-mm2]$ quilt push x86-64-ptrace-ia32-bp-fix.patch
Applying x86-64-ptrace-ia32-bp-fix.patch
patch: no: extra operand
patch: Try `/usr/bin/patch --help' for
thought this was an isolated instance and fixed it up, then found:
x86-64-ptrace-ia32-bp-fix.patch # ak no likee
This breaks quilt when you try to push patches by name:
===
[EMAIL PROTECTED] 2.6.13-rc2-mm2]$ quilt push
://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm2/patch-series
?
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
What's your device-mapper/lvm configuration and what 'lvm' command
did you run to trigger this?
Nothing special... it happens while booting Fedora Core 4.
'dmsetup info -c'
'dmsetup table'
'lvs --segments -o+devices -a'
# cat /etc/fstab
/dev/VolGroup00/Root/
In file included from drivers/mtd/chips/cfi_probe.c:18:
include/linux/mtd/xip.h:68:25: error: asm/mtd-xip.h: No such file or directory
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Wed, 2005-07-13 at 20:46 +0100, David Woodhouse wrote:
On Wed, 2005-07-13 at 12:34 -0700, Andrew Morton wrote:
I assume MTD_CFI should depend on ARM?
I believe it already does, in the git tree. Thomas asked Linus to pull
from that only about an hour ago.
Linus has pulled already
tglx
Miles Lane [EMAIL PROTECTED] wrote:
In file included from drivers/mtd/chips/cfi_probe.c:18:
include/linux/mtd/xip.h:68:25: error: asm/mtd-xip.h: No such file or directory
I assume MTD_CFI should depend on ARM?
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Wed, 2005-07-13 at 12:34 -0700, Andrew Morton wrote:
I assume MTD_CFI should depend on ARM?
I believe it already does, in the git tree. Thomas asked Linus to pull
from that only about an hour ago.
--
dwmw2
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Wed, 13 Jul 2005 at 00:23:42 -0700, Andrew Morton wrote:
...and BTW why does every line in the series file have a trailing space?
Not in my copy of
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm2/patch-series
?
Looks like Quilt is adding
: don't edit
# Linux kernel version: 2.6.13-rc2-mm2
# Wed Jul 13 23:08:18 2005
#
CONFIG_X86=y
CONFIG_MMU=y
CONFIG_UID16=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_IOMAP=y
#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y
CONFIG_CLEAN_COMPILE=y
CONFIG_LOCK_KERNEL=y
CONFIG_INIT_ENV_ARG_LIMIT=32
Hi, Andrew Morton wrote:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm2/
Also available as a GIT archive (once the mirror has mirrored):
http://www.kernel.org/pub/scm/linux/kernel/git/smurf/v2.6.13-rc2-mm2.git/
Suggestions for improvements welcome
Chuck Ebbert <[EMAIL PROTECTED]> wrote:
>
>
> I downloaded 2.6.13-rc2-mm2-broken-out.tar.bz2 and verified the signature.
>
> Then I untarred it and moved it to the patches/ dir.
>
> Output of 'quilt push -a' ends with:
>
> Applying git-netdev-janitor-f
I downloaded 2.6.13-rc2-mm2-broken-out.tar.bz2 and verified the signature.
Then I untarred it and moved it to the patches/ dir.
Output of 'quilt push -a' ends with:
Applying git-netdev-janitor-fixup.patch
patch: Only garbage was found in the patch input.
Patch git-netdev
Alasdair G Kergon <[EMAIL PROTECTED]> wrote:
>
> I'm downloading -mm2 as I write this to check, but I can't
> spot the part of the patch that updates dm-table.c to read:
>
> void dm_table_presuspend_targets(struct dm_table *t)
> {
> if (!t)
> return;
>
>
Hi there,
Lately in 2.6.13-rc* I've noticed a warning pop up:
[EMAIL PROTECTED]:/usr/src/linux-2.6.13-rc2-mm2a$ make menuconfig
...
scripts/kconfig/mconf arch/i386/Kconfig
net/ipv4/Kconfig:92:warning: defaults for choice values not supported <<== ??
#
# using defaults found in .config
#
Linux
On Tue, Jul 12, 2005 at 08:52:39PM +0200, Laurent Riffard wrote:
> I just got this oops.
> EIP is at suspend_targets+0x8/0x42 [dm_mod]
I fear the empty patch the script gave me yesterday wasn't meant
to be empty... [Yes, I'm going to switch to quilt just as soon as
I can make time to convert
ile:
> Modules linked in: dm_mod joydev usbhid uhci_hcd usbcore video hotkey configfs
> CPU:0
> EIP:0060:[]Not tainted VLI
> EFLAGS: 00010246 (2.6.13-rc2-mm2)
> EIP is at suspend_targets+0x8/0x42 [dm_mod]
> eax: ebx: cf764340 ecx: edx: 000
On Tue, Jul 12, 2005 at 08:16:14PM +0200, Felipe Alfaro Solana wrote:
> I'm seeing this oops with 2.6.13-rc2-mm2:
> EIP is at suspend_targets+0x6/0x47 [dm_mod]
> Doesn't happen with 2.6.13-rc2-mm1, however.
What's your device-mapper/lvm configuration and what 'lvm' command
di
> Changes since 2.6.13-rc2-mm1:
I'm seeing this oops with 2.6.13-rc2-mm2:
*pde
Oops: [#1]
last sysfs file:
Modules linked in: dm_snapshot dm_mirror ext3 mbcache jbd dm_mod
CPU:0
EIP:0060:[]Not tainted VLI
EFLAGS: 00010246 (2.6.13-rc2mm2)
EIP is at suspend_targets+
On Tue, Jul 12, 2005 at 01:01:48PM +0100, David Woodhouse wrote:
> On Tue, 2005-07-12 at 13:05 +0200, Adrian Bunk wrote:
> > Although it's not mentioned in the changelog, it seems the MTD GIT
> > tree was dropped.
> >
> > I noticed this because a compile error that was fixed in -mm1 is back.
>
>
On Tue, 2005-07-12 at 13:05 +0200, Adrian Bunk wrote:
> Although it's not mentioned in the changelog, it seems the MTD GIT
> tree was dropped.
>
> I noticed this because a compile error that was fixed in -mm1 is back.
What error? The MTD GIT tree is presumably absent from -mm because it
was
Although it's not mentioned in the changelog, it seems the MTD GIT tree
was dropped.
I noticed this because a compile error that was fixed in -mm1 is back.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm2/
(And at http://www.zip.com.au/~akpm/linux/patches/stuff/2.6.13-rc2-mm2.gz -
kenrel.org mirroring is being slow again)
- MM updates
- More video4linux updates
- Infiniband feature work
Changes since
Alasdair G Kergon [EMAIL PROTECTED] wrote:
I'm downloading -mm2 as I write this to check, but I can't
spot the part of the patch that updates dm-table.c to read:
void dm_table_presuspend_targets(struct dm_table *t)
{
if (!t)
return;
return
I downloaded 2.6.13-rc2-mm2-broken-out.tar.bz2 and verified the signature.
Then I untarred it and moved it to the patches/ dir.
Output of 'quilt push -a' ends with:
Applying git-netdev-janitor-fixup.patch
patch: Only garbage was found in the patch input.
Patch git-netdev
Chuck Ebbert [EMAIL PROTECTED] wrote:
I downloaded 2.6.13-rc2-mm2-broken-out.tar.bz2 and verified the signature.
Then I untarred it and moved it to the patches/ dir.
Output of 'quilt push -a' ends with:
Applying git-netdev-janitor-fixup.patch
patch: Only garbage
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc2/2.6.13-rc2-mm2/
(And at http://www.zip.com.au/~akpm/linux/patches/stuff/2.6.13-rc2-mm2.gz -
kenrel.org mirroring is being slow again)
- MM updates
- More video4linux updates
- Infiniband feature work
Changes since
Although it's not mentioned in the changelog, it seems the MTD GIT tree
was dropped.
I noticed this because a compile error that was fixed in -mm1 is back.
cu
Adrian
--
Is there not promise of rain? Ling Tan asked suddenly out
of the darkness. There had been need of rain for
On Tue, 2005-07-12 at 13:05 +0200, Adrian Bunk wrote:
Although it's not mentioned in the changelog, it seems the MTD GIT
tree was dropped.
I noticed this because a compile error that was fixed in -mm1 is back.
What error? The MTD GIT tree is presumably absent from -mm because it
was pulled
On Tue, Jul 12, 2005 at 01:01:48PM +0100, David Woodhouse wrote:
On Tue, 2005-07-12 at 13:05 +0200, Adrian Bunk wrote:
Although it's not mentioned in the changelog, it seems the MTD GIT
tree was dropped.
I noticed this because a compile error that was fixed in -mm1 is back.
What
Changes since 2.6.13-rc2-mm1:
I'm seeing this oops with 2.6.13-rc2-mm2:
*pde
Oops: [#1]
last sysfs file:
Modules linked in: dm_snapshot dm_mirror ext3 mbcache jbd dm_mod
CPU:0
EIP:0060:[e081e681]Not tainted VLI
EFLAGS: 00010246 (2.6.13-rc2mm2)
EIP
On Tue, Jul 12, 2005 at 08:16:14PM +0200, Felipe Alfaro Solana wrote:
I'm seeing this oops with 2.6.13-rc2-mm2:
EIP is at suspend_targets+0x6/0x47 [dm_mod]
Doesn't happen with 2.6.13-rc2-mm1, however.
What's your device-mapper/lvm configuration and what 'lvm' command
did you run to trigger
joydev usbhid uhci_hcd usbcore video hotkey configfs
CPU:0
EIP:0060:[d08612ec]Not tainted VLI
EFLAGS: 00010246 (2.6.13-rc2-mm2)
EIP is at suspend_targets+0x8/0x42 [dm_mod]
eax: ebx: cf764340 ecx: edx:
esi: edi: ebp: cf06bec4
On Tue, Jul 12, 2005 at 08:52:39PM +0200, Laurent Riffard wrote:
I just got this oops.
EIP is at suspend_targets+0x8/0x42 [dm_mod]
I fear the empty patch the script gave me yesterday wasn't meant
to be empty... [Yes, I'm going to switch to quilt just as soon as
I can make time to convert
Hi there,
Lately in 2.6.13-rc* I've noticed a warning pop up:
[EMAIL PROTECTED]:/usr/src/linux-2.6.13-rc2-mm2a$ make menuconfig
...
scripts/kconfig/mconf arch/i386/Kconfig
net/ipv4/Kconfig:92:warning: defaults for choice values not supported == ??
#
# using defaults found in .config
#
Linux
74 matches
Mail list logo
