Re: 2.6.20 libata cdrom

2007-05-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 01 May 2007, William Thompson wrote: > On Tue, May 01, 2007 at 09:04:46AM -0400, Mark Lord wrote: > > William Thompson wrote: > > > > > >+scsi2 : ata_piix > > >+ata_port_schedule_eh: port EH scheduled > > >+ata_scsi_error: ENTER > > >+ata_port_flush_task: ENTER > >

Re: 2.6.20 libata cdrom

2007-05-01 Thread William Thompson
On Tue, May 01, 2007 at 03:40:36PM +0200, Tejun Heo wrote: > >> Tejun, don't we have a fallback for when IDENTIFY fails? > >> If the drive rejects it (err=0x04), then this can mean only one thing: > >> unsupported command, so we next must try PACKET_IDENTIFY. > > Up until now, we've been

Re: 2.6.20 libata cdrom

2007-05-01 Thread Alan Cox
On Tue, 01 May 2007 10:19:33 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Mark Lord wrote: > >> Gee... Two crazy screwed up devices today. What's going on? > > > > libata is finally seeing use by non-kernel developers. > > Amusing but factually incorrect. libata has been shipping in major

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Gee... Two crazy screwed up devices today. What's going on? libata is finally seeing use by non-kernel developers. Amusing but factually incorrect. libata has been shipping in major distros for years, with bazoodles of active users. But of course.

Re: 2.6.20 libata cdrom

2007-05-01 Thread Jeff Garzik
Mark Lord wrote: Gee... Two crazy screwed up devices today. What's going on? libata is finally seeing use by non-kernel developers. Amusing but factually incorrect. libata has been shipping in major distros for years, with bazoodles of active users. Jeff - To unsubscribe from

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Gee... Two crazy screwed up devices today. What's going on? libata is finally seeing use by non-kernel developers. Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: 2.6.20 libata cdrom

2007-05-01 Thread Tejun Heo
Hello, William Thompson wrote: > On Tue, May 01, 2007 at 09:04:46AM -0400, Mark Lord wrote: >>> +ata_dev_classify: found ATA device by sig >>> +ata_dev_classify: unknown device >>> +ata_std_softreset: EXIT, classes[0]=1 [1]=5 >>> +ata_std_postreset: ENTER >>> +ata_std_postreset: EXIT >>>

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: And this is the second one today where it would be very useful to see a tf dump. It's time to add one to that code patch, methinks. Yeah, we have all these fancy ata_msg_() thingies which can be used to provide a lot of debugging info without affecting hot

Re: 2.6.20 libata cdrom

2007-05-01 Thread Tejun Heo
Mark Lord wrote: > And this is the second one today where it would be very useful > to see a tf dump. It's time to add one to that code patch, methinks. Yeah, we have all these fancy ata_msg_() thingies which can be used to provide a lot of debugging info without affecting hot path. We're just

Re: 2.6.20 libata cdrom

2007-05-01 Thread Alan Cox
> But libata might actually be able to use mdma2 with it, > as I believe (unsubstantiated) that Alan may have done > a better implementation of setting the timings than what > we had with our old IDE drivers. The new code knows how to set MWDMA2 timings properly, and it knows about picking

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
William Thompson wrote: The one thing I do know, the machine with the non-working libata cdrom also does not work with the ide driver *ONLY IF* DMA is turned on. That's probably because it's a mdma2 device, and not many chipsets seem to do mdma2 correctly. I had a drive like that around

Re: 2.6.20 libata cdrom

2007-05-01 Thread William Thompson
On Tue, May 01, 2007 at 09:04:46AM -0400, Mark Lord wrote: > William Thompson wrote: > > > >+scsi2 : ata_piix > >+ata_port_schedule_eh: port EH scheduled > >+ata_scsi_error: ENTER > >+ata_port_flush_task: ENTER > >+ata_port_flush_task: flush #1 > >+ata2: ata_port_flush_task: flush #2 > >+ata2:

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
William Thompson wrote: +scsi2 : ata_piix +ata_port_schedule_eh: port EH scheduled +ata_scsi_error: ENTER +ata_port_flush_task: ENTER +ata_port_flush_task: flush #1 +ata2: ata_port_flush_task: flush #2 +ata2: ata_port_flush_task: EXIT +ata_eh_autopsy: ENTER +ata_eh_recover: ENTER

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Mark Lord wrote: Tejun Heo wrote: .. scsi1 : ata_piix ata2.00: failed to IDENTIFY (I/O error, err_mask=0x1) .. The err_mask is AC_ERR_DEV indicating that the device raised aborted the IDENTIFY command. I wonder what's going on. Can you change "#undef ATA_DEBUG" in include/linux/libata.h to

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Tejun Heo wrote: .. scsi1 : ata_piix ata2.00: failed to IDENTIFY (I/O error, err_mask=0x1) .. The err_mask is AC_ERR_DEV indicating that the device raised aborted the IDENTIFY command. I wonder what's going on. Can you change "#undef ATA_DEBUG" in include/linux/libata.h to "#define

Re: 2.6.20 libata cdrom

2007-05-01 Thread William Thompson
On Tue, May 01, 2007 at 06:32:07AM +0200, Tejun Heo wrote: > [cc'ing linux-ide and Albert, Hi!] And be sure to keep me in CC, I'm not on any of these lists. > William Thompson wrote: > > On Mon, Apr 30, 2007 at 12:22:21PM +0200, Tejun Heo wrote: > >> William Thompson wrote: > >>> I've been

Re: 2.6.20 libata cdrom

2007-05-01 Thread William Thompson
On Tue, May 01, 2007 at 06:32:07AM +0200, Tejun Heo wrote: [cc'ing linux-ide and Albert, Hi!] And be sure to keep me in CC, I'm not on any of these lists. William Thompson wrote: On Mon, Apr 30, 2007 at 12:22:21PM +0200, Tejun Heo wrote: William Thompson wrote: I've been playing with

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Tejun Heo wrote: .. scsi1 : ata_piix ata2.00: failed to IDENTIFY (I/O error, err_mask=0x1) .. The err_mask is AC_ERR_DEV indicating that the device raised aborted the IDENTIFY command. I wonder what's going on. Can you change #undef ATA_DEBUG in include/linux/libata.h to #define ATA_DEBUG

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Mark Lord wrote: Tejun Heo wrote: .. scsi1 : ata_piix ata2.00: failed to IDENTIFY (I/O error, err_mask=0x1) .. The err_mask is AC_ERR_DEV indicating that the device raised aborted the IDENTIFY command. I wonder what's going on. Can you change #undef ATA_DEBUG in include/linux/libata.h to

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
William Thompson wrote: +scsi2 : ata_piix +ata_port_schedule_eh: port EH scheduled +ata_scsi_error: ENTER +ata_port_flush_task: ENTER +ata_port_flush_task: flush #1 +ata2: ata_port_flush_task: flush #2 +ata2: ata_port_flush_task: EXIT +ata_eh_autopsy: ENTER +ata_eh_recover: ENTER

Re: 2.6.20 libata cdrom

2007-05-01 Thread William Thompson
On Tue, May 01, 2007 at 09:04:46AM -0400, Mark Lord wrote: William Thompson wrote: +scsi2 : ata_piix +ata_port_schedule_eh: port EH scheduled +ata_scsi_error: ENTER +ata_port_flush_task: ENTER +ata_port_flush_task: flush #1 +ata2: ata_port_flush_task: flush #2 +ata2: ata_port_flush_task:

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
William Thompson wrote: The one thing I do know, the machine with the non-working libata cdrom also does not work with the ide driver *ONLY IF* DMA is turned on. That's probably because it's a mdma2 device, and not many chipsets seem to do mdma2 correctly. I had a drive like that around

Re: 2.6.20 libata cdrom

2007-05-01 Thread Alan Cox
But libata might actually be able to use mdma2 with it, as I believe (unsubstantiated) that Alan may have done a better implementation of setting the timings than what we had with our old IDE drivers. The new code knows how to set MWDMA2 timings properly, and it knows about picking timings

Re: 2.6.20 libata cdrom

2007-05-01 Thread Tejun Heo
Mark Lord wrote: And this is the second one today where it would be very useful to see a tf dump. It's time to add one to that code patch, methinks. Yeah, we have all these fancy ata_msg_() thingies which can be used to provide a lot of debugging info without affecting hot path. We're just

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: And this is the second one today where it would be very useful to see a tf dump. It's time to add one to that code patch, methinks. Yeah, we have all these fancy ata_msg_() thingies which can be used to provide a lot of debugging info without affecting hot

Re: 2.6.20 libata cdrom

2007-05-01 Thread Tejun Heo
Hello, William Thompson wrote: On Tue, May 01, 2007 at 09:04:46AM -0400, Mark Lord wrote: +ata_dev_classify: found ATA device by sig +ata_dev_classify: unknown device +ata_std_softreset: EXIT, classes[0]=1 [1]=5 +ata_std_postreset: ENTER +ata_std_postreset: EXIT +ata_eh_thaw_port: ata2

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Gee... Two crazy screwed up devices today. What's going on? libata is finally seeing use by non-kernel developers. Cheers - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: 2.6.20 libata cdrom

2007-05-01 Thread Jeff Garzik
Mark Lord wrote: Gee... Two crazy screwed up devices today. What's going on? libata is finally seeing use by non-kernel developers. Amusing but factually incorrect. libata has been shipping in major distros for years, with bazoodles of active users. Jeff - To unsubscribe from

Re: 2.6.20 libata cdrom

2007-05-01 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Gee... Two crazy screwed up devices today. What's going on? libata is finally seeing use by non-kernel developers. Amusing but factually incorrect. libata has been shipping in major distros for years, with bazoodles of active users. But of course.

Re: 2.6.20 libata cdrom

2007-05-01 Thread Alan Cox
On Tue, 01 May 2007 10:19:33 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Mark Lord wrote: Gee... Two crazy screwed up devices today. What's going on? libata is finally seeing use by non-kernel developers. Amusing but factually incorrect. libata has been shipping in major distros for

Re: 2.6.20 libata cdrom

2007-05-01 Thread William Thompson
On Tue, May 01, 2007 at 03:40:36PM +0200, Tejun Heo wrote: Tejun, don't we have a fallback for when IDENTIFY fails? If the drive rejects it (err=0x04), then this can mean only one thing: unsupported command, so we next must try PACKET_IDENTIFY. Up until now, we've been depending on the

Re: 2.6.20 libata cdrom

2007-05-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 01 May 2007, William Thompson wrote: On Tue, May 01, 2007 at 09:04:46AM -0400, Mark Lord wrote: William Thompson wrote: +scsi2 : ata_piix +ata_port_schedule_eh: port EH scheduled +ata_scsi_error: ENTER +ata_port_flush_task: ENTER +ata_port_flush_task: flush #1

Re: 2.6.20 libata cdrom

2007-04-30 Thread Tejun Heo
[cc'ing linux-ide and Albert, Hi!] William Thompson wrote: > On Mon, Apr 30, 2007 at 12:22:21PM +0200, Tejun Heo wrote: >> William Thompson wrote: >>> I've been playing with libata on a few machines and I found that this >>> machine >>> (An old Dell Dimension L866r) gives me this when it loads

Re: 2.6.20 libata cdrom

2007-04-30 Thread William Thompson
On Mon, Apr 30, 2007 at 12:22:21PM +0200, Tejun Heo wrote: > William Thompson wrote: > > I've been playing with libata on a few machines and I found that this > > machine > > (An old Dell Dimension L866r) gives me this when it loads and does not give > > me > > access to the cdrom. This is the

Re: 2.6.20 libata cdrom

2007-04-30 Thread Tejun Heo
Hello, William Thompson wrote: > I've been playing with libata on a few machines and I found that this machine > (An old Dell Dimension L866r) gives me this when it loads and does not give me > access to the cdrom. This is the only machine that I've tested that I know > for a fact cannot do DMA

Re: 2.6.20 libata cdrom

2007-04-30 Thread Tejun Heo
Hello, William Thompson wrote: I've been playing with libata on a few machines and I found that this machine (An old Dell Dimension L866r) gives me this when it loads and does not give me access to the cdrom. This is the only machine that I've tested that I know for a fact cannot do DMA on

Re: 2.6.20 libata cdrom

2007-04-30 Thread William Thompson
On Mon, Apr 30, 2007 at 12:22:21PM +0200, Tejun Heo wrote: William Thompson wrote: I've been playing with libata on a few machines and I found that this machine (An old Dell Dimension L866r) gives me this when it loads and does not give me access to the cdrom. This is the only

Re: 2.6.20 libata cdrom

2007-04-30 Thread Tejun Heo
[cc'ing linux-ide and Albert, Hi!] William Thompson wrote: On Mon, Apr 30, 2007 at 12:22:21PM +0200, Tejun Heo wrote: William Thompson wrote: I've been playing with libata on a few machines and I found that this machine (An old Dell Dimension L866r) gives me this when it loads and does not

2.6.20 libata cdrom

2007-04-27 Thread William Thompson
I've been playing with libata on a few machines and I found that this machine (An old Dell Dimension L866r) gives me this when it loads and does not give me access to the cdrom. This is the only machine that I've tested that I know for a fact cannot do DMA on the cdrom. I searched and noticed a

2.6.20 libata cdrom

2007-04-27 Thread William Thompson
I've been playing with libata on a few machines and I found that this machine (An old Dell Dimension L866r) gives me this when it loads and does not give me access to the cdrom. This is the only machine that I've tested that I know for a fact cannot do DMA on the cdrom. I searched and noticed a