Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-04 Thread Russell King
On Tue, Jun 05, 2007 at 01:52:38AM +0200, Martin Peschke wrote: > Andrew Morton wrote: > >On Sat, 2 Jun 2007 19:14:25 +0200 > >Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > >>statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch > >> > >>shows why

Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-04 Thread Martin Peschke
Andrew Morton wrote: On Sat, 2 Jun 2007 19:14:25 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch shows why __attribute__((weak)) is harmful because you don't see if a required non-weak implemtation is

Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-04 Thread Andrew Morton
On Sat, 2 Jun 2007 19:14:25 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch > > shows why __attribute__((weak)) is harmful because you don't see if a > required non-weak implemtation is missing: > > In this

Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-04 Thread Andrew Morton
On Sat, 2 Jun 2007 19:14:25 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch shows why __attribute__((weak)) is harmful because you don't see if a required non-weak implemtation is missing: In this case,

Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-04 Thread Martin Peschke
Andrew Morton wrote: On Sat, 2 Jun 2007 19:14:25 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch shows why __attribute__((weak)) is harmful because you don't see if a required non-weak implemtation is missing:

Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-04 Thread Russell King
On Tue, Jun 05, 2007 at 01:52:38AM +0200, Martin Peschke wrote: Andrew Morton wrote: On Sat, 2 Jun 2007 19:14:25 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch shows why __attribute__((weak)) is harmful

2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-02 Thread Adrian Bunk
statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch shows why __attribute__((weak)) is harmful because you don't see if a required non-weak implemtation is missing: In this case, the weak printk_clock() was renamed to timestamp_clock(), but the ARM and i386

2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-02 Thread Adrian Bunk
statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch shows why __attribute__((weak)) is harmful because you don't see if a required non-weak implemtation is missing: In this case, the weak printk_clock() was renamed to timestamp_clock(), but the ARM and i386