Re: [Kgdb-bugreport] [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Jason Wessel
Randy, This patch is fine, and I am committing it to the for_mm kgdb tree. I am also adding the "depends on NET" to the KGDBOE_NOMODULE section, which would otherwise to a select on KGDBOE. We have to cover the case for KGDB as a module and not as a module. Thanks, Jason. Randy Dunlap

Re: [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Matt Mackall
On Wed, Sep 12, 2007 at 11:22:52AM -0700, Randy Dunlap wrote: > On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote: > > > NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my > > kconfig-addled brain. > > Correct. Patch corrected. Thanks. Looks good to me, but I'll leave the

[PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Randy Dunlap
On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote: > NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my > kconfig-addled brain. Correct. Patch corrected. Thanks. --- From: Randy Dunlap <[EMAIL PROTECTED]> Fix kgdb build problems: Building modules, stage 2. ERROR:

Re: [PATCH -mm] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Matt Mackall
On Wed, Sep 12, 2007 at 10:15:37AM -0700, Randy Dunlap wrote: > On Wed, 12 Sep 2007 11:31:22 +0200 Jiri Slaby wrote: > > > randconfig [1] causes this link errors: > > ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined! > > ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined! > >

[PATCH -mm] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Randy Dunlap
On Wed, 12 Sep 2007 11:31:22 +0200 Jiri Slaby wrote: > randconfig [1] causes this link errors: > ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined! > ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined! > ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined! > ERROR:

2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Jiri Slaby
Hi, randconfig [1] causes this link errors: ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined! ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined! ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined! ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined! ERROR:

[PATCH -mm] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Randy Dunlap
On Wed, 12 Sep 2007 11:31:22 +0200 Jiri Slaby wrote: randconfig [1] causes this link errors: ERROR: netpoll_cleanup [drivers/net/kgdboe.ko] undefined! ERROR: netpoll_setup [drivers/net/kgdboe.ko] undefined! ERROR: netpoll_parse_options [drivers/net/kgdboe.ko] undefined! ERROR: netpoll_poll

Re: [PATCH -mm] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Matt Mackall
On Wed, Sep 12, 2007 at 10:15:37AM -0700, Randy Dunlap wrote: On Wed, 12 Sep 2007 11:31:22 +0200 Jiri Slaby wrote: randconfig [1] causes this link errors: ERROR: netpoll_cleanup [drivers/net/kgdboe.ko] undefined! ERROR: netpoll_setup [drivers/net/kgdboe.ko] undefined! ERROR:

[PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Randy Dunlap
On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote: NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my kconfig-addled brain. Correct. Patch corrected. Thanks. --- From: Randy Dunlap [EMAIL PROTECTED] Fix kgdb build problems: Building modules, stage 2. ERROR:

Re: [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Matt Mackall
On Wed, Sep 12, 2007 at 11:22:52AM -0700, Randy Dunlap wrote: On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote: NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my kconfig-addled brain. Correct. Patch corrected. Thanks. Looks good to me, but I'll leave the actual ack

Re: [Kgdb-bugreport] [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Jason Wessel
Randy, This patch is fine, and I am committing it to the for_mm kgdb tree. I am also adding the depends on NET to the KGDBOE_NOMODULE section, which would otherwise to a select on KGDBOE. We have to cover the case for KGDB as a module and not as a module. Thanks, Jason. Randy Dunlap wrote:

2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Jiri Slaby
Hi, randconfig [1] causes this link errors: ERROR: netpoll_cleanup [drivers/net/kgdboe.ko] undefined! ERROR: netpoll_setup [drivers/net/kgdboe.ko] undefined! ERROR: netpoll_parse_options [drivers/net/kgdboe.ko] undefined! ERROR: netpoll_poll [drivers/net/kgdboe.ko] undefined! ERROR: