--- Original Message ---
Sender : Jongman Heo
Date : 2012-10-24 11:53 (GMT+09:00)
Title : Re: Re: [Pv-drivers] 3.7-rc2 regression : file copied to CIFS-mounted
directory corrupted
Hi,
--- Original Message ---
Sender : Eric Dumazet
Date : 2012-10-24 04:39 (GMT+09:00)
Title : Re
--- Original Message ---
Sender : Jongman Heojongman@samsung.com
Date : 2012-10-24 11:53 (GMT+09:00)
Title : Re: Re: [Pv-drivers] 3.7-rc2 regression : file copied to CIFS-mounted
directory corrupted
Hi,
--- Original Message ---
Sender : Eric Dumazet
Date : 2012-10-24 04:39
Hi,
--- Original Message ---
Sender : Eric Dumazet
Date : 2012-10-24 04:39 (GMT+09:00)
Title : Re: [Pv-drivers] 3.7-rc2 regression : file copied to CIFS-mounted
directory corrupted
On Tue, 2012-10-23 at 15:50 +0200, Eric Dumazet wrote:
> Only the skb head is handled in the code
On Tue, 2012-10-23 at 15:50 +0200, Eric Dumazet wrote:
> Only the skb head is handled in the code you copy/pasted.
>
> You need to generalize that to code in lines ~754
>
>
> Then, the number of estimated descriptors is bad :
>
> /* conservatively estimate # of descriptors to use */
> count =
On Tue, 2012-10-23 at 03:02 -0700, Shreyas Bhatewara wrote:
Please dont top post on netdev or lkml
> Well, actually the driver does split large frags into frags of
> VMXNET3_MAX_TX_BUF_SIZE bytes each.
>
> vmxnet3_drv.c
> 711 while (len) {
> 712 u32 buf_size;
> 713
>
Well, actually the driver does split large frags into frags of
VMXNET3_MAX_TX_BUF_SIZE bytes each.
vmxnet3_drv.c
711 while (len) {
712 u32 buf_size;
713
714 if (len < VMXNET3_MAX_TX_BUF_SIZE) {
715 buf_size = len;
716
Eric, thanks for the note. I will submit a patch to do it.
Shreyas
- Original Message -
> On Tue, 2012-10-23 at 08:17 +, Jongman Heo wrote:
>
> >
> > FYI, vmxnet3 driver is used for ethernet.
>
> Yes, this driver needs some changes
>
> #define VMXNET3_MAX_TX_BUF_SIZE (1 << 14)
>
On Tue, 2012-10-23 at 08:17 +, Jongman Heo wrote:
>
> FYI, vmxnet3 driver is used for ethernet.
Yes, this driver needs some changes
#define VMXNET3_MAX_TX_BUF_SIZE (1 << 14)
Thats 16KB
As we can now provide up to 32KB fragments we broke something.
vmxnet3_tq_xmit() needs to split large
Hi,
--- Original Message ---
Sender : Eric Dumazet
Date : 2012-10-23 15:08 (GMT+09:00)
Title : Re: 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted
On Tue, 2012-10-23 at 05:38 +, Jongman Heo wrote:
> Hmm,
>
> I've just met the issue, with the commit
On Tue, 2012-10-23 at 05:38 +, Jongman Heo wrote:
> Hmm,
>
> I've just met the issue, with the commit 5640f768 reverted.
> It seems that the issue does not always happen. So, my bisection may not be
> correct.
>
> At this moment, I don't have enough time to do bisection again..
>
>
On Tue, 2012-10-23 at 05:38 +, Jongman Heo wrote:
Hmm,
I've just met the issue, with the commit 5640f768 reverted.
It seems that the issue does not always happen. So, my bisection may not be
correct.
At this moment, I don't have enough time to do bisection again..
Regards.
What
Hi,
--- Original Message ---
Sender : Eric Dumazeteric.duma...@gmail.com
Date : 2012-10-23 15:08 (GMT+09:00)
Title : Re: 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted
On Tue, 2012-10-23 at 05:38 +, Jongman Heo wrote:
Hmm,
I've just met the issue
On Tue, 2012-10-23 at 08:17 +, Jongman Heo wrote:
FYI, vmxnet3 driver is used for ethernet.
Yes, this driver needs some changes
#define VMXNET3_MAX_TX_BUF_SIZE (1 14)
Thats 16KB
As we can now provide up to 32KB fragments we broke something.
vmxnet3_tq_xmit() needs to split large
Eric, thanks for the note. I will submit a patch to do it.
Shreyas
- Original Message -
On Tue, 2012-10-23 at 08:17 +, Jongman Heo wrote:
FYI, vmxnet3 driver is used for ethernet.
Yes, this driver needs some changes
#define VMXNET3_MAX_TX_BUF_SIZE (1 14)
Thats 16KB
Well, actually the driver does split large frags into frags of
VMXNET3_MAX_TX_BUF_SIZE bytes each.
vmxnet3_drv.c
711 while (len) {
712 u32 buf_size;
713
714 if (len VMXNET3_MAX_TX_BUF_SIZE) {
715 buf_size = len;
716
On Tue, 2012-10-23 at 03:02 -0700, Shreyas Bhatewara wrote:
Please dont top post on netdev or lkml
Well, actually the driver does split large frags into frags of
VMXNET3_MAX_TX_BUF_SIZE bytes each.
vmxnet3_drv.c
711 while (len) {
712 u32 buf_size;
713
714
On Tue, 2012-10-23 at 15:50 +0200, Eric Dumazet wrote:
Only the skb head is handled in the code you copy/pasted.
You need to generalize that to code in lines ~754
Then, the number of estimated descriptors is bad :
/* conservatively estimate # of descriptors to use */
count =
Hi,
--- Original Message ---
Sender : Eric Dumazet
Date : 2012-10-24 04:39 (GMT+09:00)
Title : Re: [Pv-drivers] 3.7-rc2 regression : file copied to CIFS-mounted
directory corrupted
On Tue, 2012-10-23 at 15:50 +0200, Eric Dumazet wrote:
Only the skb head is handled in the code you copy
writing for
mailing list... ]
--- Original Message ---
Sender : Jongman Heo
Date : 2012-10-23 12:30 (GMT+09:00)
Title : 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted
Hi, all,
With 3.7-rc2, I noticed that file copied to CIFS-mounted directory is
corrupted.
Integrity
Hi, all,
With 3.7-rc2, I noticed that file copied to CIFS-mounted directory is
corrupted.
Integrity is checked by md5sum.
1. get md5sum of file located on local (ext4) disk
2. copy the file to CIFS-mounted directory
3. check md5sum of the copied file
Host : Windows 7
Guest : Fedora
Hi, all,
With 3.7-rc2, I noticed that file copied to CIFS-mounted directory is
corrupted.
Integrity is checked by md5sum.
1. get md5sum of file located on local (ext4) disk
2. copy the file to CIFS-mounted directory
3. check md5sum of the copied file
Host : Windows 7
Guest : Fedora
writing for
mailing list... ]
--- Original Message ---
Sender : Jongman Heojongman@samsung.com
Date : 2012-10-23 12:30 (GMT+09:00)
Title : 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted
Hi, all,
With 3.7-rc2, I noticed that file copied to CIFS-mounted directory
22 matches
Mail list logo
