Re: 3.8-rc2/rc3 write() blocked on CLOSE_WAIT TCP socket

2013-01-10 Thread David Miller
From: Eric Dumazet Date: Thu, 10 Jan 2013 18:18:47 -0800 > [PATCH] tcp: accept RST without ACK flag > > commit c3ae62af8e755 (tcp: should drop incoming frames without ACK flag > set) added a regression on the handling of RST messages. > > RST should be allowed to come even without ACK bit set.

Re: 3.8-rc2/rc3 write() blocked on CLOSE_WAIT TCP socket

2013-01-10 Thread Eric Wong
Eric Dumazet wrote: > Yes, thats definitely the problem, sorry for that. > > > [PATCH] tcp: accept RST without ACK flag > > commit c3ae62af8e755 (tcp: should drop incoming frames without ACK flag > set) added a regression on the handling of RST messages. > > RST should be allowed to come even

Re: 3.8-rc2/rc3 write() blocked on CLOSE_WAIT TCP socket

2013-01-10 Thread Neal Cardwell
On Thu, Jan 10, 2013 at 9:18 PM, Eric Dumazet wrote: > From: Eric Dumazet > > On Thu, 2013-01-10 at 18:01 -0800, Eric Dumazet wrote: > >> Hmm, it might be commit c3ae62af8e755ea68380fb5ce682e60079a4c388 >> tcp: should drop incoming frames without ACK flag set >> >> It seems RST should be allowed

Re: 3.8-rc2/rc3 write() blocked on CLOSE_WAIT TCP socket

2013-01-10 Thread Eric Dumazet
From: Eric Dumazet On Thu, 2013-01-10 at 18:01 -0800, Eric Dumazet wrote: > Hmm, it might be commit c3ae62af8e755ea68380fb5ce682e60079a4c388 > tcp: should drop incoming frames without ACK flag set > > It seems RST should be allowed to not have ACK set. > > I'll send a fix, thanks ! Yes, thats

Re: 3.8-rc2/rc3 write() blocked on CLOSE_WAIT TCP socket

2013-01-10 Thread Eric Dumazet
On Fri, 2013-01-11 at 00:49 +, Eric Wong wrote: > The below Ruby script reproduces the issue for me with write() > getting stuck, usually with a few iterations (sometimes up to 100). > > I've reproduced this with 3.8-rc2 and rc3, even with Mel's partial > revert patch in <20130110194212.gj13..

3.8-rc2/rc3 write() blocked on CLOSE_WAIT TCP socket

2013-01-10 Thread Eric Wong
The below Ruby script reproduces the issue for me with write() getting stuck, usually with a few iterations (sometimes up to 100). I've reproduced this with 3.8-rc2 and rc3, even with Mel's partial revert patch in <20130110194212.gj13...@suse.de> applied. I can not reproduce this with 3.7.1+ s