Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Borislav Petkov
On Sat, Sep 10, 2016 at 11:03:29PM +0800, Rui Wang wrote: > From b37d806c78e5eea70dbb890c1e3dbb8b7e5038e6 Mon Sep 17 00:00:00 2001 > From: Rui Wang > Date: Sat, 10 Sep 2016 10:56:34 -0400 > Subject: [PATCH] x86/ioapic: Ignore root bridges without a companion ACPI > device >

Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Borislav Petkov
On Sat, Sep 10, 2016 at 11:03:29PM +0800, Rui Wang wrote: > From b37d806c78e5eea70dbb890c1e3dbb8b7e5038e6 Mon Sep 17 00:00:00 2001 > From: Rui Wang > Date: Sat, 10 Sep 2016 10:56:34 -0400 > Subject: [PATCH] x86/ioapic: Ignore root bridges without a companion ACPI > device > > Some PCI root

Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Rui Wang
On Sat, Sep 10, 2016 10:31 PM, Borislav Petkov wrote: > > On Sat, Sep 10, 2016 at 09:11:30PM +0800, Rui Wang wrote: > > Thanks for the analysis. Looks like acpi_gbl_root_node == 0. It is > > Is ACPI_HANDLE(root_bus->bridge) == ACPI_ROOT_OBJECT? > > Because this is what the code does but I can't

Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Rui Wang
On Sat, Sep 10, 2016 10:31 PM, Borislav Petkov wrote: > > On Sat, Sep 10, 2016 at 09:11:30PM +0800, Rui Wang wrote: > > Thanks for the analysis. Looks like acpi_gbl_root_node == 0. It is > > Is ACPI_HANDLE(root_bus->bridge) == ACPI_ROOT_OBJECT? > > Because this is what the code does but I can't

Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Borislav Petkov
On Sat, Sep 10, 2016 at 09:11:30PM +0800, Rui Wang wrote: > Thanks for the analysis. Looks like acpi_gbl_root_node == 0. It is Is ACPI_HANDLE(root_bus->bridge) == ACPI_ROOT_OBJECT? Because this is what the code does but I can't see it from the code that the handle is of type ACPI_ROOT_OBJECT...

Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Borislav Petkov
On Sat, Sep 10, 2016 at 09:11:30PM +0800, Rui Wang wrote: > Thanks for the analysis. Looks like acpi_gbl_root_node == 0. It is Is ACPI_HANDLE(root_bus->bridge) == ACPI_ROOT_OBJECT? Because this is what the code does but I can't see it from the code that the handle is of type ACPI_ROOT_OBJECT...

Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Rui Wang
On Sat, Sep 10, 2016 7:28 PM, Borislav Petkov wrote: > > 8143ef50 : > 8143ef50: e8 6b 16 42 00 callq 818605c0 > <__fentry__> > 8143ef55: 55 push %rbp > 8143ef56: 48 89 e5mov%rsp,%rbp >

Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Rui Wang
On Sat, Sep 10, 2016 7:28 PM, Borislav Petkov wrote: > > 8143ef50 : > 8143ef50: e8 6b 16 42 00 callq 818605c0 > <__fentry__> > 8143ef55: 55 push %rbp > 8143ef56: 48 89 e5mov%rsp,%rbp >

Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Borislav Petkov
On Sat, Sep 10, 2016 at 08:14:04AM +0800, Rui Wang wrote: > Is it a Romley-EP ? What kind of SNB box is it? I'll try to find one > to reproduce the problem. You don't have to - I went and analyzed it for you but it is ACPI crap and I can't be bothered to think of a solution. It looks like a

Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-10 Thread Borislav Petkov
On Sat, Sep 10, 2016 at 08:14:04AM +0800, Rui Wang wrote: > Is it a Romley-EP ? What kind of SNB box is it? I'll try to find one > to reproduce the problem. You don't have to - I went and analyzed it for you but it is ACPI crap and I can't be bothered to think of a solution. It looks like a

584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-09 Thread Rui Wang
On Saturday, September 10, 2016 6:07 AM, Borislav Petkov wrote: > > Hi, > > commit in $Subject from tip breaks booting on my SNB test box, it freezes > somewhere very early during boot. When I revert the aforementioned > commit ontop of Linus' master + tip/master from today, it boots fine. > >

584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-09 Thread Rui Wang
On Saturday, September 10, 2016 6:07 AM, Borislav Petkov wrote: > > Hi, > > commit in $Subject from tip breaks booting on my SNB test box, it freezes > somewhere very early during boot. When I revert the aforementioned > commit ontop of Linus' master + tip/master from today, it boots fine. > >

584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-09 Thread Borislav Petkov
Hi, commit in $Subject from tip breaks booting on my SNB test box, it freezes somewhere very early during boot. When I revert the aforementioned commit ontop of Linus' master + tip/master from today, it boots fine. Additional info is available upon request. Thanks. -- Regards/Gruss,

584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

2016-09-09 Thread Borislav Petkov
Hi, commit in $Subject from tip breaks booting on my SNB test box, it freezes somewhere very early during boot. When I revert the aforementioned commit ontop of Linus' master + tip/master from today, it boots fine. Additional info is available upon request. Thanks. -- Regards/Gruss,