Re: 8250_dw bug

2018-01-11 Thread Greg KH
On Thu, Jan 11, 2018 at 01:47:31PM +0100, Nuno Gonçalves wrote: > Dear Ed and Greg, > > There is a small bug on de9e33bdfa22e607a88494ff21e9196d00bf4550, at > least on 32bit devices. > > Line 274 if (rate >= i * min_rate && rate <= i * max_rate) > > This will overflow when min_rate/max_rate is l

8250_dw bug

2018-01-11 Thread Nuno Gonçalves
Dear Ed and Greg, There is a small bug on de9e33bdfa22e607a88494ff21e9196d00bf4550, at least on 32bit devices. Line 274 if (rate >= i * min_rate && rate <= i * max_rate) This will overflow when min_rate/max_rate is large and can not be achieved in the hardware. Eg. stty -F /dev/ttyS2 raw 35000