Re: A potential broken at platform driver?

2019-06-11 Thread Greg KH
On Tue, Jun 11, 2019 at 09:10:05AM -0500, Richard Gong wrote: > > Hi Greg, > > On 6/4/19 12:03 PM, Greg KH wrote: > > On Tue, Jun 04, 2019 at 11:13:02AM -0500, Richard Gong wrote: > > > > > > Hi Greg, > > > > > > On 6/4/19 9:28 AM, Greg KH wrote: > > > > On Tue, Jun 04, 2019 at 12:33:03PM

Re: A potential broken at platform driver?

2019-06-11 Thread Richard Gong
Hi Greg, On 6/4/19 12:03 PM, Greg KH wrote: On Tue, Jun 04, 2019 at 11:13:02AM -0500, Richard Gong wrote: Hi Greg, On 6/4/19 9:28 AM, Greg KH wrote: On Tue, Jun 04, 2019 at 12:33:03PM +0200, Romain Izard wrote: On Mon, Jun 03, 2019 at 08:02:55PM +0200, Greg KH wrote: @@ -394,7 +432,7 @@

Re: A potential broken at platform driver?

2019-06-04 Thread Greg KH
On Tue, Jun 04, 2019 at 11:13:02AM -0500, Richard Gong wrote: > > Hi Greg, > > On 6/4/19 9:28 AM, Greg KH wrote: > > On Tue, Jun 04, 2019 at 12:33:03PM +0200, Romain Izard wrote: > > > On Mon, Jun 03, 2019 at 08:02:55PM +0200, Greg KH wrote: > > > > > @@ -394,7 +432,7 @@ static struct

Re: A potential broken at platform driver?

2019-06-04 Thread Richard Gong
Hi Greg, On 6/4/19 9:28 AM, Greg KH wrote: On Tue, Jun 04, 2019 at 12:33:03PM +0200, Romain Izard wrote: On Mon, Jun 03, 2019 at 08:02:55PM +0200, Greg KH wrote: @@ -394,7 +432,7 @@ static struct platform_driver stratix10_rsu_driver = { .remove = stratix10_rsu_remove,

Re: A potential broken at platform driver?

2019-06-04 Thread Greg KH
On Mon, Jun 03, 2019 at 06:08:37PM -0500, Richard Gong wrote: > Hi Greg, > > On 6/3/19 1:02 PM, Greg KH wrote: > > On Mon, Jun 03, 2019 at 10:57:18AM -0500, Richard Gong wrote: > > > > > > Hi Greg, > > > > > > Following your suggestion, I replaced devm_device_add_groups() with > > > .group = >

Re: A potential broken at platform driver?

2019-06-04 Thread Greg KH
On Tue, Jun 04, 2019 at 12:33:03PM +0200, Romain Izard wrote: > On Mon, Jun 03, 2019 at 08:02:55PM +0200, Greg KH wrote: > > > @@ -394,7 +432,7 @@ static struct platform_driver stratix10_rsu_driver = { > > > .remove = stratix10_rsu_remove, > > > .driver = { > > > .name =

Re: A potential broken at platform driver?

2019-06-04 Thread Romain Izard
On Mon, Jun 03, 2019 at 08:02:55PM +0200, Greg KH wrote: > > @@ -394,7 +432,7 @@ static struct platform_driver stratix10_rsu_driver = { > > .remove = stratix10_rsu_remove, > > .driver = { > > .name = "stratix10-rsu", > > - .groups = rsu_groups, > > +// .groups

Re: A potential broken at platform driver?

2019-06-03 Thread Richard Gong
Hi Greg, On 6/3/19 1:02 PM, Greg KH wrote: On Mon, Jun 03, 2019 at 10:57:18AM -0500, Richard Gong wrote: Hi Greg, Following your suggestion, I replaced devm_device_add_groups() with .group = rus_groups in my version #4 submission. But I found out that RSU driver outputs the garbage data if I

Re: A potential broken at platform driver?

2019-06-03 Thread Greg KH
On Mon, Jun 03, 2019 at 10:57:18AM -0500, Richard Gong wrote: > > Hi Greg, > > Following your suggestion, I replaced devm_device_add_groups() with .group = > rus_groups in my version #4 submission. But I found out that RSU driver > outputs the garbage data if I use .group = rsu_groups. What is

A potential broken at platform driver?

2019-06-03 Thread Richard Gong
Hi Greg, Following your suggestion, I replaced devm_device_add_groups() with .group = rus_groups in my version #4 submission. But I found out that RSU driver outputs the garbage data if I use .group = rsu_groups. To make RSU driver work properly, I have to revert the change at version #4