Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

On Sep 27 2017 15:38, SF Markus Elfring wrote: As long as I know, the last product with this solution was shipped at 2010. Thus the driver is under maintenance. Thanks for your information. I have some tasks for this driver as well as drivers in ALSA firewire stack, however basically this

Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

On Sep 27 2017 15:38, SF Markus Elfring wrote: As long as I know, the last product with this solution was shipped at 2010. Thus the driver is under maintenance. Thanks for your information. I have some tasks for this driver as well as drivers in ALSA firewire stack, however basically this

Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

> As long as I know, the last product with this solution was shipped > at 2010. Thus the driver is under maintenance. Thanks for your information. > I have some tasks for this driver as well as drivers in ALSA firewire stack, > however basically this driver is under maintenance and might not

Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

> As long as I know, the last product with this solution was shipped > at 2010. Thus the driver is under maintenance. Thanks for your information. > I have some tasks for this driver as well as drivers in ALSA firewire stack, > however basically this driver is under maintenance and might not

Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

Hi, On Sep 24 2017 16:06, SF Markus Elfring wrote: 668 if (!amdtp_stream_wait_callback(>tx_stream, 669 CALLBACK_TIMEOUT)) { 670 amdtp_stream_stop(>tx_stream); 671 amdtp_stream_stop(>rx_stream); 672 break_both_connections(bebob);

Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

Hi, On Sep 24 2017 16:06, SF Markus Elfring wrote: 668 if (!amdtp_stream_wait_callback(>tx_stream, 669 CALLBACK_TIMEOUT)) { 670 amdtp_stream_stop(>tx_stream); 671 amdtp_stream_stop(>rx_stream); 672 break_both_connections(bebob);

Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

> 668 if (!amdtp_stream_wait_callback(>tx_stream, > 669 CALLBACK_TIMEOUT)) { > 670 amdtp_stream_stop(>tx_stream); > 671 amdtp_stream_stop(>rx_stream); > 672 break_both_connections(bebob); > 673 err = -ETIMEDOUT; > 674 } >

Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

> 668 if (!amdtp_stream_wait_callback(>tx_stream, > 669 CALLBACK_TIMEOUT)) { > 670 amdtp_stream_stop(>tx_stream); > 671 amdtp_stream_stop(>rx_stream); > 672 break_both_connections(bebob); > 673 err = -ETIMEDOUT; > 674 } >

Re: [PATCH 1/3] ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

Hi, On Sep 6 2017 19:22, SF Markus Elfring wrote: From: Markus Elfring Date: Wed, 6 Sep 2017 11:40:53 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle

Re: [PATCH 1/3] ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

Hi, On Sep 6 2017 19:22, SF Markus Elfring wrote: From: Markus Elfring Date: Wed, 6 Sep 2017 11:40:53 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus

[PATCH 1/3] ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

From: Markus Elfring Date: Wed, 6 Sep 2017 11:40:53 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 1/3] ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()

From: Markus Elfring Date: Wed, 6 Sep 2017 11:40:53 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/firewire/bebob/bebob_stream.c |