>> Andrew,
>>
>> Thanks for reviewing the patchset, this patch is on my review and test
>> queue (which has gotten rather long of late). I'll test it further and
>> get back.
>
> I still think this version is very wrong. It makes the ->signal->stats
> absolutely meaningless. Quoting myself:
>
On 09/20, Balbir Singh wrote:
>
> Andrew Morton wrote:
> > On Tue, 18 Sep 2007 00:23:39 +0200 Guillaume Chazarain <[EMAIL PROTECTED]>
> > wrote:
> >
> >> TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, not
> >> the basic and extended accounting. With this patch,
> >>
Andrew Morton wrote:
> On Tue, 18 Sep 2007 00:23:39 +0200 Guillaume Chazarain <[EMAIL PROTECTED]>
> wrote:
>
>> TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, not
>> the basic and extended accounting. With this patch,
>> TASKSTATS_CMD_ATTR_TGID also aggregates the
On Tue, 18 Sep 2007 00:23:39 +0200 Guillaume Chazarain <[EMAIL PROTECTED]>
wrote:
> TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, not
> the basic and extended accounting. With this patch,
> TASKSTATS_CMD_ATTR_TGID also aggregates the accounting info for all threads
>
On Tue, 18 Sep 2007 00:23:39 +0200 Guillaume Chazarain [EMAIL PROTECTED]
wrote:
TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, not
the basic and extended accounting. With this patch,
TASKSTATS_CMD_ATTR_TGID also aggregates the accounting info for all threads
of a
Andrew Morton wrote:
On Tue, 18 Sep 2007 00:23:39 +0200 Guillaume Chazarain [EMAIL PROTECTED]
wrote:
TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, not
the basic and extended accounting. With this patch,
TASKSTATS_CMD_ATTR_TGID also aggregates the accounting info
On 09/20, Balbir Singh wrote:
Andrew Morton wrote:
On Tue, 18 Sep 2007 00:23:39 +0200 Guillaume Chazarain [EMAIL PROTECTED]
wrote:
TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, not
the basic and extended accounting. With this patch,
Andrew,
Thanks for reviewing the patchset, this patch is on my review and test
queue (which has gotten rather long of late). I'll test it further and
get back.
I still think this version is very wrong. It makes the -signal-stats
absolutely meaningless. Quoting myself:
Hi, Oleg,
Yes,
On 09/18, Guillaume Chazarain wrote:
>
> @@ -508,7 +543,7 @@ void taskstats_exit(struct task_struct *
> if (!stats)
> goto err;
>
> - memcpy(stats, tsk->signal->stats, sizeof(*stats));
> + fill_tgid(tsk->pid, tsk, stats);
No, no, this is wrong.
tsk->signal->stats
On 09/18, Guillaume Chazarain wrote:
@@ -508,7 +543,7 @@ void taskstats_exit(struct task_struct *
if (!stats)
goto err;
- memcpy(stats, tsk-signal-stats, sizeof(*stats));
+ fill_tgid(tsk-pid, tsk, stats);
No, no, this is wrong.
tsk-signal-stats contains the
TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, not
the basic and extended accounting. With this patch,
TASKSTATS_CMD_ATTR_TGID also aggregates the accounting info for all threads
of a thread group. This makes TASKSTATS_CMD_ATTR_TGID usable in a similar
fashion to
TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, not
the basic and extended accounting. With this patch,
TASKSTATS_CMD_ATTR_TGID also aggregates the accounting info for all threads
of a thread group. This makes TASKSTATS_CMD_ATTR_TGID usable in a similar
fashion to
12 matches
Mail list logo
