Re: Always zero test in arch/i386/pci/mmconfig-shared.c

2007-07-13 Thread Scott Ashcroft
Robert Hancock wrote: > You missed this code: name = pci_mmcfg_probes[i].probe(); This calls one of the probe functions above, which will set pci_mmcfg_config_num to something else, as with the name variable. It may set the name but not the config num, if the chipset is recognized but

Re: Always zero test in arch/i386/pci/mmconfig-shared.c

2007-07-13 Thread Robert Hancock
Scott Ashcroft wrote: I don't think it makes any change to subsequent flow but the code in pci_mmcfg_check_hostbridge is: pci_mmcfg_config_num = 0; You missed this code: name = pci_mmcfg_probes[i].probe(); This calls one of the probe functions above, which will set pci_mmcfg_config_num

Re: Always zero test in arch/i386/pci/mmconfig-shared.c

2007-07-13 Thread Robert Hancock
Scott Ashcroft wrote: I don't think it makes any change to subsequent flow but the code in pci_mmcfg_check_hostbridge is: pci_mmcfg_config_num = 0; You missed this code: name = pci_mmcfg_probes[i].probe(); This calls one of the probe functions above, which will set pci_mmcfg_config_num

Re: Always zero test in arch/i386/pci/mmconfig-shared.c

2007-07-13 Thread Scott Ashcroft
Robert Hancock wrote: You missed this code: name = pci_mmcfg_probes[i].probe(); This calls one of the probe functions above, which will set pci_mmcfg_config_num to something else, as with the name variable. It may set the name but not the config num, if the chipset is recognized but

Always zero test in arch/i386/pci/mmconfig-shared.c

2007-07-10 Thread Scott Ashcroft
I don't think it makes any change to subsequent flow but the code in pci_mmcfg_check_hostbridge is: pci_mmcfg_config_num = 0; ... if (name) { printk(KERN_INFO "PCI: Found %s %s MMCONFIG support.\n", name, pci_mmcfg_config_num ? "with" : "without"); } So it will always

Always zero test in arch/i386/pci/mmconfig-shared.c

2007-07-10 Thread Scott Ashcroft
I don't think it makes any change to subsequent flow but the code in pci_mmcfg_check_hostbridge is: pci_mmcfg_config_num = 0; ... if (name) { printk(KERN_INFO PCI: Found %s %s MMCONFIG support.\n, name, pci_mmcfg_config_num ? with : without); } So it will always prints