Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-29 Thread Joerg Roedel
Hi Kelly, On Fri, Feb 26, 2016 at 07:16:29PM +, Zytaruk, Kelly wrote: > I applied the fix and the WARN on ats_enabled flag goes away. The > detach_device() gets called against the correct dev when > pci_sriov_disable is called. This looks like it is fixed. Great, thanks for testing. I'll

Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-29 Thread Joerg Roedel
Hi Kelly, On Fri, Feb 26, 2016 at 07:16:29PM +, Zytaruk, Kelly wrote: > I applied the fix and the WARN on ats_enabled flag goes away. The > detach_device() gets called against the correct dev when > pci_sriov_disable is called. This looks like it is fixed. Great, thanks for testing. I'll

RE: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-26 Thread Zytaruk, Kelly
Subject: Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV > on AMD GPU > > Hi Kelly, > > On Wed, Feb 24, 2016 at 06:29:56PM +, Zytaruk, Kelly wrote: > > I don't know if the asynchronous nature of the iommu attach/detach is > > by design o

RE: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-26 Thread Zytaruk, Kelly
Subject: Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV > on AMD GPU > > Hi Kelly, > > On Wed, Feb 24, 2016 at 06:29:56PM +, Zytaruk, Kelly wrote: > > I don't know if the asynchronous nature of the iommu attach/detach is > > by design o

Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-26 Thread Joerg Roedel
Hi Kelly, On Wed, Feb 24, 2016 at 06:29:56PM +, Zytaruk, Kelly wrote: > I don't know if the asynchronous nature of the iommu attach/detach is > by design or if it is broken somewhere up the tree and just not > working in my case. Maybe one of the iommu owners could answer this. Thanks a lot

Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-26 Thread Joerg Roedel
Hi Kelly, On Wed, Feb 24, 2016 at 06:29:56PM +, Zytaruk, Kelly wrote: > I don't know if the asynchronous nature of the iommu attach/detach is > by design or if it is broken somewhere up the tree and just not > working in my case. Maybe one of the iommu owners could answer this. Thanks a lot

RE: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-24 Thread Zytaruk, Kelly
; bhelg...@google.com; Marsan, Luugi; Joerg Roedel; Alex Williamson > Subject: RE: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV > on AMD GPU > > > > > -Original Message- > > From: Bjorn Helgaas [mailto:helg...@kernel.org] > > Sent: Tuesday, Fe

RE: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-24 Thread Zytaruk, Kelly
; bhelg...@google.com; Marsan, Luugi; Joerg Roedel; Alex Williamson > Subject: RE: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV > on AMD GPU > > > > > -Original Message- > > From: Bjorn Helgaas [mailto:helg...@kernel.org] > > Sent: Tuesday, Fe

RE: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-23 Thread Zytaruk, Kelly
mson > Subject: Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV > on AMD GPU > > [+cc Joerg, Alex] > > Hi Kelly, > > On Tue, Feb 23, 2016 at 03:52:13PM +, Zytaruk, Kelly wrote: > > As per our offline discussions I have created Bugz

RE: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-23 Thread Zytaruk, Kelly
mson > Subject: Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV > on AMD GPU > > [+cc Joerg, Alex] > > Hi Kelly, > > On Tue, Feb 23, 2016 at 03:52:13PM +, Zytaruk, Kelly wrote: > > As per our offline discussions I have created Bugz

Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-23 Thread Bjorn Helgaas
[+cc Joerg, Alex] Hi Kelly, On Tue, Feb 23, 2016 at 03:52:13PM +, Zytaruk, Kelly wrote: > As per our offline discussions I have created Bugzilla #112941 for > the SRIOV issue. https://bugzilla.kernel.org/show_bug.cgi?id=112941 > When trying to enable SRIOV on AMD GPU after doing a previous

Re: BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-23 Thread Bjorn Helgaas
[+cc Joerg, Alex] Hi Kelly, On Tue, Feb 23, 2016 at 03:52:13PM +, Zytaruk, Kelly wrote: > As per our offline discussions I have created Bugzilla #112941 for > the SRIOV issue. https://bugzilla.kernel.org/show_bug.cgi?id=112941 > When trying to enable SRIOV on AMD GPU after doing a previous

BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-23 Thread Zytaruk, Kelly
Bjorn, As per our offline discussions I have created Bugzilla #112941 for the SRIOV issue. When trying to enable SRIOV on AMD GPU after doing a previous enable / disable sequence the following warning is shown in dmesg. I suspect that there might be something missing from the cleanup on the

BUGZILLA [112941] - Cannot reenable SRIOV after disabling SRIOV on AMD GPU

2016-02-23 Thread Zytaruk, Kelly
Bjorn, As per our offline discussions I have created Bugzilla #112941 for the SRIOV issue. When trying to enable SRIOV on AMD GPU after doing a previous enable / disable sequence the following warning is shown in dmesg. I suspect that there might be something missing from the cleanup on the