Re: Broken initrd compression settings in 3.13

2013-12-23 Thread P J P
Hi, +-- On Fri, 20 Dec 2013, Linus Torvalds wrote --+ | So commit 1bf49dd4be0b ("./Makefile: export initial ramdisk | compression config option") seems to be totally broken. | | And I'm not saying that because Jan fixed a make-3.80 incompatibility | in commit 7ac181568342 ("fix build with

Re: Broken initrd compression settings in 3.13

2013-12-23 Thread P J P
Hi, +-- On Fri, 20 Dec 2013, Linus Torvalds wrote --+ | So commit 1bf49dd4be0b (./Makefile: export initial ramdisk | compression config option) seems to be totally broken. | | And I'm not saying that because Jan fixed a make-3.80 incompatibility | in commit 7ac181568342 (fix build with make

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Linus Torvalds
On Fri, Dec 20, 2013 at 6:23 PM, Jeff Layton wrote: > > But, what's the point of setting INITRD_COMPRESS-y at all if you're not > going to export INITRD_COMPRESS? Would it be better to just remove that > entire block in the Makefile (i.e. just revert PJP's patch?) I ended up committing the

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Jeff Layton
On Fri, 20 Dec 2013 18:15:29 -0800 Linus Torvalds wrote: > On Fri, Dec 20, 2013 at 5:39 PM, Andrew Morton > wrote: > > On Fri, 20 Dec 2013 16:41:43 -0800 Linus Torvalds > > wrote: > >> > >> (a) most sane people don't even have lz4 _installed_, so dracut won't > >> actually succeed > >> > >>

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Linus Torvalds
On Fri, Dec 20, 2013 at 6:33 PM, Jeff Layton wrote: > > Perhaps a better solution for this would be to instead export an > env var with a list of the compression algorithms that the kernel > supports. Then installkernel or dracut could use that info to make a > semi-intelligent decision based on

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Jeff Layton
On Fri, 20 Dec 2013 18:15:29 -0800 Linus Torvalds wrote: > On Fri, Dec 20, 2013 at 5:39 PM, Andrew Morton > wrote: > > On Fri, 20 Dec 2013 16:41:43 -0800 Linus Torvalds > > wrote: > >> > >> (a) most sane people don't even have lz4 _installed_, so dracut won't > >> actually succeed > >> > >>

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Linus Torvalds
On Fri, Dec 20, 2013 at 5:39 PM, Andrew Morton wrote: > On Fri, 20 Dec 2013 16:41:43 -0800 Linus Torvalds > wrote: >> >> (a) most sane people don't even have lz4 _installed_, so dracut won't >> actually succeed >> >> (b) there's no way to select the compression level (unlike the >>

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Andrew Morton
On Fri, 20 Dec 2013 16:41:43 -0800 Linus Torvalds wrote: > So commit 1bf49dd4be0b ("./Makefile: export initial ramdisk > compression config option") seems to be totally broken. > > And I'm not saying that because Jan fixed a make-3.80 incompatibility > in commit 7ac181568342 ("fix build with

Broken initrd compression settings in 3.13

2013-12-20 Thread Linus Torvalds
So commit 1bf49dd4be0b ("./Makefile: export initial ramdisk compression config option") seems to be totally broken. And I'm not saying that because Jan fixed a make-3.80 incompatibility in commit 7ac181568342 ("fix build with make 3.80") I'm saying that because it sets and exports the

Broken initrd compression settings in 3.13

2013-12-20 Thread Linus Torvalds
So commit 1bf49dd4be0b (./Makefile: export initial ramdisk compression config option) seems to be totally broken. And I'm not saying that because Jan fixed a make-3.80 incompatibility in commit 7ac181568342 (fix build with make 3.80) I'm saying that because it sets and exports the

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Andrew Morton
On Fri, 20 Dec 2013 16:41:43 -0800 Linus Torvalds torva...@linux-foundation.org wrote: So commit 1bf49dd4be0b (./Makefile: export initial ramdisk compression config option) seems to be totally broken. And I'm not saying that because Jan fixed a make-3.80 incompatibility in commit

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Linus Torvalds
On Fri, Dec 20, 2013 at 5:39 PM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 20 Dec 2013 16:41:43 -0800 Linus Torvalds torva...@linux-foundation.org wrote: (a) most sane people don't even have lz4 _installed_, so dracut won't actually succeed (b) there's no way to select the

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Jeff Layton
On Fri, 20 Dec 2013 18:15:29 -0800 Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Dec 20, 2013 at 5:39 PM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 20 Dec 2013 16:41:43 -0800 Linus Torvalds torva...@linux-foundation.org wrote: (a) most sane people don't even

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Linus Torvalds
On Fri, Dec 20, 2013 at 6:33 PM, Jeff Layton jlay...@redhat.com wrote: Perhaps a better solution for this would be to instead export an env var with a list of the compression algorithms that the kernel supports. Then installkernel or dracut could use that info to make a semi-intelligent

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Jeff Layton
On Fri, 20 Dec 2013 18:15:29 -0800 Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Dec 20, 2013 at 5:39 PM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 20 Dec 2013 16:41:43 -0800 Linus Torvalds torva...@linux-foundation.org wrote: (a) most sane people don't even

Re: Broken initrd compression settings in 3.13

2013-12-20 Thread Linus Torvalds
On Fri, Dec 20, 2013 at 6:23 PM, Jeff Layton jlay...@redhat.com wrote: But, what's the point of setting INITRD_COMPRESS-y at all if you're not going to export INITRD_COMPRESS? Would it be better to just remove that entire block in the Makefile (i.e. just revert PJP's patch?) I ended up