From: "Nekludov, Max"
Date: Tue, 1 Apr 2014 15:41:58 +
> Reset on RX failure and TX timeout.
>
> Electromagnetic noice can make device to not send TX interrupts.
> As result outgoing queue will be suspended forever.
> Also EMI can raise RX interrupt with zero value in KS_RXFC register.
>
>
Reset on RX failure and TX timeout.
Electromagnetic noice can make device to not send TX interrupts.
As result outgoing queue will be suspended forever.
Also EMI can raise RX interrupt with zero value in KS_RXFC register.
Patch attached.ks8851: reset on RX failure and TX timeout
Electromagnetic
Reset on RX failure and TX timeout.
Electromagnetic noice can make device to not send TX interrupts.
As result outgoing queue will be suspended forever.
Also EMI can raise RX interrupt with zero value in KS_RXFC register.
Patch attached.ks8851: reset on RX failure and TX timeout
Electromagnetic
From: Nekludov, Max max.neklu...@elster.com
Date: Tue, 1 Apr 2014 15:41:58 +
Reset on RX failure and TX timeout.
Electromagnetic noice can make device to not send TX interrupts.
As result outgoing queue will be suspended forever.
Also EMI can raise RX interrupt with zero value in
From: max.neklu...@us.elster.com
Date: Fri, 29 Mar 2013 19:27:36 +0400
> Denis,
> here is patch with commit message:
>
> Subject: [PATCH] Fix bug in ks8851 driver
>
> According to the Datasheet (page 52):
> 15-12 Reserved
> 11-0 RXBC Receive Byte Count
> This field indicates the present
---|
|>
| Subject: |
|>
>--------
please respin this patch with a commit description.
On 3/29/13, max.neklu...@us.elster.com wrote:
>
> Linus,
>
> I tried to send the mail to 'Ben Dooks ' but the address
> is dead now.
>> I assume you've tested it in practice?
> Yes, I'm running the modified code both in bootloader and Linux
Linus,
I tried to send the mail to 'Ben Dooks ' but the address
is dead now.
> I assume you've tested it in practice?
Yes, I'm running the modified code both in bootloader and Linux kernel on
my board.
Thanks,
Max
Signed-off-by: Max Nekludov
---
drivers/net/ethernet/micrel/ks8851.c | 2 +-
Linus,
I tried to send the mail to 'Ben Dooks b...@simtec.co.uk' but the address
is dead now.
I assume you've tested it in practice?
Yes, I'm running the modified code both in bootloader and Linux kernel on
my board.
Thanks,
Max
Signed-off-by: Max Nekludov max.neklu...@us.elster.com
---
please respin this patch with a commit description.
On 3/29/13, max.neklu...@us.elster.com max.neklu...@us.elster.com wrote:
Linus,
I tried to send the mail to 'Ben Dooks b...@simtec.co.uk' but the address
is dead now.
I assume you've tested it in practice?
Yes, I'm running the modified
: |
|
--|
|Re: Fw: Bug in ks8851.c
From: max.neklu...@us.elster.com
Date: Fri, 29 Mar 2013 19:27:36 +0400
Denis,
here is patch with commit message:
Subject: [PATCH] Fix bug in ks8851 driver
According to the Datasheet (page 52):
15-12 Reserved
11-0 RXBC Receive Byte Count
This field indicates the present received frame
Linus,
I tried to send the mail to 'Ben Dooks ' but the address
is dead now.
> I assume you've tested it in practice?
Yes, I'm running the modified code both in bootloader and Linux kernel on
my board.
Thanks,
Max
Signed-off-by: Max Nekludov
---
drivers/net/ethernet/micrel/ks8851.c | 2 +-
Max,
please cc the actual maintainers of the driver. The patch looks sane,
though. I assume you've tested it in practice?
You also seem to have based this on an ancient version, the code has
long since moved from drivers/net/ks8851.c to
drivers/net/ethernet/micrel/ks8851.c (back in June of
--|
|>
| Subject: |
|>
>---------
According to the Datasheet (page 52):
15-12 Reserved
11-0 RXBC Receive Byte Count
This field indicates the present received frame byte size.
I suppose the code has a bug:
rxh = ks8851_rdreg32(ks, KS_RXFHSR);
rxstat = rxh & 0x;
rxlen = rxh >>
According to the Datasheet (page 52):
15-12 Reserved
11-0 RXBC Receive Byte Count
This field indicates the present received frame byte size.
I suppose the code has a bug:
rxh = ks8851_rdreg32(ks, KS_RXFHSR);
rxstat = rxh 0x;
rxlen = rxh 16;
: |
|
--|
|Bug in ks8851.c
Max,
please cc the actual maintainers of the driver. The patch looks sane,
though. I assume you've tested it in practice?
You also seem to have based this on an ancient version, the code has
long since moved from drivers/net/ks8851.c to
drivers/net/ethernet/micrel/ks8851.c (back in June of
Linus,
I tried to send the mail to 'Ben Dooks b...@simtec.co.uk' but the address
is dead now.
I assume you've tested it in practice?
Yes, I'm running the modified code both in bootloader and Linux kernel on
my board.
Thanks,
Max
Signed-off-by: Max Nekludov max.neklu...@us.elster.com
---
20 matches
Mail list logo
