Re: Check all returns from audit_log_start

2012-09-06 Thread Dave Jones
On Thu, Sep 06, 2012 at 11:47:49AM -0400, Dave Jones wrote: > > Not certain because I haven't looked at what happens with the error > > code, but I think this might not be right. auditd can be explictly > > told not to audit certain events, in which case it is normal and > > expected that ab

Re: Check all returns from audit_log_start

2012-09-06 Thread Dave Jones
On Thu, Sep 06, 2012 at 11:36:06AM -0400, Eric Paris wrote: > On Thu, Sep 6, 2012 at 11:08 AM, Dave Jones wrote: > > Following on from the previous patch that fixed an oops, these > > are all the other similar code patterns in the tree with the same > > checks added. I never saw these

Re: Check all returns from audit_log_start

2012-09-06 Thread Eric Paris
On Thu, Sep 6, 2012 at 11:08 AM, Dave Jones wrote: > Following on from the previous patch that fixed an oops, these > are all the other similar code patterns in the tree with the same > checks added. I never saw these causing problems, but checking > this everywhere seems to make more sense than

Check all returns from audit_log_start

2012-09-06 Thread Dave Jones
Following on from the previous patch that fixed an oops, these are all the other similar code patterns in the tree with the same checks added. I never saw these causing problems, but checking this everywhere seems to make more sense than every subsequent routine that gets passed 'ab' having to

Check all returns from audit_log_start

2012-09-06 Thread Dave Jones
Following on from the previous patch that fixed an oops, these are all the other similar code patterns in the tree with the same checks added. I never saw these causing problems, but checking this everywhere seems to make more sense than every subsequent routine that gets passed 'ab' having to

Re: Check all returns from audit_log_start

2012-09-06 Thread Eric Paris
On Thu, Sep 6, 2012 at 11:08 AM, Dave Jones da...@redhat.com wrote: Following on from the previous patch that fixed an oops, these are all the other similar code patterns in the tree with the same checks added. I never saw these causing problems, but checking this everywhere seems to make

Re: Check all returns from audit_log_start

2012-09-06 Thread Dave Jones
On Thu, Sep 06, 2012 at 11:36:06AM -0400, Eric Paris wrote: On Thu, Sep 6, 2012 at 11:08 AM, Dave Jones da...@redhat.com wrote: Following on from the previous patch that fixed an oops, these are all the other similar code patterns in the tree with the same checks added. I never saw

Re: Check all returns from audit_log_start

2012-09-06 Thread Dave Jones
On Thu, Sep 06, 2012 at 11:47:49AM -0400, Dave Jones wrote: Not certain because I haven't looked at what happens with the error code, but I think this might not be right. auditd can be explictly told not to audit certain events, in which case it is normal and expected that ab would