Re: Coding style: mixed-case

2005-04-06 Thread Hugh Dickins
On Wed, 6 Apr 2005, Nick Piggin wrote: > Don't use PF_*. That namespace is already being used by at least > process flags and protocol flags. Maybe page_locked, page_dirty, > etc. might be better Much better. But... > Lastly, it is quite likely that many people will consider this to be > more

Re: Coding style: mixed-case

2005-04-06 Thread Nick Piggin
Kenneth Aafløy wrote: On Wednesday 06 April 2005 04:09, Matt Mackall wrote: While there may be reasons why mixed case is suboptimal, the real reason is that it's hard to keep track of which style is used where. It's annoying and error-prone to have to remember the naming format for everything in

Re: Coding style: mixed-case

2005-04-06 Thread Nick Piggin
Kenneth Aafløy wrote: On Wednesday 06 April 2005 04:09, Matt Mackall wrote: While there may be reasons why mixed case is suboptimal, the real reason is that it's hard to keep track of which style is used where. It's annoying and error-prone to have to remember the naming format for everything in

Re: Coding style: mixed-case

2005-04-06 Thread Hugh Dickins
On Wed, 6 Apr 2005, Nick Piggin wrote: Don't use PF_*. That namespace is already being used by at least process flags and protocol flags. Maybe page_locked, page_dirty, etc. might be better Much better. But... Lastly, it is quite likely that many people will consider this to be more

Re: Coding style: mixed-case

2005-04-05 Thread Kenneth Aafløy
On Wednesday 06 April 2005 04:09, Matt Mackall wrote: > While there may be reasons why mixed case is suboptimal, the real > reason is that it's hard to keep track of which style is used where. > It's annoying and error-prone to have to remember the naming format > for everything in addition to its

Re: Coding style: mixed-case

2005-04-05 Thread Matt Mackall
On Wed, Apr 06, 2005 at 03:29:21AM +0200, Kenneth Aafl?y wrote: > Hi, > > while reading Documentation/CodingStyle for the nth time, I realized that I > had > read some conflicting coding style in some patch posted to the linux-kernel > mailing-list; in include/linux/page-flags.h, there is a lot

Coding style: mixed-case

2005-04-05 Thread Kenneth Aafløy
Hi, while reading Documentation/CodingStyle for the nth time, I realized that I had read some conflicting coding style in some patch posted to the linux-kernel mailing-list; in include/linux/page-flags.h, there is a lot of defines that are apparently frowned upon: HOWEVER, while mixed-case names

Coding style: mixed-case

2005-04-05 Thread Kenneth Aafløy
Hi, while reading Documentation/CodingStyle for the nth time, I realized that I had read some conflicting coding style in some patch posted to the linux-kernel mailing-list; in include/linux/page-flags.h, there is a lot of defines that are apparently frowned upon: HOWEVER, while mixed-case names

Re: Coding style: mixed-case

2005-04-05 Thread Matt Mackall
On Wed, Apr 06, 2005 at 03:29:21AM +0200, Kenneth Aafl?y wrote: Hi, while reading Documentation/CodingStyle for the nth time, I realized that I had read some conflicting coding style in some patch posted to the linux-kernel mailing-list; in include/linux/page-flags.h, there is a lot of

Re: Coding style: mixed-case

2005-04-05 Thread Kenneth Aafløy
On Wednesday 06 April 2005 04:09, Matt Mackall wrote: While there may be reasons why mixed case is suboptimal, the real reason is that it's hard to keep track of which style is used where. It's annoying and error-prone to have to remember the naming format for everything in addition to its