Re: Dangerous devm_request_irq() conversions

2013-02-22 Thread 'Tejun Heo'
Hey, guys. On Fri, Feb 22, 2013 at 12:05:48AM -0800, Dmitry Torokhov wrote: > > Please, argue that it would be better to deprecate devm_request_irq() > > or devm_request_threaded_irq(). > > No, they do have their use. But probably people doing the conversion > should be required to put $100 in

Re: Dangerous devm_request_irq() conversions

2013-02-22 Thread Dmitry Torokhov
On Fri, Feb 22, 2013 at 04:57:29PM +0900, Jingoo Han wrote: > On Friday, February 22, 2013 4:27 PM, Dmitry Torokhov wrote: > > On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote: > > > On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: > > > > > > > > Hi, > > > > > > > > It looks

Re: Dangerous devm_request_irq() conversions

2013-02-22 Thread Dmitry Torokhov
On Fri, Feb 22, 2013 at 04:57:29PM +0900, Jingoo Han wrote: On Friday, February 22, 2013 4:27 PM, Dmitry Torokhov wrote: On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote: On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: Hi, It looks like a whole slew of

Re: Dangerous devm_request_irq() conversions

2013-02-22 Thread 'Tejun Heo'
Hey, guys. On Fri, Feb 22, 2013 at 12:05:48AM -0800, Dmitry Torokhov wrote: Please, argue that it would be better to deprecate devm_request_irq() or devm_request_threaded_irq(). No, they do have their use. But probably people doing the conversion should be required to put $100 in escrow

RE: Dangerous devm_request_irq() conversions

2013-02-21 Thread Jingoo Han
On Friday, February 22, 2013 4:27 PM, Dmitry Torokhov wrote: > On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote: > > On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: > > > > > > Hi, > > > > > > It looks like a whole slew of devm_request_irq() conversions just got > > >

Re: Dangerous devm_request_irq() conversions

2013-02-21 Thread Dmitry Torokhov
On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote: > On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: > > > > Hi, > > > > It looks like a whole slew of devm_request_irq() conversions just got > > applied to mainline and many of them are quite broken. > > > > Consider

Re: Dangerous devm_request_irq() conversions

2013-02-21 Thread Jingoo Han
On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: > > Hi, > > It looks like a whole slew of devm_request_irq() conversions just got > applied to mainline and many of them are quite broken. > > Consider fd5231ce336e038037b4f0190a6838bdd6e17c6d or >

Dangerous devm_request_irq() conversions

2013-02-21 Thread Dmitry Torokhov
Hi, It looks like a whole slew of devm_request_irq() conversions just got applied to mainline and many of them are quite broken. Consider fd5231ce336e038037b4f0190a6838bdd6e17c6d or c1879fe80c61f3be6f2ddb82509c2e7f92a484fe: the drivers udsed first to free IRQ and then unregister the

Dangerous devm_request_irq() conversions

2013-02-21 Thread Dmitry Torokhov
Hi, It looks like a whole slew of devm_request_irq() conversions just got applied to mainline and many of them are quite broken. Consider fd5231ce336e038037b4f0190a6838bdd6e17c6d or c1879fe80c61f3be6f2ddb82509c2e7f92a484fe: the drivers udsed first to free IRQ and then unregister the

Re: Dangerous devm_request_irq() conversions

2013-02-21 Thread Jingoo Han
On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: Hi, It looks like a whole slew of devm_request_irq() conversions just got applied to mainline and many of them are quite broken. Consider fd5231ce336e038037b4f0190a6838bdd6e17c6d or c1879fe80c61f3be6f2ddb82509c2e7f92a484fe:

Re: Dangerous devm_request_irq() conversions

2013-02-21 Thread Dmitry Torokhov
On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote: On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: Hi, It looks like a whole slew of devm_request_irq() conversions just got applied to mainline and many of them are quite broken. Consider

RE: Dangerous devm_request_irq() conversions

2013-02-21 Thread Jingoo Han
On Friday, February 22, 2013 4:27 PM, Dmitry Torokhov wrote: On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote: On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: Hi, It looks like a whole slew of devm_request_irq() conversions just got applied to mainline and