Re: Dell Vostro 3360 multimedia keys

2018-01-27 Thread Dmitry Torokhov
On Sat, Jan 27, 2018 at 6:05 AM, Pali Rohár wrote: > On Tuesday 21 November 2017 19:58:24 Oleksandr Natalenko wrote: >> >> Just to note what I did. Here is my custom /etc/udev/hwdb.d/90-dell- >> vostro-3360.hwdb: >> >> === >>

Re: Dell Vostro 3360 multimedia keys

2018-01-27 Thread Dmitry Torokhov
On Sat, Jan 27, 2018 at 6:05 AM, Pali Rohár wrote: > On Tuesday 21 November 2017 19:58:24 Oleksandr Natalenko wrote: >> >> Just to note what I did. Here is my custom /etc/udev/hwdb.d/90-dell- >> vostro-3360.hwdb: >> >> === >>

Re: Dell Vostro 3360 multimedia keys

2018-01-27 Thread Pali Rohár
On Tuesday 21 November 2017 19:58:24 Oleksandr Natalenko wrote: > Hi. > > On úterý 21. listopadu 2017 19:36:24 CET Pali Rohár wrote: > > Ok, if wmi_requires_smbios_request is really doing nothing, then it > > should not be used. It enables some QSET feature in Dell SMM mode which > > is for 2

Re: Dell Vostro 3360 multimedia keys

2018-01-27 Thread Pali Rohár
On Tuesday 21 November 2017 19:58:24 Oleksandr Natalenko wrote: > Hi. > > On úterý 21. listopadu 2017 19:36:24 CET Pali Rohár wrote: > > Ok, if wmi_requires_smbios_request is really doing nothing, then it > > should not be used. It enables some QSET feature in Dell SMM mode which > > is for 2

RE: Dell Vostro 3360 multimedia keys

2017-11-27 Thread Mario.Limonciello
Cc: pali.ro...@gmail.com; platform-driver-...@vger.kernel.org; linux- > ker...@vger.kernel.org; mj...@srcf.ucam.org; dvh...@infradead.org; > a...@infradead.org; dmitry.torok...@gmail.com > Subject: Re: Dell Vostro 3360 multimedia keys > > Hello. > > On pondělí 27. listopadu 2017

RE: Dell Vostro 3360 multimedia keys

2017-11-27 Thread Mario.Limonciello
..@vger.kernel.org; linux- > ker...@vger.kernel.org; mj...@srcf.ucam.org; dvh...@infradead.org; > a...@infradead.org; dmitry.torok...@gmail.com > Subject: Re: Dell Vostro 3360 multimedia keys > > Hello. > > On pondělí 27. listopadu 2017 17:56:07 CET mario.limoncie...@dell.

Re: Dell Vostro 3360 multimedia keys

2017-11-27 Thread Oleksandr Natalenko
Hello. On pondělí 27. listopadu 2017 17:56:07 CET mario.limoncie...@dell.com wrote: > > /* snip */ > > Looks like that Dell Vostro 3360 have this meaning for multimedia keys: > > > > first key: Mobility Center > > second key: Dell Support Center > > third key: Dell Instant Launch Manager > > >

Re: Dell Vostro 3360 multimedia keys

2017-11-27 Thread Oleksandr Natalenko
Hello. On pondělí 27. listopadu 2017 17:56:07 CET mario.limoncie...@dell.com wrote: > > /* snip */ > > Looks like that Dell Vostro 3360 have this meaning for multimedia keys: > > > > first key: Mobility Center > > second key: Dell Support Center > > third key: Dell Instant Launch Manager > > >

RE: Dell Vostro 3360 multimedia keys

2017-11-27 Thread Mario.Limonciello
@vger.kernel.org; linux-kernel@vger.kernel.org; Matthew Garrett > <mj...@srcf.ucam.org>; Darren Hart <dvh...@infradead.org>; Andy Shevchenko > <a...@infradead.org>; Dmitry Torokhov <dmitry.torok...@gmail.com> > Subject: Re: Dell Vostro 3360 multimedia keys > > Hi! >

RE: Dell Vostro 3360 multimedia keys

2017-11-27 Thread Mario.Limonciello
art ; Andy Shevchenko > ; Dmitry Torokhov > Subject: Re: Dell Vostro 3360 multimedia keys > > Hi! > > On Tuesday 21 November 2017 15:52:28 Oleksandr Natalenko wrote: > > Hi, Pali et al. > > > > Answers go inline. > > > > On úterý 21. listopadu 2017

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Oleksandr Natalenko
Hi. On úterý 21. listopadu 2017 19:36:24 CET Pali Rohár wrote: > Ok, if wmi_requires_smbios_request is really doing nothing, then it > should not be used. It enables some QSET feature in Dell SMM mode which > is for 2 laptops. It is also used to filter 0xe025 key code which is generated by 3rd

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Oleksandr Natalenko
Hi. On úterý 21. listopadu 2017 19:36:24 CET Pali Rohár wrote: > Ok, if wmi_requires_smbios_request is really doing nothing, then it > should not be used. It enables some QSET feature in Dell SMM mode which > is for 2 laptops. It is also used to filter 0xe025 key code which is generated by 3rd

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Pali Rohár
Hi! On Tuesday 21 November 2017 15:52:28 Oleksandr Natalenko wrote: > Hi, Pali et al. > > Answers go inline. > > On úterý 21. listopadu 2017 14:51:10 CET Pali Rohár wrote: > > What would happen if you enable wmi_requires_smbios_request? > > Nothing? And situation is exactly same? > > Yes, this

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Pali Rohár
Hi! On Tuesday 21 November 2017 15:52:28 Oleksandr Natalenko wrote: > Hi, Pali et al. > > Answers go inline. > > On úterý 21. listopadu 2017 14:51:10 CET Pali Rohár wrote: > > What would happen if you enable wmi_requires_smbios_request? > > Nothing? And situation is exactly same? > > Yes, this

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Oleksandr Natalenko
Hi, Pali et al. Answers go inline. On úterý 21. listopadu 2017 14:51:10 CET Pali Rohár wrote: > What would happen if you enable wmi_requires_smbios_request? Nothing? > And situation is exactly same? Yes, this is what I did with DMI quirk which enables wmi_requires_smbios_request. Keys "1" and

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Oleksandr Natalenko
Hi, Pali et al. Answers go inline. On úterý 21. listopadu 2017 14:51:10 CET Pali Rohár wrote: > What would happen if you enable wmi_requires_smbios_request? Nothing? > And situation is exactly same? Yes, this is what I did with DMI quirk which enables wmi_requires_smbios_request. Keys "1" and

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Oleksandr Natalenko
Hi, Pali et al. Answers go inline. On úterý 21. listopadu 2017 14:51:10 CET Pali Rohár wrote: > What would happen if you enable wmi_requires_smbios_request? Nothing? > And situation is exactly same? Yes, this is what I did with DMI quirk which enables wmi_requires_smbios_request. Keys "1" and

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Oleksandr Natalenko
Hi, Pali et al. Answers go inline. On úterý 21. listopadu 2017 14:51:10 CET Pali Rohár wrote: > What would happen if you enable wmi_requires_smbios_request? Nothing? > And situation is exactly same? Yes, this is what I did with DMI quirk which enables wmi_requires_smbios_request. Keys "1" and

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Pali Rohár
Hi! What would happen if you enable wmi_requires_smbios_request? Nothing? And situation is exactly same? Mario, can you comment why Dell Vostro 3360 generates same WMI keycode event for two different keys and distinguish key via third value in WMI buffer? Looks like this is first Dell machine

Re: Dell Vostro 3360 multimedia keys

2017-11-21 Thread Pali Rohár
Hi! What would happen if you enable wmi_requires_smbios_request? Nothing? And situation is exactly same? Mario, can you comment why Dell Vostro 3360 generates same WMI keycode event for two different keys and distinguish key via third value in WMI buffer? Looks like this is first Dell machine

Re: Dell Vostro 3360 multimedia keys

2017-11-20 Thread Oleksandr Natalenko
Hi, Pali et al. Thanks for the detailed explanation. I've managed to craft the following ugly hack: (I explain my thoughts on it under the snippet) === commit a2baeaba1657a47359efea61865aa012da509e03 Author: Oleksandr Natalenko Date: Mon Nov 20 13:25:43 2017 +0100

Re: Dell Vostro 3360 multimedia keys

2017-11-20 Thread Oleksandr Natalenko
Hi, Pali et al. Thanks for the detailed explanation. I've managed to craft the following ugly hack: (I explain my thoughts on it under the snippet) === commit a2baeaba1657a47359efea61865aa012da509e03 Author: Oleksandr Natalenko Date: Mon Nov 20 13:25:43 2017 +0100 dell-wmi: support

Re: Dell Vostro 3360 multimedia keys

2017-11-20 Thread Pali Rohár
Hi! On Monday 20 November 2017 16:08:41 Oleksandr Natalenko wrote: > Hi. > > I've got Dell Vostro 3360 with extra multimedia keys as shown here [1], but > have no luck to get them working. > > I've modified dell_wmi_smbios_list structure in drivers/platform/x86/dell- > wmi.c adding new entry:

Re: Dell Vostro 3360 multimedia keys

2017-11-20 Thread Pali Rohár
Hi! On Monday 20 November 2017 16:08:41 Oleksandr Natalenko wrote: > Hi. > > I've got Dell Vostro 3360 with extra multimedia keys as shown here [1], but > have no luck to get them working. > > I've modified dell_wmi_smbios_list structure in drivers/platform/x86/dell- > wmi.c adding new entry:

Dell Vostro 3360 multimedia keys

2017-11-20 Thread Oleksandr Natalenko
Hi. I've got Dell Vostro 3360 with extra multimedia keys as shown here [1], but have no luck to get them working. I've modified dell_wmi_smbios_list structure in drivers/platform/x86/dell- wmi.c adding new entry: === 84 { 85 .callback = dmi_matched, 86 .ident = "Dell

Dell Vostro 3360 multimedia keys

2017-11-20 Thread Oleksandr Natalenko
Hi. I've got Dell Vostro 3360 with extra multimedia keys as shown here [1], but have no luck to get them working. I've modified dell_wmi_smbios_list structure in drivers/platform/x86/dell- wmi.c adding new entry: === 84 { 85 .callback = dmi_matched, 86 .ident = "Dell