Re: Enhancement for PLE handler in KVM

2014-03-24 Thread Raghavendra KT
On Mon, Mar 3, 2014 at 11:54 PM, Li, Bin (Bin) wrote: > Hello, all. > > The PLE handler attempts to determine an alternate vCPU to schedule. In > some cases the wrong vCPU is scheduled and performance suffers. > > This patch allows for the guest OS to signal, using a hypercall, that it's > starti

Re: Enhancement for PLE handler in KVM

2014-03-12 Thread Li, Bin (Bin)
Thanks, Paolo for the comments Understand the requirement to "fix it for all guest OSes". I will investigate the "new hypercall KVM_HC_HALT_AND_YIELD_TO_CPU that takes an APIC id, donates the quantum to that CPU, and puts the originating CPU in halted state. " Regards Bin -- To unsubscribe

Re: Enhancement for PLE handler in KVM

2014-03-11 Thread Paolo Bonzini
Il 11/03/2014 15:12, Li, Bin (Bin) ha scritto: - For the guest OS which doesn't use the hyper call interface, there will be no impact to them. The proposed ple handler enhancement has structured to use the hint only if the guest OS using the new proposed hyper call. And it is per

Re: Enhancement for PLE handler in KVM

2014-03-07 Thread Marcelo Tosatti
On Fri, Mar 07, 2014 at 10:08:52PM +, Li, Bin (Bin) wrote: > Fully agree. > It will be a very helpful feature to make ple setting per VM. > This feature will provide more flexible control to the VM user. All KVM user > will love to have it. > > The enhancement we proposed is neither overlapp

RE: Enhancement for PLE handler in KVM

2014-03-07 Thread Li, Bin (Bin)
; Jatania, Neel (Neel); linux-kernel@vger.kernel.org Subject: Re: Enhancement for PLE handler in KVM On Fri, Mar 07, 2014 at 02:26:19PM +, Li, Bin (Bin) wrote: > Can we have "per-VM PLE values"? > > My understanding is that the ple values are kvm module setting which applyi

Re: Enhancement for PLE handler in KVM

2014-03-07 Thread Marcelo Tosatti
On Fri, Mar 07, 2014 at 02:26:19PM +, Li, Bin (Bin) wrote: > Can we have "per-VM PLE values"? > > My understanding is that the ple values are kvm module setting which applying > to all VMs in the system. > And all vms must be stopped first, then unload kvm-intel, reload kvm-intel > with new

RE: Enhancement for PLE handler in KVM

2014-03-07 Thread Li, Bin (Bin)
ris Wright; ttr...@redhat.com; Nakajima, Jun; r...@redhat.com Subject: Re: Enhancement for PLE handler in KVM On Wed, Mar 05, 2014 at 09:16:45PM +, Li, Bin (Bin) wrote: > Did you also find out here why this is the case? > > Binl: > Yes. The application running in our customized em

Re: Enhancement for PLE handler in KVM

2014-03-06 Thread Marcelo Tosatti
On Wed, Mar 05, 2014 at 09:16:45PM +, Li, Bin (Bin) wrote: > Did you also find out here why this is the case? > > Binl: > Yes. The application running in our customized embedded OS is also real time > application which is timing sensitive. > The timing sensitive level varies among the applic

RE: Enhancement for PLE handler in KVM

2014-03-05 Thread Li, Bin (Bin)
@vger.kernel.org; Srivatsa Vaddagiri; Peter Zijlstra; Mike Galbraith; Chris Wright; ttr...@redhat.com; Nakajima, Jun; r...@redhat.com Subject: Re: Enhancement for PLE handler in KVM Il 05/03/2014 15:17, Li, Bin (Bin) ha scritto: > Hello, Paolo, > > We are using a customized embedded SMP OS

Re: Enhancement for PLE handler in KVM

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 15:17, Li, Bin (Bin) ha scritto: Hello, Paolo, We are using a customized embedded SMP OS as guest OS. It is not meaningful to post the guest OS code. Also, there is no "performance numbers for common workloads" since there is no common workloads to compare with. In our OS, there

RE: Enhancement for PLE handler in KVM

2014-03-05 Thread Li, Bin (Bin)
nzini Sent: Monday, March 03, 2014 2:21 PM To: Li, Bin (Bin); k...@vger.kernel.org Cc: Jatania, Neel (Neel); linux-kernel@vger.kernel.org; Avi Kiviti; Srivatsa Vaddagiri; Peter Zijlstra; Mike Galbraith; Chris Wright; ttr...@redhat.com; Nakajima, Jun; r...@redhat.com Subject: Re: Enhancement for PLE handler in K

Re: Enhancement for PLE handler in KVM

2014-03-03 Thread Paolo Bonzini
Il 03/03/2014 19:24, Li, Bin (Bin) ha scritto: Hello, all. The PLE handler attempts to determine an alternate vCPU to schedule. In some cases the wrong vCPU is scheduled and performance suffers. This patch allows for the guest OS to signal, using a hypercall, that it's starting/ending a critic

Enhancement for PLE handler in KVM

2014-03-03 Thread Li, Bin (Bin)
Hello, all. The PLE handler attempts to determine an alternate vCPU to schedule. In some cases the wrong vCPU is scheduled and performance suffers. This patch allows for the guest OS to signal, using a hypercall, that it's starting/ending a critical section. Using this information in the P