Re: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch

2018-12-22 Thread Sasha Levin
On Fri, Dec 21, 2018 at 10:43:09PM +, Greensky, James J wrote: This commit does not apply cleanly due to other changes. Is there something I can do to make it easier. This line: If (data->is_pipe) { Must be changed to: If (file->is_pipe) { Indeed, I've resolved it the

Re: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch

2018-12-21 Thread Sasha Levin
On Fri, Dec 21, 2018 at 11:57:53AM +0100, Jinpu Wang wrote: +cc Greg, stable Greensky, James J 于2018年12月21日周五 上午11:48写道: Commit d38d272592737ea88a20 ("perf tools: Synthesize GROUP_DESC feature in pipe mode") broke the LT 4.14 branch when using event groups in pipe-mode. # perf record -e

RE: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch

2018-12-21 Thread Greensky, James J
lusion. -Original Message- From: Jinpu Wang [mailto:jinpuw...@gmail.com] Sent: Friday, December 21, 2018 2:58 AM To: Greensky, James J ; Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org; v3.14+, only the raid10 part Subject: Re: Fix "perf tools: Synthesize GROUP_DESC feature i

Re: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch

2018-12-21 Thread Jinpu Wang
+cc Greg, stable Greensky, James J 于2018年12月21日周五 上午11:48写道: > > Commit d38d272592737ea88a20 ("perf tools: Synthesize GROUP_DESC feature in > pipe mode") broke the LT 4.14 branch when using event groups in pipe-mode. > > # perf record -e '{cycles,instructions,branches}' -- sleep 4 | perf

Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch

2018-12-20 Thread Greensky, James J
Commit d38d272592737ea88a20 ("perf tools: Synthesize GROUP_DESC feature in pipe mode") broke the LT 4.14 branch when using event groups in pipe-mode. # perf record -e '{cycles,instructions,branches}' -- sleep 4 | perf report # To display the perf.data header info, please use