Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Srinidhi Kasagar
On Thu, Nov 15, 2012 at 11:18:20 +0100, Wolfram Sang wrote: > On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote: > > On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote: > > > > > > > > - if (timeout < 0) { > > > > > - dev_err(>adev->dev, > > > > > -

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Wolfram Sang
On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote: > On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote: > > > > > > - if (timeout < 0) { > > > > - dev_err(>adev->dev, > > > > - "wait_for_completion_timeout " > > > > -

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Srinidhi Kasagar
On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote: > > > > - if (timeout < 0) { > > > - dev_err(>adev->dev, > > > - "wait_for_completion_timeout " > > > - "returned %d waiting for event\n", timeout); > > > -

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Wolfram Sang
> > - if (timeout < 0) { > > - dev_err(>adev->dev, > > - "wait_for_completion_timeout " > > - "returned %d waiting for event\n", timeout); > > - status = timeout; > > - } > > - > No, it is wrong. You need to

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Srinidhi Kasagar
[...] > From: Chuansheng Liu > Date: Tue, Nov 6, 2012 at 6:18 PM > Subject: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout > To: linus.wall...@linaro.org, w.s...@pengutronix.de > Cc: linux-arm-ker...@lists.infradead.org, > linux-kernel@vger.kernel.org,

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Srinidhi Kasagar
[...] From: Chuansheng Liu chuansheng@intel.com Date: Tue, Nov 6, 2012 at 6:18 PM Subject: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout To: linus.wall...@linaro.org, w.s...@pengutronix.de Cc: linux-arm-ker...@lists.infradead.org, linux-kernel@vger.kernel.org,

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Wolfram Sang
- if (timeout 0) { - dev_err(dev-adev-dev, - wait_for_completion_timeout - returned %d waiting for event\n, timeout); - status = timeout; - } - No, it is wrong. You need to update the status

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Srinidhi Kasagar
On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote: - if (timeout 0) { - dev_err(dev-adev-dev, - wait_for_completion_timeout - returned %d waiting for event\n, timeout); - status = timeout;

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Wolfram Sang
On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote: On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote: - if (timeout 0) { - dev_err(dev-adev-dev, - wait_for_completion_timeout - returned %d

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Srinidhi Kasagar
On Thu, Nov 15, 2012 at 11:18:20 +0100, Wolfram Sang wrote: On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote: On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote: - if (timeout 0) { - dev_err(dev-adev-dev, -