Re: Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-04 Thread yalin wang
2015-06-03 13:20 GMT+08:00 Tejun Heo : > On Tue, Jun 02, 2015 at 11:13:44AM +0800, yalin wang wrote: >> this means i need create kthread like this : >> >> struct task_struct *kworker_task = kthread_run(kthread_worker_fn, >> , "nvme%d", dev->instance); >> kworker_task->flags &= ~PF_NOFREEZE; >> is

Re: Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-04 Thread yalin wang
2015-06-03 13:20 GMT+08:00 Tejun Heo t...@kernel.org: On Tue, Jun 02, 2015 at 11:13:44AM +0800, yalin wang wrote: this means i need create kthread like this : struct task_struct *kworker_task = kthread_run(kthread_worker_fn, worker, nvme%d, dev-instance); kworker_task-flags = ~PF_NOFREEZE;

Re: Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-02 Thread Tejun Heo
On Tue, Jun 02, 2015 at 11:13:44AM +0800, yalin wang wrote: > this means i need create kthread like this : > > struct task_struct *kworker_task = kthread_run(kthread_worker_fn, > , "nvme%d", dev->instance); > kworker_task->flags &= ~PF_NOFREEZE; > is it safe to do like this ? It's not. > i

Re: Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-02 Thread Tejun Heo
On Tue, Jun 02, 2015 at 11:13:44AM +0800, yalin wang wrote: this means i need create kthread like this : struct task_struct *kworker_task = kthread_run(kthread_worker_fn, worker, nvme%d, dev-instance); kworker_task-flags = ~PF_NOFREEZE; is it safe to do like this ? It's not. i don't see

Re: Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-01 Thread yalin wang
2015-06-01 19:40 GMT+08:00 Tejun Heo : > Hello, > > On Mon, Jun 01, 2015 at 06:05:58PM +0800, yalin wang wrote: >> I notice that kthread_worker_fn() call try_to_freeze() function, >> but it don't make itself to be a freezable kthread, >> kthread default behavior is not freezable, we should change

Re: Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-01 Thread Tejun Heo
Hello, On Mon, Jun 01, 2015 at 06:05:58PM +0800, yalin wang wrote: > I notice that kthread_worker_fn() call try_to_freeze() function, > but it don't make itself to be a freezable kthread, > kthread default behavior is not freezable, we should change it if > want try_to_freeze() work correctly. >

Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-01 Thread yalin wang
I notice that kthread_worker_fn() call try_to_freeze() function, but it don't make itself to be a freezable kthread, kthread default behavior is not freezable, we should change it if want try_to_freeze() work correctly. Signed-off-by: yalin wang --- kernel/kthread.c | 1 + 1 file changed, 1

Re: Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-01 Thread Tejun Heo
Hello, On Mon, Jun 01, 2015 at 06:05:58PM +0800, yalin wang wrote: I notice that kthread_worker_fn() call try_to_freeze() function, but it don't make itself to be a freezable kthread, kthread default behavior is not freezable, we should change it if want try_to_freeze() work correctly.

Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-01 Thread yalin wang
I notice that kthread_worker_fn() call try_to_freeze() function, but it don't make itself to be a freezable kthread, kthread default behavior is not freezable, we should change it if want try_to_freeze() work correctly. Signed-off-by: yalin wang yalin.wang2...@gmail.com --- kernel/kthread.c | 1

Re: Fwd: [RFC] make kthread_worker_fn to be freezable

2015-06-01 Thread yalin wang
2015-06-01 19:40 GMT+08:00 Tejun Heo t...@kernel.org: Hello, On Mon, Jun 01, 2015 at 06:05:58PM +0800, yalin wang wrote: I notice that kthread_worker_fn() call try_to_freeze() function, but it don't make itself to be a freezable kthread, kthread default behavior is not freezable, we should