Re: How should dev_[gs]et_drvdata be used?

2014-11-28 Thread Uwe Kleine-König
Hi Jean, On Fri, Nov 28, 2014 at 02:48:13PM +0100, Jean Delvare wrote: > On Tue, 25 Nov 2014 22:14:32 +0100, Uwe Kleine-König wrote: > > On Wed, Jan 08, 2014 at 02:28:49PM +0100, Jean Delvare wrote: > > > Having looked at the code in deeper detail, I think I understand what > > > is going on. The

Re: How should dev_[gs]et_drvdata be used?

2014-11-28 Thread Jean Delvare
Hi Uwe, On Tue, 25 Nov 2014 22:14:32 +0100, Uwe Kleine-König wrote: > On Wed, Jan 08, 2014 at 02:28:49PM +0100, Jean Delvare wrote: > > Having looked at the code in deeper detail, I think I understand what > > is going on. The problem is with: > > > > i2c_set_adapdata(>adapter, priv); > > >

Re: How should dev_[gs]et_drvdata be used?

2014-11-28 Thread Jean Delvare
Hi Uwe, On Tue, 25 Nov 2014 22:14:32 +0100, Uwe Kleine-König wrote: On Wed, Jan 08, 2014 at 02:28:49PM +0100, Jean Delvare wrote: Having looked at the code in deeper detail, I think I understand what is going on. The problem is with: i2c_set_adapdata(priv-adapter, priv); at the

Re: How should dev_[gs]et_drvdata be used?

2014-11-28 Thread Uwe Kleine-König
Hi Jean, On Fri, Nov 28, 2014 at 02:48:13PM +0100, Jean Delvare wrote: On Tue, 25 Nov 2014 22:14:32 +0100, Uwe Kleine-König wrote: On Wed, Jan 08, 2014 at 02:28:49PM +0100, Jean Delvare wrote: Having looked at the code in deeper detail, I think I understand what is going on. The problem

Re: How should dev_[gs]et_drvdata be used?

2014-11-25 Thread Uwe Kleine-König
Hello Jean, [not stripping the quotes as the thread is already old] On Wed, Jan 08, 2014 at 02:28:49PM +0100, Jean Delvare wrote: > On Tue, 24 Dec 2013 01:18:03 +0100, Peter Wu wrote: > > On Monday 23 December 2013 10:37:21 Alex Williamson wrote: > > > On Mon, 2013-12-23 at 16:49 +0100, Peter Wu

Re: How should dev_[gs]et_drvdata be used?

2014-11-25 Thread Uwe Kleine-König
Hello Jean, [not stripping the quotes as the thread is already old] On Wed, Jan 08, 2014 at 02:28:49PM +0100, Jean Delvare wrote: On Tue, 24 Dec 2013 01:18:03 +0100, Peter Wu wrote: On Monday 23 December 2013 10:37:21 Alex Williamson wrote: On Mon, 2013-12-23 at 16:49 +0100, Peter Wu

Re: How should dev_[gs]et_drvdata be used?

2014-01-08 Thread Jean Delvare
On Tue, 24 Dec 2013 01:18:03 +0100, Peter Wu wrote: > On Monday 23 December 2013 10:37:21 Alex Williamson wrote: > > On Mon, 2013-12-23 at 16:49 +0100, Peter Wu wrote: > [..] > > > > > > There is still one thing I do not fully understand, how should > > > dev_set_drvdata and dev_get_drvdata be

Re: How should dev_[gs]et_drvdata be used?

2014-01-08 Thread Jean Delvare
On Tue, 24 Dec 2013 01:18:03 +0100, Peter Wu wrote: On Monday 23 December 2013 10:37:21 Alex Williamson wrote: On Mon, 2013-12-23 at 16:49 +0100, Peter Wu wrote: [..] There is still one thing I do not fully understand, how should dev_set_drvdata and dev_get_drvdata be used? For the

Re: How should dev_[gs]et_drvdata be used?

2013-12-24 Thread Peter Wu
On Monday 23 December 2013 18:51:09 Alex Williamson wrote: > > It does: > > > > int device_private_init(struct device *dev) > > { > > dev->p = kzalloc(sizeof(*dev->p), GFP_KERNEL); > > if (!dev->p) > > return -ENOMEM; > > dev->p->device = dev; > >

Re: How should dev_[gs]et_drvdata be used?

2013-12-24 Thread Peter Wu
On Monday 23 December 2013 18:51:09 Alex Williamson wrote: It does: int device_private_init(struct device *dev) { dev-p = kzalloc(sizeof(*dev-p), GFP_KERNEL); if (!dev-p) return -ENOMEM; dev-p-device = dev;

Re: How should dev_[gs]et_drvdata be used?

2013-12-23 Thread Alex Williamson
On Tue, 2013-12-24 at 01:18 +0100, Peter Wu wrote: > On Monday 23 December 2013 10:37:21 Alex Williamson wrote: > > On Mon, 2013-12-23 at 16:49 +0100, Peter Wu wrote: > [..] > > > > > > There is still one thing I do not fully understand, how should > > > dev_set_drvdata and dev_get_drvdata be

Re: How should dev_[gs]et_drvdata be used?

2013-12-23 Thread Peter Wu
On Monday 23 December 2013 10:37:21 Alex Williamson wrote: > On Mon, 2013-12-23 at 16:49 +0100, Peter Wu wrote: [..] > > > > There is still one thing I do not fully understand, how should > > dev_set_drvdata and dev_get_drvdata be used? For the devices passed > > to probe functions, the core

Re: How should dev_[gs]et_drvdata be used? (was: Re: [PATCH] i2c: i801: fix memleak on probe error)

2013-12-23 Thread Alex Williamson
On Mon, 2013-12-23 at 16:49 +0100, Peter Wu wrote: > On Monday 23 December 2013 11:51:12 Martin Mokrejs wrote: > > Thanks for the note, was just compiling a new 3.10.24 kernel to test it. > > ;-) > > > > So far just booted an old 3.9 kernel and after plugging in an external > > USB3 drive I got

How should dev_[gs]et_drvdata be used? (was: Re: [PATCH] i2c: i801: fix memleak on probe error)

2013-12-23 Thread Peter Wu
On Monday 23 December 2013 11:51:12 Martin Mokrejs wrote: > Thanks for the note, was just compiling a new 3.10.24 kernel to test it. > ;-) > > So far just booted an old 3.9 kernel and after plugging in an external > USB3 drive I got the message, just to be sure I am still able to reproduce > the

How should dev_[gs]et_drvdata be used? (was: Re: [PATCH] i2c: i801: fix memleak on probe error)

2013-12-23 Thread Peter Wu
On Monday 23 December 2013 11:51:12 Martin Mokrejs wrote: Thanks for the note, was just compiling a new 3.10.24 kernel to test it. ;-) So far just booted an old 3.9 kernel and after plugging in an external USB3 drive I got the message, just to be sure I am still able to reproduce the error

Re: How should dev_[gs]et_drvdata be used? (was: Re: [PATCH] i2c: i801: fix memleak on probe error)

2013-12-23 Thread Alex Williamson
On Mon, 2013-12-23 at 16:49 +0100, Peter Wu wrote: On Monday 23 December 2013 11:51:12 Martin Mokrejs wrote: Thanks for the note, was just compiling a new 3.10.24 kernel to test it. ;-) So far just booted an old 3.9 kernel and after plugging in an external USB3 drive I got the message,

Re: How should dev_[gs]et_drvdata be used?

2013-12-23 Thread Peter Wu
On Monday 23 December 2013 10:37:21 Alex Williamson wrote: On Mon, 2013-12-23 at 16:49 +0100, Peter Wu wrote: [..] There is still one thing I do not fully understand, how should dev_set_drvdata and dev_get_drvdata be used? For the devices passed to probe functions, the core takes care of

Re: How should dev_[gs]et_drvdata be used?

2013-12-23 Thread Alex Williamson
On Tue, 2013-12-24 at 01:18 +0100, Peter Wu wrote: On Monday 23 December 2013 10:37:21 Alex Williamson wrote: On Mon, 2013-12-23 at 16:49 +0100, Peter Wu wrote: [..] There is still one thing I do not fully understand, how should dev_set_drvdata and dev_get_drvdata be used? For the