Re: In "pci_fixup_video" check if this is or should be the primary video devi

2014-01-29 Thread Bjorn Helgaas
On Wed, Jan 15, 2014 at 11:25:28PM +0100, Sander Eikelenboom wrote: > Date: Sun, 12 Jan 2014 04:49:44 +0100 > Subject: [PATCH] In "pci_fixup_video" check if this is or should be the > primary video device to prevent setting the > IORESOURCE_ROM_SHADOW flag on a secondary VGA card > To: Dave

Re: In pci_fixup_video check if this is or should be the primary video devi

2014-01-29 Thread Bjorn Helgaas
On Wed, Jan 15, 2014 at 11:25:28PM +0100, Sander Eikelenboom wrote: Date: Sun, 12 Jan 2014 04:49:44 +0100 Subject: [PATCH] In pci_fixup_video check if this is or should be the primary video device to prevent setting the IORESOURCE_ROM_SHADOW flag on a secondary VGA card To: Dave Airlie

Re: In "pci_fixup_video" check if this is or should be the primary video devi

2014-01-15 Thread Sander Eikelenboom
Wednesday, January 15, 2014, 10:50:09 PM, you wrote: > On Wed, Jan 15, 2014 at 12:36 PM, Sander Eikelenboom > wrote: >> ... >> And that's just what my patch does .. >> >> + if (!vga_default_device() || pdev == vga_default_device()) { >> >> If we don't know the vga_default_device ...

Re: In "pci_fixup_video" check if this is or should be the primary video devi

2014-01-15 Thread Bjorn Helgaas
On Wed, Jan 15, 2014 at 12:36 PM, Sander Eikelenboom wrote: > ... > And that's just what my patch does .. > > + if (!vga_default_device() || pdev == vga_default_device()) { > > If we don't know the vga_default_device ... because we don't have that > knowlegde > or > if this is actually the

Re: In "pci_fixup_video" check if this is or should be the primary video devi

2014-01-15 Thread Sander Eikelenboom
Wednesday, January 15, 2014, 5:55:38 AM, you wrote: > Hi Sander, > I understood there is no bridge for a VGA device in your virtual machine. > Your emulator for the bridge control register is odd. > I guess your virtual machine ignore "PCI-to-PCI Bridge Architecture > Specification". All the

Re: In "pci_fixup_video" check if this is or should be the primary video devi

2014-01-15 Thread Sander Eikelenboom
Wednesday, January 15, 2014, 5:55:38 AM, you wrote: Ok, i will see what the Qemu guys have to say about it, the emulator is the latest Qemu, but they will probably say .. hey go fix that fixup in the kernel. -- Sander > Hi Sander, > I understood there is no bridge for a VGA device in your

Re: In pci_fixup_video check if this is or should be the primary video devi

2014-01-15 Thread Sander Eikelenboom
Wednesday, January 15, 2014, 5:55:38 AM, you wrote: Ok, i will see what the Qemu guys have to say about it, the emulator is the latest Qemu, but they will probably say .. hey go fix that fixup in the kernel. -- Sander Hi Sander, I understood there is no bridge for a VGA device in your

Re: In pci_fixup_video check if this is or should be the primary video devi

2014-01-15 Thread Sander Eikelenboom
Wednesday, January 15, 2014, 5:55:38 AM, you wrote: Hi Sander, I understood there is no bridge for a VGA device in your virtual machine. Your emulator for the bridge control register is odd. I guess your virtual machine ignore PCI-to-PCI Bridge Architecture Specification. All the devices

Re: In pci_fixup_video check if this is or should be the primary video devi

2014-01-15 Thread Bjorn Helgaas
On Wed, Jan 15, 2014 at 12:36 PM, Sander Eikelenboom li...@eikelenboom.it wrote: ... And that's just what my patch does .. + if (!vga_default_device() || pdev == vga_default_device()) { If we don't know the vga_default_device ... because we don't have that knowlegde or if this is

Re: In pci_fixup_video check if this is or should be the primary video devi

2014-01-15 Thread Sander Eikelenboom
Wednesday, January 15, 2014, 10:50:09 PM, you wrote: On Wed, Jan 15, 2014 at 12:36 PM, Sander Eikelenboom li...@eikelenboom.it wrote: ... And that's just what my patch does .. + if (!vga_default_device() || pdev == vga_default_device()) { If we don't know the vga_default_device ...