Re: Indent issus in kernel module development

2015-12-21 Thread Austin S. Hemmelgarn
On 2015-12-20 07:52, chunguang qu wrote: I tried it. Not worked unfortunately,. ```bash $ ~/share/linux/scripts/checkpatch.pl --fix --types=spacing testcompletion.c total: 0 errors, 0 warnings, 0 lines checked testcompletion.c has no obvious style problems and is ready for submission. NOTE:

Re: Indent issus in kernel module development

2015-12-21 Thread Austin S. Hemmelgarn
On 2015-12-20 07:52, chunguang qu wrote: I tried it. Not worked unfortunately,. ```bash $ ~/share/linux/scripts/checkpatch.pl --fix --types=spacing testcompletion.c total: 0 errors, 0 warnings, 0 lines checked testcompletion.c has no obvious style problems and is ready for submission. NOTE:

Re: Indent issus in kernel module development

2015-12-20 Thread chunguang qu
I tried it. Not worked unfortunately,. ```bash $ ~/share/linux/scripts/checkpatch.pl --fix --types=spacing testcompletion.c total: 0 errors, 0 warnings, 0 lines checked testcompletion.c has no obvious style problems and is ready for submission. NOTE: Used message types: SPACING ``` 2015-12-19

Re: Indent issus in kernel module development

2015-12-20 Thread chunguang qu
I tried it. Not worked unfortunately,. ```bash $ ~/share/linux/scripts/checkpatch.pl --fix --types=spacing testcompletion.c total: 0 errors, 0 warnings, 0 lines checked testcompletion.c has no obvious style problems and is ready for submission. NOTE: Used message types: SPACING ``` 2015-12-19

Re: Indent issus in kernel module development

2015-12-18 Thread Joe Perches
On Sat, 2015-12-19 at 13:50 +0800, chunguang qu wrote: > Yes, I just tried `scripts/Lindent` and it has the same problem. > > I had compared the source of `Lindent` with `-linux` option of > `indent` long time ago, there's seems no major difference. > So i used `indent -linux ` above. > > Thanks

Re: Indent issus in kernel module development

2015-12-18 Thread chunguang qu
Yes, I just tried `scripts/Lindent` and it has the same problem. I had compared the source of `Lindent` with `-linux` option of `indent` long time ago, there's seems no major difference. So i used `indent -linux ` above. Thanks for your advice about `emace`, but `vi` is my only editor for dozens

Re: Indent issus in kernel module development

2015-12-18 Thread Randy Dunlap
On 12/18/15 18:07, chunguang qu wrote: > `indent -linux` sometimes made my code totally a mess. > I know it most likely a bug of GNU INDENT. And this is not a bug report. > I only want to know other kernel developers how to deal with this problem. > Since GUN INDENT is recommend in kernel's

Indent issus in kernel module development

2015-12-18 Thread chunguang qu
`indent -linux` sometimes made my code totally a mess. I know it most likely a bug of GNU INDENT. And this is not a bug report. I only want to know other kernel developers how to deal with this problem. Since GUN INDENT is recommend in kernel's CodingStyle, I think surely someone here encounter

Indent issus in kernel module development

2015-12-18 Thread chunguang qu
`indent -linux` sometimes made my code totally a mess. I know it most likely a bug of GNU INDENT. And this is not a bug report. I only want to know other kernel developers how to deal with this problem. Since GUN INDENT is recommend in kernel's CodingStyle, I think surely someone here encounter

Re: Indent issus in kernel module development

2015-12-18 Thread chunguang qu
Yes, I just tried `scripts/Lindent` and it has the same problem. I had compared the source of `Lindent` with `-linux` option of `indent` long time ago, there's seems no major difference. So i used `indent -linux ` above. Thanks for your advice about `emace`, but `vi` is my only editor for dozens

Re: Indent issus in kernel module development

2015-12-18 Thread Randy Dunlap
On 12/18/15 18:07, chunguang qu wrote: > `indent -linux` sometimes made my code totally a mess. > I know it most likely a bug of GNU INDENT. And this is not a bug report. > I only want to know other kernel developers how to deal with this problem. > Since GUN INDENT is recommend in kernel's

Re: Indent issus in kernel module development

2015-12-18 Thread Joe Perches
On Sat, 2015-12-19 at 13:50 +0800, chunguang qu wrote: > Yes, I just tried `scripts/Lindent` and it has the same problem. > > I had compared the source of `Lindent` with `-linux` option of > `indent` long time ago, there's seems no major difference. > So i used `indent -linux ` above. > > Thanks