Re: Input-gameport: Add the macro "pr_fmt" for module "joydump"

> When a chorus of voices says to you that you are wasting > their time, perhaps you listen to their song. I am listening to some degree. - I guess that I am making some decisions and conclusions in a way that you would prefer to be different. I know that my update suggestions won't be liked by

Re: Input-gameport: Add the macro "pr_fmt" for module "joydump"

> When a chorus of voices says to you that you are wasting > their time, perhaps you listen to their song. I am listening to some degree. - I guess that I am making some decisions and conclusions in a way that you would prefer to be different. I know that my update suggestions won't be liked by

Re: Input-gameport: Add the macro "pr_fmt" for module "joydump"

On Sat, 2016-09-24 at 19:45 +0200, SF Markus Elfring wrote: > > It's purposeless, creates unnecessary patches to review > > and generally wastes other people's time. > I have got an other opinion about this. Nice for you, not nice for others that have to act on your patch proposals to get them

Re: Input-gameport: Add the macro "pr_fmt" for module "joydump"

On Sat, 2016-09-24 at 19:45 +0200, SF Markus Elfring wrote: > > It's purposeless, creates unnecessary patches to review > > and generally wastes other people's time. > I have got an other opinion about this. Nice for you, not nice for others that have to act on your patch proposals to get them

Re: Input-gameport: Add the macro "pr_fmt" for module "joydump"

>> I find that it is a preparation. - If this addition could not be accepted, >> the following update step would also be discussed under an other perspective, >> wouldn't it? > > It's purposeless, creates unnecessary patches to review > and generally wastes other people's time. I have got an

Re: Input-gameport: Add the macro "pr_fmt" for module "joydump"

>> I find that it is a preparation. - If this addition could not be accepted, >> the following update step would also be discussed under an other perspective, >> wouldn't it? > > It's purposeless, creates unnecessary patches to review > and generally wastes other people's time. I have got an

Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

On Sat, 2016-09-24 at 18:55 +0200, SF Markus Elfring wrote: > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Why did you split it off from the patch where you attempt to use it? > I chose a special patch granularity once again. > > What good does this change do on its own? > I find that it

Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

On Sat, 2016-09-24 at 18:55 +0200, SF Markus Elfring wrote: > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Why did you split it off from the patch where you attempt to use it? > I chose a special patch granularity once again. > > What good does this change do on its own? > I find that it

Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >> + > > Why did you split it off from the patch where you attempt to use it? I chose a special patch granularity once again. > What good does this change do on its own? I find that it is a preparation. - If this addition could not be accepted,

Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >> + > > Why did you split it off from the patch where you attempt to use it? I chose a special patch granularity once again. > What good does this change do on its own? I find that it is a preparation. - If this addition could not be accepted,

Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

On Sat, Sep 24, 2016 at 03:48:54PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 14:30:44 +0200 > > Add a definition for the macro "pr_fmt" so that its information can be used > for consistent message output. > > Signed-off-by:

Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

On Sat, Sep 24, 2016 at 03:48:54PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 14:30:44 +0200 > > Add a definition for the macro "pr_fmt" so that its information can be used > for consistent message output. > > Signed-off-by: Markus Elfring > --- >

[PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

From: Markus Elfring Date: Sat, 24 Sep 2016 14:30:44 +0200 Add a definition for the macro "pr_fmt" so that its information can be used for consistent message output. Signed-off-by: Markus Elfring ---

[PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

From: Markus Elfring Date: Sat, 24 Sep 2016 14:30:44 +0200 Add a definition for the macro "pr_fmt" so that its information can be used for consistent message output. Signed-off-by: Markus Elfring --- drivers/input/joystick/joydump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git