Re: Issue of metrics for multiple uncore PMUs (was Re: [RFC PATCH v2 23/23] perf metricgroup: remove duped metric group events)

2020-10-06 Thread Ian Rogers
On Tue, Oct 6, 2020 at 7:22 AM John Garry wrote: > > On 05/10/2020 19:05, John Garry wrote: > >> Can you provide a reproduction? Looking on broadwell > >> this metric doesn't exist. > > > > Right, I just added this test metric as my 2x x86 platform has no > > examples which I can find: > > > >

Re: Issue of metrics for multiple uncore PMUs (was Re: [RFC PATCH v2 23/23] perf metricgroup: remove duped metric group events)

2020-10-06 Thread John Garry
On 05/10/2020 19:05, John Garry wrote: Can you provide a reproduction? Looking on broadwell this metric doesn't exist. Right, I just added this test metric as my 2x x86 platform has no examples which I can find: diff --git a/tools/perf/pmu-events/arch/x86/broadwell/bdw-metrics.json

Re: Issue of metrics for multiple uncore PMUs (was Re: [RFC PATCH v2 23/23] perf metricgroup: remove duped metric group events)

2020-10-05 Thread John Garry
On 05/10/2020 17:28, Ian Rogers wrote: On Mon, Oct 5, 2020 at 3:06 AM John Garry wrote: On 02/10/2020 21:46, Ian Rogers wrote: On Fri, Oct 2, 2020 at 5:00 AM John Garry wrote: On 07/05/2020 15:08, Ian Rogers wrote: Hi Ian, I was wondering if you ever tested commit 2440689d62e9 ("perf

Re: Issue of metrics for multiple uncore PMUs (was Re: [RFC PATCH v2 23/23] perf metricgroup: remove duped metric group events)

2020-10-05 Thread Ian Rogers
On Mon, Oct 5, 2020 at 3:06 AM John Garry wrote: > > On 02/10/2020 21:46, Ian Rogers wrote: > > On Fri, Oct 2, 2020 at 5:00 AM John Garry wrote: > >> > >> On 07/05/2020 15:08, Ian Rogers wrote: > >> > >> Hi Ian, > >> > >> I was wondering if you ever tested commit 2440689d62e9 ("perf > >>

Re: Issue of metrics for multiple uncore PMUs (was Re: [RFC PATCH v2 23/23] perf metricgroup: remove duped metric group events)

2020-10-05 Thread John Garry
On 02/10/2020 21:46, Ian Rogers wrote: On Fri, Oct 2, 2020 at 5:00 AM John Garry wrote: On 07/05/2020 15:08, Ian Rogers wrote: Hi Ian, I was wondering if you ever tested commit 2440689d62e9 ("perf metricgroup: Remove duped metric group events") for when we have a metric which aliases

Re: Issue of metrics for multiple uncore PMUs (was Re: [RFC PATCH v2 23/23] perf metricgroup: remove duped metric group events)

2020-10-02 Thread Ian Rogers
On Fri, Oct 2, 2020 at 5:00 AM John Garry wrote: > > On 07/05/2020 15:08, Ian Rogers wrote: > > Hi Ian, > > I was wondering if you ever tested commit 2440689d62e9 ("perf > metricgroup: Remove duped metric group events") for when we have a > metric which aliases multiple instances of the same

Issue of metrics for multiple uncore PMUs (was Re: [RFC PATCH v2 23/23] perf metricgroup: remove duped metric group events)

2020-10-02 Thread John Garry
On 07/05/2020 15:08, Ian Rogers wrote: Hi Ian, I was wondering if you ever tested commit 2440689d62e9 ("perf metricgroup: Remove duped metric group events") for when we have a metric which aliases multiple instances of the same uncore PMU in the system? I have been rebasing some of my