Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Chao Yu
On 2020-9-26 0:45, Eric Biggers wrote: On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote: On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: Hi, I don't see any problem here, thanks for your report. :) Thanks, What about if max_depth == 0 in __f2fs_find_entry()? Then

Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Eric Biggers
On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote: > On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: > > Hi, > > > > I don't see any problem here, thanks for your report. :) > > > > Thanks, > > What about if max_depth == 0 in __f2fs_find_entry()? Then __f2fs_find_entry() >

Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Eric Biggers
On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: > Hi, > > I don't see any problem here, thanks for your report. :) > > Thanks, What about if max_depth == 0 in __f2fs_find_entry()? Then __f2fs_find_entry() would return NULL without initializing *res_page. A fix could be: diff --git

Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Chao Yu
Hi Dan, On 2020-9-25 18:57, Dan Carpenter wrote: On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: Hi, I don't see any problem here, thanks for your report. :) I bet the uninitialize value is because "max_depth" is zero. I agree with you, thanks for the hint. :) Thanks,

Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Dan Carpenter
On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: > Hi, > > I don't see any problem here, thanks for your report. :) > I bet the uninitialize value is because "max_depth" is zero. 352 struct f2fs_dir_entry *__f2fs_find_entry(struct inode *dir, 353

Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Chao Yu
: KMSAN: uninit-value in f2fs_lookup+0xe05/0x1a80 fs/f2fs/namei.c:503 CPU: 0 PID: 20216 Comm: syz-executor.5 Not tainted 5.9.0-rc4-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack

KMSAN: uninit-value in f2fs_lookup

2020-09-24 Thread syzbot
: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+0eac6f0bbd558fd86...@syzkaller.appspotmail.com = BUG: KMSAN: uninit-value in f2fs_lookup+0xe05/0x1a80 fs/f2fs/namei.c:503 CPU: 0 PID: 20216 Comm: syz-executor.5