Re: MAP_FIXED_NOREPLACE appears to break older i386 binaries

2019-10-06 Thread Kees Cook
On Sun, Oct 06, 2019 at 02:14:59PM -0700, Linus Torvalds wrote: > On Sun, Oct 6, 2019 at 11:07 AM Linus Torvalds > wrote: > > > > Yes, we should get this fixed. But I continue to ask you to point to > > the actual binaries for testing.. > > Just to bring the resolution back publicly to lkml

Re: MAP_FIXED_NOREPLACE appears to break older i386 binaries

2019-10-06 Thread Linus Torvalds
On Sun, Oct 6, 2019 at 11:07 AM Linus Torvalds wrote: > > Yes, we should get this fixed. But I continue to ask you to point to > the actual binaries for testing.. Just to bring the resolution back publicly to lkml after rmk sent me test binaries in private email, the end result is commit

Re: MAP_FIXED_NOREPLACE appears to break older i386 binaries

2019-10-06 Thread Linus Torvalds
On Sun, Oct 6, 2019 at 6:09 AM Russell King - ARM Linux admin wrote: > > However, I think it _is_ worth highlighting that we seem to have broken > binary compatibility with older i386 userspace with newer kernels. Yes, we should get this fixed. But I continue to ask you to point to the actual

Re: MAP_FIXED_NOREPLACE appears to break older i386 binaries

2019-10-06 Thread Russell King - ARM Linux admin
On Sat, Oct 05, 2019 at 05:18:05PM -0700, Linus Torvalds wrote: > Duh. > > I only looked at recent issues in this area, and overlooked your > sentence in between the two ELF section dumps, and it appears that you > have already biseced it to something else: I hadn't - I'd looked at the changes

Re: MAP_FIXED_NOREPLACE appears to break older i386 binaries

2019-10-05 Thread Linus Torvalds
Duh. I only looked at recent issues in this area, and overlooked your sentence in between the two ELF section dumps, and it appears that you have already biseced it to something else: On Sat, Oct 5, 2019 at 4:32 PM Russell King - ARM Linux admin wrote: > > Seems we've broken older i386 binaries

Re: MAP_FIXED_NOREPLACE appears to break older i386 binaries

2019-10-05 Thread Linus Torvalds
On Sat, Oct 5, 2019 at 4:32 PM Russell King - ARM Linux admin wrote: > > Under a 4.19 kernel (debian stable), I am surprised to find that some > previously working i386 binaries no longer work, whereas others are > fine. ls, for example, dies with a SEGV, but bash is fine. Hmm. Is this with

MAP_FIXED_NOREPLACE appears to break older i386 binaries

2019-10-05 Thread Russell King - ARM Linux admin
Under a 4.19 kernel (debian stable), I am surprised to find that some previously working i386 binaries no longer work, whereas others are fine. ls, for example, dies with a SEGV, but bash is fine. Looking at the kernel log reveals: [13117.361000] 20899 (ls): Uhuuh, elf segment at