Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-11 Thread Balbir Singh
Rik van Riel wrote: > On Tue, 02 Oct 2007 09:51:11 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > >> I was hopeful of getting the bare minimal infrastructure for memory >> control in mainline, so that review is easy and additional changes >> can be well reviewed as well. > > I am not yet

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-11 Thread Balbir Singh
Rik van Riel wrote: On Tue, 02 Oct 2007 09:51:11 +0530 Balbir Singh [EMAIL PROTECTED] wrote: I was hopeful of getting the bare minimal infrastructure for memory control in mainline, so that review is easy and additional changes can be well reviewed as well. I am not yet convinced that

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-10 Thread Rik van Riel
On Tue, 02 Oct 2007 09:51:11 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > I was hopeful of getting the bare minimal infrastructure for memory > control in mainline, so that review is easy and additional changes > can be well reviewed as well. I am not yet convinced that the way the memory

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-10 Thread Rik van Riel
On Tue, 02 Oct 2007 09:51:11 +0530 Balbir Singh [EMAIL PROTECTED] wrote: I was hopeful of getting the bare minimal infrastructure for memory control in mainline, so that review is easy and additional changes can be well reviewed as well. I am not yet convinced that the way the memory

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-07 Thread Balbir Singh
Hugh Dickins wrote: > On Fri, 5 Oct 2007, Balbir Singh wrote: >> Hugh Dickins wrote: >>> That's where it should happen, yes; but my point is that it very >>> often does not. Because the swap cache page (read in as part of >>> the readaround cluster of some other cgroup, or in swapoff by some >>>

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-07 Thread Hugh Dickins
On Fri, 5 Oct 2007, Balbir Singh wrote: > Hugh Dickins wrote: > > > > That's where it should happen, yes; but my point is that it very > > often does not. Because the swap cache page (read in as part of > > the readaround cluster of some other cgroup, or in swapoff by some > > other cgroup) is

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-07 Thread Hugh Dickins
On Fri, 5 Oct 2007, Balbir Singh wrote: Hugh Dickins wrote: That's where it should happen, yes; but my point is that it very often does not. Because the swap cache page (read in as part of the readaround cluster of some other cgroup, or in swapoff by some other cgroup) is already

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-07 Thread Balbir Singh
Hugh Dickins wrote: On Fri, 5 Oct 2007, Balbir Singh wrote: Hugh Dickins wrote: That's where it should happen, yes; but my point is that it very often does not. Because the swap cache page (read in as part of the readaround cluster of some other cgroup, or in swapoff by some other cgroup)

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-04 Thread Balbir Singh
Hugh Dickins wrote: > On Thu, 4 Oct 2007, Balbir Singh wrote: >> Hugh Dickins wrote: >>> Well, swap control is another subject. I guess for that you'll need >>> to track which cgroup each swap page belongs to (rather more expensive >>> than the current swap_map of unsigned shorts). And I doubt

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-04 Thread Paul Menage
On 10/2/07, Hugh Dickins <[EMAIL PROTECTED]> wrote: > > I accept that full swap control is something you're intending to add > incrementally later; but the current state doesn't make sense to me. One comment on swap - ideally it should be a separate subsystem from the memory controller. That way

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-04 Thread Hugh Dickins
On Thu, 4 Oct 2007, Balbir Singh wrote: > Hugh Dickins wrote: > > Well, swap control is another subject. I guess for that you'll need > > to track which cgroup each swap page belongs to (rather more expensive > > than the current swap_map of unsigned shorts). And I doubt it'll be > > swap

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-04 Thread Hugh Dickins
On Thu, 4 Oct 2007, Balbir Singh wrote: Hugh Dickins wrote: Well, swap control is another subject. I guess for that you'll need to track which cgroup each swap page belongs to (rather more expensive than the current swap_map of unsigned shorts). And I doubt it'll be swap control as such

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-04 Thread Paul Menage
On 10/2/07, Hugh Dickins [EMAIL PROTECTED] wrote: I accept that full swap control is something you're intending to add incrementally later; but the current state doesn't make sense to me. One comment on swap - ideally it should be a separate subsystem from the memory controller. That way

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-04 Thread Balbir Singh
Hugh Dickins wrote: On Thu, 4 Oct 2007, Balbir Singh wrote: Hugh Dickins wrote: Well, swap control is another subject. I guess for that you'll need to track which cgroup each swap page belongs to (rather more expensive than the current swap_map of unsigned shorts). And I doubt it'll be

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-03 Thread Balbir Singh
Hugh Dickins wrote: > On Wed, 3 Oct 2007, Balbir Singh wrote: >> Hugh Dickins wrote: >>> Sorry, Balbir, I've failed to get back to you, still attending to >>> priorities. Let me briefly summarize my issue with the mem controller: >>> you've not yet given enough attention to swap. >> I am open to

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-03 Thread Hugh Dickins
On Wed, 3 Oct 2007, Balbir Singh wrote: > Hugh Dickins wrote: > > > > Sorry, Balbir, I've failed to get back to you, still attending to > > priorities. Let me briefly summarize my issue with the mem controller: > > you've not yet given enough attention to swap. > > I am open to suggestions and

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-03 Thread Balbir Singh
Hugh Dickins wrote: > On Tue, 2 Oct 2007, Balbir Singh wrote: >> Andrew Morton wrote: >>> memory-controller-add-documentation.patch >>> ... >>> kswapd-should-only-wait-on-io-if-there-is-io.patch >>> >>> Hold. This needs a serious going-over by page reclaim people. >> I mostly agree with your

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-03 Thread Balbir Singh
Hugh Dickins wrote: On Tue, 2 Oct 2007, Balbir Singh wrote: Andrew Morton wrote: memory-controller-add-documentation.patch ... kswapd-should-only-wait-on-io-if-there-is-io.patch Hold. This needs a serious going-over by page reclaim people. I mostly agree with your decision. I am a

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-03 Thread Hugh Dickins
On Wed, 3 Oct 2007, Balbir Singh wrote: Hugh Dickins wrote: Sorry, Balbir, I've failed to get back to you, still attending to priorities. Let me briefly summarize my issue with the mem controller: you've not yet given enough attention to swap. I am open to suggestions and ways and

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-03 Thread Balbir Singh
Hugh Dickins wrote: On Wed, 3 Oct 2007, Balbir Singh wrote: Hugh Dickins wrote: Sorry, Balbir, I've failed to get back to you, still attending to priorities. Let me briefly summarize my issue with the mem controller: you've not yet given enough attention to swap. I am open to suggestions

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-02 Thread Hugh Dickins
On Tue, 2 Oct 2007, Balbir Singh wrote: > Andrew Morton wrote: > > memory-controller-add-documentation.patch > > ... > > kswapd-should-only-wait-on-io-if-there-is-io.patch > > > > Hold. This needs a serious going-over by page reclaim people. > > I mostly agree with your decision. I am a

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-02 Thread Hugh Dickins
On Tue, 2 Oct 2007, Balbir Singh wrote: Andrew Morton wrote: memory-controller-add-documentation.patch ... kswapd-should-only-wait-on-io-if-there-is-io.patch Hold. This needs a serious going-over by page reclaim people. I mostly agree with your decision. I am a little concerned

Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-01 Thread Balbir Singh
Andrew Morton wrote: > memory-controller-add-documentation.patch > memory-controller-resource-counters-v7.patch > memory-controller-resource-counters-v7-fix.patch > memory-controller-containers-setup-v7.patch > memory-controller-accounting-setup-v7.patch >

Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-01 Thread Balbir Singh
Andrew Morton wrote: memory-controller-add-documentation.patch memory-controller-resource-counters-v7.patch memory-controller-resource-counters-v7-fix.patch memory-controller-containers-setup-v7.patch memory-controller-accounting-setup-v7.patch memory-controller-memory-accounting-v7.patch