[PATCH v13 06/19] iommu/exynos: add missing cache flush for removed page table entries

2014-05-12 Thread Shaik Ameer Basha
From: Cho KyongHo This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa Tested-by: Grant

[PATCH v13 06/19] iommu/exynos: add missing cache flush for removed page table entries

2014-05-12 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa

[PATCH v12 02/31] iommu/exynos: add missing cache flush for removed page table entries

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa Tested-by: Grant

[PATCH v12 02/31] iommu/exynos: add missing cache flush for removed page table entries

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa

Re: [PATCH v11 02/27] iommu/exynos: add missing cache flush for removed page table entries

2014-03-15 Thread Grant Grundler
age entries > in exynos_iommu_unmap(). Missing cache flush of removed page table > entries can cause missing page fault interrupt when a master IP > accesses an unmapped area. > > Reviewed-by: Tomasz Figa > Tested-by: Grant Grundler > Signed-off-by: Cho KyongHo > --- >

Re: [PATCH v11 02/27] iommu/exynos: add missing cache flush for removed page table entries

2014-03-15 Thread Grant Grundler
small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa t.f...@samsung.com Tested-by: Grant Grundler grund...@chromium.org Signed-off

[PATCH v11 02/27] iommu/exynos: add missing cache flush for removed page table entries

2014-03-13 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa Tested-by: Grant Grundler Signed-off

[PATCH v11 02/27] iommu/exynos: add missing cache flush for removed page table entries

2014-03-13 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa t.f...@samsung.com Tested-by: Grant Grundler

[PATCH v10 02/20] iommu/exynos: add missing cache flush for removed page table entries

2013-10-06 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa Tested-by: Grant Grundler Signed-off

[PATCH v10 02/20] iommu/exynos: add missing cache flush for removed page table entries

2013-10-06 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa t.f...@samsung.com Tested-by: Grant Grundler

Re: [PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 15:44:09 +0200, Tomasz Figa wrote: > On Thursday 08 of August 2013 18:37:34 Cho KyongHo wrote: > > This commit adds cache flush for removed small and large page entries > > in exynos_iommu_unmap(). Missing cache flush of removed page table > > entries c

Re: [PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Tomasz Figa
On Thursday 08 of August 2013 18:37:34 Cho KyongHo wrote: > This commit adds cache flush for removed small and large page entries > in exynos_iommu_unmap(). Missing cache flush of removed page table > entries can cause missing page fault interrupt when a master IP > accesses an u

[PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Tested-by: Grant Grundler Signed-off-by: Cho KyongHo --- drivers

[PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Tested-by: Grant Grundler grund...@chromium.org Signed-off-by: Cho

Re: [PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Tomasz Figa
On Thursday 08 of August 2013 18:37:34 Cho KyongHo wrote: This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area

Re: [PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 15:44:09 +0200, Tomasz Figa wrote: On Thursday 08 of August 2013 18:37:34 Cho KyongHo wrote: This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault

Re: [PATCH v8 02/12] iommu/exynos: add missing cache flush for removed page table entries

2013-07-26 Thread Grant Grundler
On Fri, Jul 26, 2013 at 4:26 AM, Cho KyongHo wrote: > This commit adds cache flush for removed small and large page entries > in exynos_iommu_unmap(). Missing cache flush of removed page table > entries can cause missing page fault interrupt when a master IP > accesses an u

[PATCH v8 02/12] iommu/exynos: add missing cache flush for removed page table entries

2013-07-26 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c |2

[PATCH v8 02/12] iommu/exynos: add missing cache flush for removed page table entries

2013-07-26 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu

Re: [PATCH v8 02/12] iommu/exynos: add missing cache flush for removed page table entries

2013-07-26 Thread Grant Grundler
On Fri, Jul 26, 2013 at 4:26 AM, Cho KyongHo pullip@samsung.com wrote: This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-08 Thread Grant Grundler
On Mon, Jul 8, 2013 at 11:21 AM, Grant Grundler wrote: > On Thu, Jul 4, 2013 at 4:20 AM, Cho KyongHo wrote: > ... >> I am still working on the patch set when I am free. >> Implementation of the updated patch set has been finished but not tested yet. >> >> I will post the patches after simple

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-08 Thread Grant Grundler
On Thu, Jul 4, 2013 at 4:20 AM, Cho KyongHo wrote: ... > I am still working on the patch set when I am free. > Implementation of the updated patch set has been finished but not tested yet. > > I will post the patches after simple test :) Ok - thanks Cho! If you'd like me to test, please post a

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-08 Thread Grant Grundler
On Thu, Jul 4, 2013 at 4:20 AM, Cho KyongHo pullip@samsung.com wrote: ... I am still working on the patch set when I am free. Implementation of the updated patch set has been finished but not tested yet. I will post the patches after simple test :) Ok - thanks Cho! If you'd like me to

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-08 Thread Grant Grundler
On Mon, Jul 8, 2013 at 11:21 AM, Grant Grundler grund...@chromium.org wrote: On Thu, Jul 4, 2013 at 4:20 AM, Cho KyongHo pullip@samsung.com wrote: ... I am still working on the patch set when I am free. Implementation of the updated patch set has been finished but not tested yet. I will

[PATCH v7 2/9] iommu/exynos: add missing cache flush for removed page table entries

2013-07-05 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c |2

[PATCH v7 2/9] iommu/exynos: add missing cache flush for removed page table entries

2013-07-05 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu

RE: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-04 Thread Cho KyongHo
all page and large page > >> entries in exynos_iommu_unmap(). Missing cache flush of removed page > >> table entries can cause missing page fault interrupt when a master IP > >> accesses an unmapped area. > > > > KyongHo, > > It appears this patch was never applie

RE: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-04 Thread Cho KyongHo
in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. KyongHo, It appears this patch was never applied and got caught up in the device tree binding discussion. AFAICT, this patch is still

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-03 Thread Grant Grundler
Ping? On Mon, Jul 1, 2013 at 6:49 PM, Grant Grundler wrote: > On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote: >> This commit adds cache flush for removed small page and large page >> entries in exynos_iommu_unmap(). Missing cache flush of removed >> p

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-03 Thread Grant Grundler
Ping? On Mon, Jul 1, 2013 at 6:49 PM, Grant Grundler grund...@chromium.org wrote: On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote: This commit adds cache flush for removed small page and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-01 Thread Grant Grundler
-linux-arm (wrong email address - sorry) On Mon, Jul 1, 2013 at 6:49 PM, Grant Grundler wrote: > On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote: >> This commit adds cache flush for removed small page and large page >> entries in exynos_iommu_unmap(). Miss

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-01 Thread Grant Grundler
On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote: > This commit adds cache flush for removed small page and large page > entries in exynos_iommu_unmap(). Missing cache flush of removed > page table entries can cause missing page fault interrupt when a > master

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-01 Thread Grant Grundler
On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote: This commit adds cache flush for removed small page and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped

Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2013-07-01 Thread Grant Grundler
cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. KyongHo, It appears this patch was never applied and got caught up in the device tree binding discussion. AFAICT, this patch is still necessary. Can you resubmit

[PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2012-12-25 Thread Cho KyongHo
This commit adds cache flush for removed small page and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Signed-off-by: KyongHo Cho --- drivers/iommu/exynos-iommu.c

[PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

2012-12-25 Thread Cho KyongHo
This commit adds cache flush for removed small page and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Signed-off-by: KyongHo Cho pullip@samsung.com --- drivers

[PATCH v5 01/14] iommu/exynos: add missing cache flush for removed pagetable entries

2012-12-11 Thread Cho KyongHo
This commit adds cache flush for removed small page and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Signed-off-by: KyongHo Cho --- drivers/iommu/exynos-iommu.c

[PATCH v5 01/14] iommu/exynos: add missing cache flush for removed pagetable entries

2012-12-11 Thread Cho KyongHo
This commit adds cache flush for removed small page and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Signed-off-by: KyongHo Cho pullip@samsung.com --- drivers

Re: Missing cache flush.

2001-06-06 Thread Albert D. Cahalan
David S. Miller writes: > David Woodhouse writes: >>> Call it flush_ecache_full() or something. >> >> Strange name. Why? How about __flush_cache_range()? > > How about flush_cache_range_force() instead? > > I want something in the name that tells the reader "this flushes > the caches, even

Re: Missing cache flush.

2001-06-06 Thread Albert D. Cahalan
David S. Miller writes: David Woodhouse writes: Call it flush_ecache_full() or something. Strange name. Why? How about __flush_cache_range()? How about flush_cache_range_force() instead? I want something in the name that tells the reader this flushes the caches, even though under every

Re: Missing cache flush.

2001-06-05 Thread Daniel Phillips
On Tuesday 05 June 2001 14:57, Chris Wedgwood wrote: > I don't know about the CRIS (never heard of it, what is it?) I wondered about that too. From Documentation/cris: What is CRIS ? -- CRIS is an acronym for 'Code Reduced Instruction Set'. It is the CPU architecture in Axis

Re: Missing cache flush.

2001-06-05 Thread Ralf Baechle
On Tue, Jun 05, 2001 at 10:29:28AM +0200, Ingo Molnar wrote: > > - even when it works, it is necessarily very very very slow. Not to be > >used lightly. As you can imagine, the work-around is even slower. > > i've measured it once, IIRC it was around 10-15 millisecs on normal > pentiums,

Re: Missing cache flush.

2001-06-05 Thread Ralf Baechle
On Wed, Jun 06, 2001 at 12:57:03AM +1200, Chris Wedgwood wrote: > I don't know about the CRIS (never heard of it, what is it?), but on > an Athlon when benchmarking stuff, I could still see L1 cache hits > from data that was 15 seconds old under certain work-loads (obviously > not gcc!). Does

Re: Missing cache flush.

2001-06-05 Thread Vipin Malik
Bjorn Wesen wrote: > > I'd agree that to be really certain, a "flush_dcache()" function > should be implemented and used when an erase finishes. Like David Miller > wrote somewhere in the thread, one way is to use your knowledge of the > arch's cache and do suitable dummy accesses to flush it,

Re: Missing cache flush.

2001-06-05 Thread David Woodhouse
[EMAIL PROTECTED] said: > How about flush_cache_range_force() instead? > I want something in the name that tells the reader "this flushes the > caches, even though under every other ordinary circumstance you would > not need to". OL, then. I would have thought it made more sense to have the

Re: Missing cache flush.

2001-06-05 Thread David S. Miller
David Woodhouse writes: > > Call it flush_ecache_full() or something. > > Strange name. Why? How about __flush_cache_range()? How about flush_cache_range_force() instead? I want something in the name that tells the reader "this flushes the caches, even though under every other ordinary

Re: Missing cache flush.

2001-06-05 Thread David Woodhouse
[EMAIL PROTECTED] said: > David Woodhouse writes: > > What shall we call this function? The intuitive "flush_dcache_range" > > appears to have already been taken. > Call it flush_ecache_full() or something. Strange name. Why? How about __flush_cache_range()? -- dwmw2 - To unsubscribe from

Re: Missing cache flush.

2001-06-05 Thread Johan Adolfsson
Possibly saying something extremly stupid here, how about simply "fakewriting" 0xFF to the flash after an erase to update any caches? > 2. Flash. A few writes of magic data to magic addresses and a whole erase >block suddenly contains 0xFF. The CPU doesn't notice that either.

Re: Missing cache flush.

2001-06-05 Thread Bjorn Wesen
On Tue, 5 Jun 2001, David Woodhouse wrote: > The flash mapping driver arch/cris/drivers/axisflashmap.c uses a cached > mapping of the flash chips for bulk reads, but obviously an uncached mapping > for sending commands and reading status when we're actually writing to or > erasing parts of the

Re: Missing cache flush.

2001-06-05 Thread David S. Miller
David Woodhouse writes: > What shall we call this function? The intuitive "flush_dcache_range" appears > to have already been taken. Call it flush_ecache_full() or something. Many architectures need to implement this anyways if they have parity error exception handling. Most platforms sadly

Re: Missing cache flush.

2001-06-05 Thread Ingo Molnar
On 4 Jun 2001, Linus Torvalds wrote: > - even when it works, it is necessarily very very very slow. Not to be >used lightly. As you can imagine, the work-around is even slower. i've measured it once, IIRC it was around 10-15 millisecs on normal pentiums, so while it's indeed the slowest

Re: Missing cache flush.

2001-06-05 Thread Ingo Molnar
On 4 Jun 2001, Linus Torvalds wrote: - even when it works, it is necessarily very very very slow. Not to be used lightly. As you can imagine, the work-around is even slower. i've measured it once, IIRC it was around 10-15 millisecs on normal pentiums, so while it's indeed the slowest x86

Re: Missing cache flush.

2001-06-05 Thread Bjorn Wesen
On Tue, 5 Jun 2001, David Woodhouse wrote: The flash mapping driver arch/cris/drivers/axisflashmap.c uses a cached mapping of the flash chips for bulk reads, but obviously an uncached mapping for sending commands and reading status when we're actually writing to or erasing parts of the chip.

Re: Missing cache flush.

2001-06-05 Thread Johan Adolfsson
Possibly saying something extremly stupid here, how about simply fakewriting 0xFF to the flash after an erase to update any caches? 2. Flash. A few writes of magic data to magic addresses and a whole erase block suddenly contains 0xFF. The CPU doesn't notice that either. do_erase_stuff();

Re: Missing cache flush.

2001-06-05 Thread Vipin Malik
Bjorn Wesen wrote: I'd agree that to be really certain, a flush_dcache() function should be implemented and used when an erase finishes. Like David Miller wrote somewhere in the thread, one way is to use your knowledge of the arch's cache and do suitable dummy accesses to flush it, if there

Re: Missing cache flush.

2001-06-05 Thread Ralf Baechle
On Wed, Jun 06, 2001 at 12:57:03AM +1200, Chris Wedgwood wrote: I don't know about the CRIS (never heard of it, what is it?), but on an Athlon when benchmarking stuff, I could still see L1 cache hits from data that was 15 seconds old under certain work-loads (obviously not gcc!). Does anyone

Re: Missing cache flush.

2001-06-05 Thread Ralf Baechle
On Tue, Jun 05, 2001 at 10:29:28AM +0200, Ingo Molnar wrote: - even when it works, it is necessarily very very very slow. Not to be used lightly. As you can imagine, the work-around is even slower. i've measured it once, IIRC it was around 10-15 millisecs on normal pentiums, so while

Re: Missing cache flush.

2001-06-05 Thread Daniel Phillips
On Tuesday 05 June 2001 14:57, Chris Wedgwood wrote: I don't know about the CRIS (never heard of it, what is it?) I wondered about that too. From Documentation/cris: What is CRIS ? -- CRIS is an acronym for 'Code Reduced Instruction Set'. It is the CPU architecture in Axis

Re: Missing cache flush.

2001-06-05 Thread David Woodhouse
[EMAIL PROTECTED] said: How about flush_cache_range_force() instead? I want something in the name that tells the reader this flushes the caches, even though under every other ordinary circumstance you would not need to. OL, then. I would have thought it made more sense to have the

Re: Missing cache flush.

2001-06-05 Thread David Woodhouse
[EMAIL PROTECTED] said: David Woodhouse writes: What shall we call this function? The intuitive flush_dcache_range appears to have already been taken. Call it flush_ecache_full() or something. Strange name. Why? How about __flush_cache_range()? -- dwmw2 - To unsubscribe from this

Re: Missing cache flush.

2001-06-05 Thread David S. Miller
David Woodhouse writes: Call it flush_ecache_full() or something. Strange name. Why? How about __flush_cache_range()? How about flush_cache_range_force() instead? I want something in the name that tells the reader this flushes the caches, even though under every other ordinary

Re: Missing cache flush.

2001-06-05 Thread David S. Miller
David Woodhouse writes: What shall we call this function? The intuitive flush_dcache_range appears to have already been taken. Call it flush_ecache_full() or something. Many architectures need to implement this anyways if they have parity error exception handling. Most platforms sadly do

Re: Missing cache flush.

2001-06-04 Thread Linus Torvalds
In article <[EMAIL PROTECTED]>, Chris Wedgwood <[EMAIL PROTECTED]> wrote: >On Mon, Jun 04, 2001 at 07:03:01PM -0700, David S. Miller wrote: > >The x86 doesn't have dumb caches, therefore it really doesn't >need to flush anything. Maybe a mb(), but that is it. > >What if the memory is

Re: Missing cache flush.

2001-06-04 Thread David S. Miller
David Woodhouse writes: > > What should it do on i386? mb()? > > For it to have any use in the situation I described, it would need to > writeback and invalidate the dcache for the affected range. It doesn't seem > to do so, so it seems that it isn't what I require. It only needs to

Re: Missing cache flush.

2001-06-04 Thread David S. Miller
Jeff Garzik writes: > David Woodhouse wrote: > > I was pointed at Documentation/DMA-mapping.txt but that doesn't seem very > > helpful - it's very PCI-specific, and a quick perusal of pci_dma_sync() on > > i386 shows that it doesn't do what's required anyway. > > What should it do on

Re: Missing cache flush.

2001-06-04 Thread David Woodhouse
[EMAIL PROTECTED] said: > > I was pointed at Documentation/DMA-mapping.txt but that doesn't seem > > very helpful - it's very PCI-specific, and a quick perusal of > > pci_dma_sync() on i386 shows that it doesn't do what's required anyway. > What should it do on i386? mb()? For it to have any

Re: Missing cache flush.

2001-06-04 Thread Jeff Garzik
David Woodhouse wrote: > I was pointed at Documentation/DMA-mapping.txt but that doesn't seem very > helpful - it's very PCI-specific, and a quick perusal of pci_dma_sync() on > i386 shows that it doesn't do what's required anyway. What should it do on i386? mb()? -- Jeff Garzik |

Missing cache flush.

2001-06-04 Thread David Woodhouse
The flash mapping driver arch/cris/drivers/axisflashmap.c uses a cached mapping of the flash chips for bulk reads, but obviously an uncached mapping for sending commands and reading status when we're actually writing to or erasing parts of the chip. However, it fails to flush the dcache for the

Missing cache flush.

2001-06-04 Thread David Woodhouse
The flash mapping driver arch/cris/drivers/axisflashmap.c uses a cached mapping of the flash chips for bulk reads, but obviously an uncached mapping for sending commands and reading status when we're actually writing to or erasing parts of the chip. However, it fails to flush the dcache for the

Re: Missing cache flush.

2001-06-04 Thread Jeff Garzik
David Woodhouse wrote: I was pointed at Documentation/DMA-mapping.txt but that doesn't seem very helpful - it's very PCI-specific, and a quick perusal of pci_dma_sync() on i386 shows that it doesn't do what's required anyway. What should it do on i386? mb()? -- Jeff Garzik | Echelon

Re: Missing cache flush.

2001-06-04 Thread David Woodhouse
[EMAIL PROTECTED] said: I was pointed at Documentation/DMA-mapping.txt but that doesn't seem very helpful - it's very PCI-specific, and a quick perusal of pci_dma_sync() on i386 shows that it doesn't do what's required anyway. What should it do on i386? mb()? For it to have any use in

Re: Missing cache flush.

2001-06-04 Thread David S. Miller
Jeff Garzik writes: David Woodhouse wrote: I was pointed at Documentation/DMA-mapping.txt but that doesn't seem very helpful - it's very PCI-specific, and a quick perusal of pci_dma_sync() on i386 shows that it doesn't do what's required anyway. What should it do on i386? mb()?

Re: Missing cache flush.

2001-06-04 Thread Linus Torvalds
In article [EMAIL PROTECTED], Chris Wedgwood [EMAIL PROTECTED] wrote: On Mon, Jun 04, 2001 at 07:03:01PM -0700, David S. Miller wrote: The x86 doesn't have dumb caches, therefore it really doesn't need to flush anything. Maybe a mb(), but that is it. What if the memory is erased

Re: Missing cache flush.

2001-06-04 Thread David S. Miller
David Woodhouse writes: What should it do on i386? mb()? For it to have any use in the situation I described, it would need to writeback and invalidate the dcache for the affected range. It doesn't seem to do so, so it seems that it isn't what I require. It only needs to do that