Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-03 Thread Jarek Poplawski
On Thu, Aug 02, 2007 at 10:59:23AM -0500, Matt Mackall wrote: > On Thu, Aug 02, 2007 at 11:00:08AM +0200, Jarek Poplawski wrote: > > On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote: ... > > > How about cc:ing the netpoll maintainer? > > > > Is there a new one or do you suggest

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-03 Thread Jarek Poplawski
On Thu, Aug 02, 2007 at 10:59:23AM -0500, Matt Mackall wrote: On Thu, Aug 02, 2007 at 11:00:08AM +0200, Jarek Poplawski wrote: On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote: ... How about cc:ing the netpoll maintainer? Is there a new one or do you suggest possibility of

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Matt Mackall
On Thu, Aug 02, 2007 at 11:00:08AM +0200, Jarek Poplawski wrote: > On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote: > > On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: > > > On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: > > > > Jarek Poplawski wrote: > >

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Jarek Poplawski
On Thu, Aug 02, 2007 at 05:26:12PM +0530, Satyam Sharma wrote: ... > Whoops, I only said that in humour, probably should've snuck in a > smiley or two. Definitely not blaming anybody. Apologies to anyone > who felt offended, sorry, nothing such was intended, I assure. I see you probably didn't

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Satyam Sharma
On Thu, 2 Aug 2007, Jarek Poplawski wrote: > On Thu, Aug 02, 2007 at 04:02:21PM +0530, Satyam Sharma wrote: > [...] > How often "common" developer has to make such decisions in Kconfig? > Probably no more than once per year. So, it's fair to blame anybody > for not reading lkml to find if there

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Jarek Poplawski
On Thu, Aug 02, 2007 at 04:02:21PM +0530, Satyam Sharma wrote: > Hi, > > > On Thu, 2 Aug 2007, Sam Ravnborg wrote: > > > > > > > > > ... > > > > endif # NETDEVICES > > > > > > > > config NETPOLL > > > > depends on NETDEVICES > > > > def_bool NETCONSOLE > > > > > > > > config

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Satyam Sharma
[ Read through the thread, looked at Kconfig files, did some tests. Adding Kconfig experts to Cc: list. ] > On Thu, 2 Aug 2007, Sam Ravnborg wrote: > > > > > > > > > ... > > > > endif # NETDEVICES > > > > > > > > config NETPOLL > > > > depends on NETDEVICES > > > > def_bool

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Satyam Sharma
Hi, On Thu, 2 Aug 2007, Sam Ravnborg wrote: > > > > > > ... > > > endif # NETDEVICES > > > > > > config NETPOLL > > > depends on NETDEVICES > > > def_bool NETCONSOLE > > > > > > config NETPOLL_TRAP > > > bool "Netpoll traffic trapping" > > > default n > > >

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Sam Ravnborg
> > > > ... > > endif # NETDEVICES > > > > config NETPOLL > > depends on NETDEVICES > > def_bool NETCONSOLE > > > > config NETPOLL_TRAP > > bool "Netpoll traffic trapping" > > default n > > depends on NETPOLL > > > > config NET_POLL_CONTROLLER > >

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Jarek Poplawski
On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote: > On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: > > On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: > > > Jarek Poplawski wrote: > > > > On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: > > > >>

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Jarek Poplawski
On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote: On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: Jarek Poplawski wrote: On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: Jarek Poplawski

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Sam Ravnborg
... endif # NETDEVICES config NETPOLL depends on NETDEVICES def_bool NETCONSOLE config NETPOLL_TRAP bool Netpoll traffic trapping default n depends on NETPOLL config NET_POLL_CONTROLLER def_bool NETPOLL

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Satyam Sharma
Hi, On Thu, 2 Aug 2007, Sam Ravnborg wrote: ... endif # NETDEVICES config NETPOLL depends on NETDEVICES def_bool NETCONSOLE config NETPOLL_TRAP bool Netpoll traffic trapping default n depends on NETPOLL config

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Jarek Poplawski
On Thu, Aug 02, 2007 at 04:02:21PM +0530, Satyam Sharma wrote: Hi, On Thu, 2 Aug 2007, Sam Ravnborg wrote: ... endif # NETDEVICES config NETPOLL depends on NETDEVICES def_bool NETCONSOLE config NETPOLL_TRAP bool Netpoll

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Satyam Sharma
On Thu, 2 Aug 2007, Jarek Poplawski wrote: On Thu, Aug 02, 2007 at 04:02:21PM +0530, Satyam Sharma wrote: [...] How often common developer has to make such decisions in Kconfig? Probably no more than once per year. So, it's fair to blame anybody for not reading lkml to find if there are

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Satyam Sharma
[ Read through the thread, looked at Kconfig files, did some tests. Adding Kconfig experts to Cc: list. ] On Thu, 2 Aug 2007, Sam Ravnborg wrote: ... endif # NETDEVICES config NETPOLL depends on NETDEVICES def_bool NETCONSOLE config

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Jarek Poplawski
On Thu, Aug 02, 2007 at 05:26:12PM +0530, Satyam Sharma wrote: ... Whoops, I only said that in humour, probably should've snuck in a smiley or two. Definitely not blaming anybody. Apologies to anyone who felt offended, sorry, nothing such was intended, I assure. I see you probably didn't

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Matt Mackall
On Thu, Aug 02, 2007 at 11:00:08AM +0200, Jarek Poplawski wrote: On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote: On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: Jarek Poplawski wrote: On Tue,

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-01 Thread Matt Mackall
On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: > On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: > > Jarek Poplawski wrote: > > > On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: > > >> Jarek Poplawski wrote: > > >>> On 28-07-2007 20:42, Gabriel C wrote: > >

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-01 Thread Jarek Poplawski
On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: > Jarek Poplawski wrote: > > On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: > >> Jarek Poplawski wrote: > >>> On 28-07-2007 20:42, Gabriel C wrote: > Andrew Morton wrote: > > On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-01 Thread Jarek Poplawski
On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: Jarek Poplawski wrote: On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: Jarek Poplawski wrote: On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED]

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-01 Thread Matt Mackall
On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: Jarek Poplawski wrote: On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: Jarek Poplawski wrote: On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Gabriel C
Jarek Poplawski wrote: > On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: >> Jarek Poplawski wrote: >>> On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: > On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > >> Hi, >> >> I got this

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jarek Poplawski
On Tue, Jul 31, 2007 at 06:44:52AM -0500, Jason Wessel wrote: ... > kgdboe is completely useless without a network card that has a polling > driver. It seems to me that the simple and easy fix is to set it to > depend on NETDEVICES but allow it to use select on NETPOLL. Maybe I miss your point

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jarek Poplawski
On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: > Jarek Poplawski wrote: > > On 28-07-2007 20:42, Gabriel C wrote: > >> Andrew Morton wrote: > >>> On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > >>> > Hi, > > I got this compile error with a

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jason Wessel
Gabriel C wrote: Jarek Poplawski wrote: On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: Hi, I got this compile error with a randconfig (

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Gabriel C
Jarek Poplawski wrote: > On 28-07-2007 20:42, Gabriel C wrote: >> Andrew Morton wrote: >>> On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: >>> Hi, I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jarek Poplawski
On 28-07-2007 20:42, Gabriel C wrote: > Andrew Morton wrote: >> On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: >> >>> Hi, >>> >>> I got this compile error with a randconfig ( >>> http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). >>> >>> ... >>> >>>

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jarek Poplawski
On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED] wrote: Hi, I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). ... net/core/netpoll.c: In function

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Gabriel C
Jarek Poplawski wrote: On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED] wrote: Hi, I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). ...

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jason Wessel
Gabriel C wrote: Jarek Poplawski wrote: On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED] wrote: Hi, I got this compile error with a randconfig (

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jarek Poplawski
On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: Jarek Poplawski wrote: On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED] wrote: Hi, I got this compile error with a randconfig (

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jarek Poplawski
On Tue, Jul 31, 2007 at 06:44:52AM -0500, Jason Wessel wrote: ... kgdboe is completely useless without a network card that has a polling driver. It seems to me that the simple and easy fix is to set it to depend on NETDEVICES but allow it to use select on NETPOLL. Maybe I miss your point

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Gabriel C
Jarek Poplawski wrote: On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: Jarek Poplawski wrote: On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED] wrote: Hi, I got this compile error with a randconfig (

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-28 Thread Gabriel C
Andrew Morton wrote: > On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > >> Hi, >> >> I got this compile error with a randconfig ( >> http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). >> >> ... >> >> net/core/netpoll.c: In function 'netpoll_poll': >>

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-28 Thread Andrew Morton
On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > Hi, > > I got this compile error with a randconfig ( > http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). > > ... > > net/core/netpoll.c: In function 'netpoll_poll': > net/core/netpoll.c:155: error:

NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-28 Thread Gabriel C
Hi, I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). ... net/core/netpoll.c: In function 'netpoll_poll': net/core/netpoll.c:155: error: 'struct net_device' has no member named 'poll_controller' net/core/netpoll.c:159: error: 'struct

NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-28 Thread Gabriel C
Hi, I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). ... net/core/netpoll.c: In function 'netpoll_poll': net/core/netpoll.c:155: error: 'struct net_device' has no member named 'poll_controller' net/core/netpoll.c:159: error: 'struct

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-28 Thread Andrew Morton
On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED] wrote: Hi, I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). ... net/core/netpoll.c: In function 'netpoll_poll': net/core/netpoll.c:155: error: 'struct

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-28 Thread Gabriel C
Andrew Morton wrote: On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED] wrote: Hi, I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). ... net/core/netpoll.c: In function 'netpoll_poll': net/core/netpoll.c:155: